[Bug 13318] New: C4::Acq::GetParcel is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Bug ID: 13318 Summary: C4::Acq::GetParcel is not used and can be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org The subroutine C4::Acquisition::GetParcel is never used in the code. It can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |12826 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33774&action=edit Bug 13318: Delete C4::Acq::GetParcel Test plan: git grep GetParcel should not return use of this subroutine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33774|0 |1 is obsolete| | CC| |matted-34813@mypacks.net --- Comment #2 from wajasu <matted-34813@mypacks.net> --- Created attachment 34011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34011&action=edit Bug-13318-Delete-C4-Acq-GetParcel.patch Reviewed code. # before patch git grep GetParcel C4/Acquisition.pm: &GetParcels &GetParcel C4/Acquisition.pm:=head3 GetParcel C4/Acquisition.pm: @results = &GetParcel($booksellerid, $code, $date); C4/Acquisition.pm:sub GetParcel { C4/Acquisition.pm:=head3 GetParcels C4/Acquisition.pm: $results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto); C4/Acquisition.pm:sub GetParcels { #after patch git grep GetParcel C4/Acquisition.pm: &GetParcels C4/Acquisition.pm:=head3 GetParcels C4/Acquisition.pm: $results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto); C4/Acquisition.pm:sub GetParcels { Dead code removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34011|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34150&action=edit [PASSED QA] Bug 13318: Delete C4::Acq::GetParcel Test plan: git grep GetParcel should not return use of this subroutine. Signed-off-by: wajasu <matted@34813.mypacks.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Bug 13318 depends on bug 12826, which changed state. Bug 12826 Summary: GST / VAT rewrite - plumbing http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org