[Bug 35570] New: Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Bug ID: 35570 Summary: Add a generic master form in ILL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: andrew.auld@ptfs-europe.com, katrin.fischer@bsz-bw.de, magnus@libriotech.no, nick@bywatersolutions.com, pedro.amorim@ptfs-europe.com, tomascohen@gmail.com The idea is to: 1) Have a generic master form in ILL based on current FreeForm's form at: https://github.com/PTFS-Europe/koha-ill-freeform 2) Deprecate the above FreeForm backend 3) Perhaps rethink the name to "Standard", "Default", something like that? 4) Migrate FreeForm requests for this new "Standard backend" built in core on upgrade Reasoning behind this: - The ILL module does not work out of the box, it requires at least one backend to work. This is not great as ideally enabling the system preference should be enough to make use of the module, without additional work being needed. - This master form in core would allow for future extensions of the ILL module, could be used as baseline for future work that will optionally not require the user (Staff/OPAC) to pick the backend beforehand if several backends are installed - the user may not know which backend to pick, they likely just know what they're looking for. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I love the idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35581 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 [Bug 35581] ILL Koha classes are not consistent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- (In reply to Pedro Amorim from comment #0)
Thoughts?
Sounds like a great idea! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159942&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159943&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159944&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159946&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159947&action=edit Bug 35570: (QA follow-up): Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I have named the new core backend 'Standard' but I don't feel strongly about this, opinions/suggestions welcomed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- I applied the first three patches (I didn't apply the last two - Prevent use of ILL module if deprecated FreeForm backend is installed + QA follow-up). When I run the database update it says nothing should happen (Step 1, Atomicupdate patch), but I get: updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [21:14:02]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: Finished database update. I'm confused about the sequence to test this.... is it: - Run through the test plan in the 'Atomicupdate' patch - Apply the remaining two patches - Run through the test plan in the 'Prevent use of ILL module if deprecated FreeForm backend is installed' patch Or something else? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Nind from comment #9)
I applied the first three patches (I didn't apply the last two - Prevent use of ILL module if deprecated FreeForm backend is installed + QA follow-up).
When I run the database update it says nothing should happen (Step 1, Atomicupdate patch), but I get:
updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [21:14:02]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: Finished database update.
I'm confused about the sequence to test this.... is it: - Run through the test plan in the 'Atomicupdate' patch - Apply the remaining two patches - Run through the test plan in the 'Prevent use of ILL module if deprecated FreeForm backend is installed' patch
Or something else?
Hi David, thank you so much for looking and your outstanding testing. The test plan is indeed a bit confusing, apologies. But you're correct in the order it should be tested.
Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: Finished database update.
The above messages are standard and should always show, even if no 'FreeForm' data was found - i.e. nothing was updated in the database - it at least verified successfully IF something needed to be updated. In the case something is actually updated, you'll see the following messages: - Updated ILL batches from 'FreeFom' to 'Standard" - Updated ILL request attributes from 'FreeForm' to 'Standard" - Updated ILL requests from 'FreeForm' to 'Standard For the atomicupdate test plan, you should also get an extra message related to existing SQL reports that contain the word 'FreeForm'. I hope this helps makes things clearer and, again, thank you very much! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160452&action=edit Bug 35570: QA follow-up: Update updatedatabase report colors to base on bug 35681 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 [Bug 35681] Add support for colored messages in the output of updatedatabase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160457&action=edit Bug 35570: (QA follow-up): Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from David Nind <david@davidnind.com> --- I'm now getting this error after applying the first three patches (and dependent patches), for step 3 in the Atomicupdate patch: Can't locate Koha/Illrequests.pm in @INC (you may need to install the Koha::Illrequests module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/koha/installer /kohadevbox/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) at /kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/ILL/Request.pm line 464 in Koha::ILL::Request::load_backend at /kohadevbox/koha/Koha/ILL/Request.pm line 464 461: my @raw = qw/Koha Illbackends/; # Base Path 462: my $location = join "/", @raw, $backend_name, "Base.pm"; # File to load 463: my $backend_class = join "::", @raw, $backend_name, "Base"; # Package name 464: require $location; 465: $self->{_my_backend} = $backend_class->new($backend_params); 466: } 467: .... I also tried applying all the patches, and still got the error. I'm sure I got past this point for my previous testing... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Nind from comment #13)
I'm now getting this error after applying the first three patches (and dependent patches), for step 3 in the Atomicupdate patch:
Can't locate Koha/Illrequests.pm in @INC (you may need to install the Koha::Illrequests module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/koha/installer /kohadevbox/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) at /kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Illbackends/FreeForm/Base.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/ILL/Request.pm line 464
in Koha::ILL::Request::load_backend at /kohadevbox/koha/Koha/ILL/Request.pm line 464
461: my @raw = qw/Koha Illbackends/; # Base Path 462: my $location = join "/", @raw, $backend_name, "Base.pm"; # File to load 463: my $backend_class = join "::", @raw, $backend_name, "Base"; # Package name 464: require $location; 465: $self->{_my_backend} = $backend_class->new($backend_params); 466: } 467:
....
I also tried applying all the patches, and still got the error.
I'm sure I got past this point for my previous testing...
Hi David, thanks for persevering. I believe the error you're getting is because you may have skipped this step: 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ After you git checkout reorganize_ILL in FreeForm you may have to koha-plack --restart. Would you please try again? Reach out to me on IRC, I'm always available. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35725 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725 [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159942|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 160654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160654&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159943|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 160655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160655&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159944|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 160656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160656&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159946|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 160657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160657&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159947|0 |1 is obsolete| | Attachment #160457|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 160658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160658&action=edit Bug 35570: (QA follow-up): Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160452|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 160659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160659&action=edit Bug 35570: QA follow-up: Update updatedatabase report colors to base on bug 35681 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 160660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160660&action=edit Bug 35570: (QA follow-up): Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #22 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #14) ...
I believe the error you're getting is because you may have skipped this step: 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/
After you git checkout reorganize_ILL in FreeForm you may have to koha-plack --restart. Would you please try again? Reach out to me on IRC, I'm always available. Thanks!
Thanks Pedro. That was the issue! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #23 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Apply the first three patches: - Bug 35570: Put 'FreeForm' backend into core as 'Standard' - Bug 35570: Consider 'Standard' core backend - Bug 35570: Atomicupdate Notes: - Apply all the dependent bugs - For 35570 (this bug) use i (for interactive) and add a # hash in front of the patches not to apply at this time 2. Run the database update: updatedatabase => Output: Upgrade to 23.12.00.003 [18:41:32]: Bug 35681 - Test DB Rev output Something in red is a warning Somthing in yellow is a call to action Something in blue is for information only You could use 'WHITE' too? Or leave color off and stick to default DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [18:41:32]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: Finished database update. DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [18:41:32]: Bug 35681 - Test Atomic update output Something in red is a warning Somthing in yellow is a call to action Something in blue is for information only You could use 'WHITE' too? Or leave color off and stick to default 3. Install the FreeForm backend. Run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 4. Change the FreeForm branch to reorganize_ILL. From within the Koha/Illbackends/FreeForm directory: git checkout reorganize_ILL 5. Run flush_memcached and restart_all (not sure whether these are required here, but I ran them anyway). 6. Install the Pubmed plugin: - Download from https://github.com/PTFS-Europe/koha-plugin-api-pubmed - Upload the plugin: Koha administration > Plugins > Manage plugins - Run restart_all 7. Create a new 'FreeForm' ILL batch: - + New ILL requests batch - Select the 'FreeForm' option - Batch details: . Batch name: BZ35570 . Card number...: 42 (koha) . Library: Centerville - Select 'Continue' - Add '123' to the PubMed ID list of identifiers - Click 'Process identifiers' - Once processed, click 'Add items to batch' - Click 'Finish and view batch' => You now have 1 request, 1 batch and a few ILL request attributes in the 'FreeForm' backend 8. Run updatedatabase again, notice that there are now extra messages from the previous database update - "Updated ILL batches from 'FreeForm' to 'Standard'...": DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [19:26:57]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: Updated ILL batches from 'FreeForm' to 'Standard Bug 35570: Updated ILL request attributes from 'FreeForm' to 'Standard Bug 35570: Updated ILL requests from 'FreeForm' to 'Standard Bug 35570: Finished database update. DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [19:26:57]: Bug 35681 - Test Atomic update output Something in red is a warning Somthing in yellow is a call to action Something in blue is for information only You could use 'WHITE' too? Or leave color off and stick to default 9. Create a saved SQL report with this SQL (note that if you run the report you get no results): Select * from illrequests where backend="FreeForm" 10. Run the updatedatabase again. Note that there is a warning about the report you created "Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing occurrences of 'FreeForm' were found.....": DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35570.pl [19:30:47]: Bug 35570 - Update 'FreeForm' ILL backend to 'Standard' Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing occurrences of 'FreeForm' were found. The following reports MUST be updated accordingly ('FreeForm' -> 'Standard'): Report ID: 1 | Edit link: http://kohadev-intra.koha-testing:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Edit%20SQL DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35681.pl [19:30:47]: Bug 35681 - Test Atomic update output Something in red is a warning Somthing in yellow is a call to action Something in blue is for information only You could use 'WHITE' too? Or leave color off and stick to default 11. Apply the remainder of the patches for this bug: - Say no for all the dependencies, as they are already installed - For 35570 (this bug) use i (for interactive) and add a # hash in front of the first three patches - There is no need to run the databaseupdate again - Run flush_memcached and restart_all (not sure if this is required, but is what I normally do after applying a patch) 12. Go to the ILL page: Administration > ILL requests 13. Notice that there is a configuration error preventing the use of the ILL module. The message displayed is "ILL module configuration problem. Take a look at the about page". 14. Click the 'about page' link and verify there is a warning about the FreeForm backend: The ILL module is enabled, but the deprecated 'FreeForm' backend is installed. 'FreeForm' has since become part of core Koha as 'Standard'. All 'FreeForm' ILL content should've been migrated to 'Standard' upon upgrading Koha to 24.05. To avoid confusion or redundancy, please uninstall the 'FreeForm' backend before using the ILL module. 15. Remove the FreeForm backend from /kohadevbox/koha/Koha/Illbackends (sudo rm -R /kohadevbox/koha/Koha/Illbackends/FreeForm) and refresh the page. 16. Repeat step 12. Note that: - The requests are listed as expected, and you can now use the ILL module again. - For '+ New ILL requests batch', 'Standard' is now the only option shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #24 from David Nind <david@davidnind.com> --- Additional testing ================== I created a new ILL request and tested the various options available on the ILL requests page (this wasn't part of the test plan): - Confirm request: page not found (404) error when confirming request (URL was /cgi-bin/koha/ill/%2Fcgi-bin%2Fkoha%2Fill%2Fill-requests.pl%3Fmethod%3Dconfirm%26stage%3Dconfirm%26illrequest_id%3D2) - presume something else is required to configure this? - All the other areas seemed to work as expected: . Edit request . Place request with partner libraries (add a couple of patrons to the Inter-Library Loan patron category, make sure they have an email address) . Delete request . Edit item metadata . Send notice to patron (I added an email to the patron used to create the request, updated patron message preferences, and added an email address to the various email system preferences) . Display supplier metadata (found this confusing - it shows the request metadata, but this is the existing terminology) . ILL request log (changes made to the request show after enabling the IllLog system preference) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160686&action=edit Bug 35570: (QA follow-up): Fix action button links. Use url filter instead of uri. Before applying this patch: 1) Click 'Manage Request' for a request, then on the top toolbar click 'Confirm request'. 2) Click the 'Confirm request' button on the bottom of the text. Notice it fails with a 404. Use the browser to go back. 3) Click the 'Cancel' button on the bottom of the text. Notice it fails with a 404. Use the browser to go back. 4) Set all the requests to status to 'REQ' (relevant for next test), ktd kshell, run: echo 'update illrequests set status = 'REQ';' | koha-mysql kohadev 5) Click 'Manage Request' for a request, then on the top toolbar click 'Revert request'. 6) Click the 'Revert request' button on the bottom of the text. Notice it fails with a 404. Use the browser to go back. 7) Click the 'Cancel' button on the bottom of the text. Notice it fails with a 404. Use the browser to go back. 8) Apply patch. Repeat test plan. Notice all the action buttons now work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Nind from comment #24)
Additional testing ==================
I created a new ILL request and tested the various options available on the ILL requests page (this wasn't part of the test plan):
- Confirm request: page not found (404) error when confirming request (URL was /cgi-bin/koha/ill/%2Fcgi-bin%2Fkoha%2Fill%2Fill-requests. pl%3Fmethod%3Dconfirm%26stage%3Dconfirm%26illrequest_id%3D2) - presume something else is required to configure this?
Hi David, nice catch. This was an oversight ('uri' instead of 'url') and an actual bug. I've submitted a patch. Thank you so much for your extensive testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #27 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #26)
Hi David, nice catch. This was an oversight ('uri' instead of 'url') and an actual bug. I've submitted a patch. Thank you so much for your extensive testing!
Thanks Pedro! Can confirm that this now works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could we do a cleanup here first? Seeing various (QA follow-up) without any further text. Does not look good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #28)
Could we do a cleanup here first? Seeing various (QA follow-up) without any further text. Does not look good.
Hi Marcel, thank you. I agree, I'll rewrite the commit messages to have proper titles and resubmit. There's a minor rebase needed as well. Having said that, here's an explanation of the 3 qa follow-up commits without further text on the title: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160658&action=diff First qa follow-up is required because it records all the QA work done on FreeForm after it has become Standard in Koha core. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160659&action=diff Second qa follow-up was an update on the work done in bug 35681 (I need to revisit this patch again) https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160660&action=diff Third qa follow-upn was a bugfix submitted to the FreeForm repo, but I'm also adding here to keep both in sync while this is not pushed to core. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160657|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160658|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160659|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160660|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161519&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161520&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161521&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #33 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161522&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161523&action=edit Bug 35570: (QA follow-up): Follow QA script on Standard backend Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161524&action=edit Bug 35570: (QA follow-up): Standard backend: Show appropriate error message when type is missing Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #36 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #28)
Could we do a cleanup here first? Seeing various (QA follow-up) without any further text. Does not look good.
Hi Marcel, I've improved the commit messages titles and squashed 2 QA follow-ups to their respective original commits. Kept 2 of the QA follow-up commits as they are important history. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22103 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com, | |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 [Bug 36197] Allow for OPAC unauthenticated ILL request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36197 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 [Bug 36197] Allow for OPAC unauthenticated ILL request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35604 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 [Bug 35604] ILL - Allow for automatic backend selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162894&action=edit Bug 35570: (QA follow-up): Standard backend: Bug 36243 compatibility Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/c34be16ba34c840193ed... into this work. This is to keep this work up to date with latest FreeForm's fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162897&action=edit Bug 35570: (QA follow-up): Standard backend: Fix OPAC CSRF Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/6a37ce0daba8aab13130... into this work. This is to keep this work up to date with latest FreeForm's fixes. The test plan to demonstrate the issue this patch fixes: Test plan, k-t-d: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm branch to the one compatible with this work, i.e.: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Restart plack: koha-plack --restart kohadev 4) Go to OPAC ILL requests, login and visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl 5) Click "Create new request" 6) Change the 'type'. Notice you get a 403 error. Logs say: Programming error - op 'add_form' must start with 'cud-' for POST 7) Apply patch. Restart plack. Repeat 6) 8) Notice the change type works as expected. Click "Create". 9) Notice the request is created as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161519|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162898&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161520|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162899&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161521|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162900&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161522|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162901&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161523|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162902&action=edit Bug 35570: (QA follow-up): Follow QA script on Standard backend Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161524|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162903&action=edit Bug 35570: (QA follow-up): Standard backend: Show appropriate error message when type is missing Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162894|0 |1 is obsolete| | --- Comment #45 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162904&action=edit Bug 35570: (QA follow-up): Standard backend: Bug 36243 compatibility Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/c34be16ba34c840193ed... into this work. This is to keep this work up to date with latest FreeForm's fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162897|0 |1 is obsolete| | --- Comment #46 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162905&action=edit Bug 35570: (QA follow-up): Standard backend: Fix OPAC CSRF Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/6a37ce0daba8aab13130... into this work. This is to keep this work up to date with latest FreeForm's fixes. The test plan to demonstrate the issue this patch fixes: Test plan, k-t-d: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm branch to the one compatible with this work, i.e.: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Restart plack: koha-plack --restart kohadev 4) Go to OPAC ILL requests, login and visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl 5) Click "Create new request" 6) Change the 'type'. Notice you get a 403 error. Logs say: Programming error - op 'add_form' must start with 'cud-' for POST 7) Apply patch. Restart plack. Repeat 6) 8) Notice the change type works as expected. Click "Create". 9) Notice the request is created as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162898|0 |1 is obsolete| | --- Comment #47 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164277&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162899|0 |1 is obsolete| | --- Comment #48 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164278&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162900|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164279&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162901|0 |1 is obsolete| | --- Comment #50 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164280&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162902|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164281&action=edit Bug 35570: (QA follow-up): Follow QA script on Standard backend Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162903|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164282&action=edit Bug 35570: (QA follow-up): Standard backend: Show appropriate error message when type is missing Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162904|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164283&action=edit Bug 35570: (QA follow-up): Standard backend: Bug 36243 compatibility Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/c34be16ba34c840193ed... into this work. This is to keep this work up to date with latest FreeForm's fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162905|0 |1 is obsolete| | --- Comment #54 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164284&action=edit Bug 35570: (QA follow-up): Standard backend: Fix OPAC CSRF Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/6a37ce0daba8aab13130... into this work. This is to keep this work up to date with latest FreeForm's fixes. The test plan to demonstrate the issue this patch fixes: Test plan, k-t-d: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm branch to the one compatible with this work, i.e.: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Restart plack: koha-plack --restart kohadev 4) Go to OPAC ILL requests, login and visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl 5) Click "Create new request" 6) Change the 'type'. Notice you get a 403 error. Logs say: Programming error - op 'add_form' must start with 'cud-' for POST 7) Apply patch. Restart plack. Repeat 6) 8) Notice the change type works as expected. Click "Create". 9) Notice the request is created as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #55 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased after recent changes to bug 19605 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164277|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165204&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164278|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165205&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164279|0 |1 is obsolete| | --- Comment #58 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165206&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164280|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165207&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164281|0 |1 is obsolete| | --- Comment #60 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165208&action=edit Bug 35570: (QA follow-up): Follow QA script on Standard backend Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164282|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165209&action=edit Bug 35570: (QA follow-up): Standard backend: Show appropriate error message when type is missing Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164283|0 |1 is obsolete| | --- Comment #62 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165210&action=edit Bug 35570: (QA follow-up): Standard backend: Bug 36243 compatibility Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/c34be16ba34c840193ed... into this work. This is to keep this work up to date with latest FreeForm's fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164284|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165211&action=edit Bug 35570: (QA follow-up): Standard backend: Fix OPAC CSRF Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/6a37ce0daba8aab13130... into this work. This is to keep this work up to date with latest FreeForm's fixes. The test plan to demonstrate the issue this patch fixes: Test plan, k-t-d: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm branch to the one compatible with this work, i.e.: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Restart plack: koha-plack --restart kohadev 4) Go to OPAC ILL requests, login and visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl 5) Click "Create new request" 6) Change the 'type'. Notice you get a 403 error. Logs say: Programming error - op 'add_form' must start with 'cud-' for POST 7) Apply patch. Restart plack. Repeat 6) 8) Notice the change type works as expected. Click "Create". 9) Notice the request is created as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #64 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebase after a follow-up submitted to bug 19605 was required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165204|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165286&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165205|0 |1 is obsolete| | --- Comment #66 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165287&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165206|0 |1 is obsolete| | --- Comment #67 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165288&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165207|0 |1 is obsolete| | --- Comment #68 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165289&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165208|0 |1 is obsolete| | --- Comment #69 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165290&action=edit Bug 35570: (QA follow-up): Follow QA script on Standard backend Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165209|0 |1 is obsolete| | --- Comment #70 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165291&action=edit Bug 35570: (QA follow-up): Standard backend: Show appropriate error message when type is missing Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165210|0 |1 is obsolete| | --- Comment #71 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165292&action=edit Bug 35570: (QA follow-up): Standard backend: Bug 36243 compatibility Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/c34be16ba34c840193ed... into this work. This is to keep this work up to date with latest FreeForm's fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165211|0 |1 is obsolete| | --- Comment #72 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165293&action=edit Bug 35570: (QA follow-up): Standard backend: Fix OPAC CSRF Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/6a37ce0daba8aab13130... into this work. This is to keep this work up to date with latest FreeForm's fixes. The test plan to demonstrate the issue this patch fixes: Test plan, k-t-d: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm branch to the one compatible with this work, i.e.: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Restart plack: koha-plack --restart kohadev 4) Go to OPAC ILL requests, login and visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl 5) Click "Create new request" 6) Change the 'type'. Notice you get a 403 error. Logs say: Programming error - op 'add_form' must start with 'cud-' for POST 7) Apply patch. Restart plack. Repeat 6) 8) Notice the change type works as expected. Click "Create". 9) Notice the request is created as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #73 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased required after bug 35151 and bug 32693pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #74 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- The patchset includes the following string: All 'FreeForm' ILL content should've been migrated to 'Standard' upon upgrading Koha to 24.05. This needs to be revisited/update if not pushed in time for 24.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #75 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167050&action=edit Bug 35570: (QA follow-up): Rebase on final state of bug 35681 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167050|0 |1 is obsolete| | --- Comment #76 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167051&action=edit Bug 35570: (QA follow-up): Rebase on final state of bug 35681 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Bug 35570 depends on bug 35581, which changed state. Bug 35581 Summary: ILL Koha classes are not consistent https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Bug 35570 depends on bug 35681, which changed state. Bug 35681 Summary: Add support for colored messages in the output of updatedatabase https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Status|Signed Off |Patch doesn't apply --- Comment #77 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi Pedro, just wanted to QA Bug 35725 but this one doesn't apply anymore unfortunately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #78 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Huh, this one was already pushed to main? Sorry for the noise then. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #79 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Paul Derscheid from comment #78)
Huh, this one was already pushed to main? Sorry for the noise then.
No, this has not yet been pushed to main. I'm putting this back to 'Patch doesn't apply' to look back at tomorrow. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165286|0 |1 is obsolete| | --- Comment #80 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171312&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165287|0 |1 is obsolete| | --- Comment #81 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171313&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165288|0 |1 is obsolete| | --- Comment #82 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171314&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171312|0 |1 is obsolete| | --- Comment #83 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171315&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171313|0 |1 is obsolete| | --- Comment #84 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171316&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171314|0 |1 is obsolete| | --- Comment #85 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171317&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165289|0 |1 is obsolete| | --- Comment #86 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171318&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165290|0 |1 is obsolete| | --- Comment #87 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171319&action=edit Bug 35570: (QA follow-up): Follow QA script on Standard backend Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165291|0 |1 is obsolete| | --- Comment #88 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171320&action=edit Bug 35570: (QA follow-up): Standard backend: Show appropriate error message when type is missing Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165292|0 |1 is obsolete| | --- Comment #89 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171321&action=edit Bug 35570: (QA follow-up): Standard backend: Bug 36243 compatibility Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/c34be16ba34c840193ed... into this work. This is to keep this work up to date with latest FreeForm's fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165293|0 |1 is obsolete| | --- Comment #90 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171322&action=edit Bug 35570: (QA follow-up): Standard backend: Fix OPAC CSRF Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/6a37ce0daba8aab13130... into this work. This is to keep this work up to date with latest FreeForm's fixes. The test plan to demonstrate the issue this patch fixes: Test plan, k-t-d: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm branch to the one compatible with this work, i.e.: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Restart plack: koha-plack --restart kohadev 4) Go to OPAC ILL requests, login and visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl 5) Click "Create new request" 6) Change the 'type'. Notice you get a 403 error. Logs say: Programming error - op 'add_form' must start with 'cud-' for POST 7) Apply patch. Restart plack. Repeat 6) 8) Notice the change type works as expected. Click "Create". 9) Notice the request is created as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167051|0 |1 is obsolete| | --- Comment #91 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171323&action=edit Bug 35570: (QA follow-up): Rebase on final state of bug 35681 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sonia.bouis@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #92 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172218&action=edit Bug 35570: (QA Follow-up: Standard backend: Biblio creation: Add UNIMARC support Add FreeForm UNIMARC enhancement from https://github.com/PTFS-Europe/koha-ill-freeform/commit/5d07c68f8058a9a1f35e... into this work. This is to keep this work up to date with latest FreeForm's work. To test, k-t-d: 1) (Skip if using sandboxes) Start off by ensuring this is a UNIMARC installation, run: $ reset_all_unimarc 2) (Skip if using sandboxes) Apply this bug 35570 3) Create a new Standard ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) Select type: book, input different values for title+author+isbn (the remaining fields are optional for this test) 5) Put in a cardnumber ('42' is kohaadmin if k-t-d/sandboxes). Select any library. Click 'Create'. 6) You should now see the ILL request details page. Click on the 'Bibliographic record ID' link. 7) Ensure the newly created biblio record has the title+author+isbn from the metadata originally submitted. Raised by Sonia Bouis at KohaCon's 2024 ILL workshop -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172218|0 |1 is obsolete| | --- Comment #93 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172219&action=edit Bug 35570: (QA follow-up): Standard backend: Biblio creation: Add UNIMARC support Add FreeForm UNIMARC enhancement from https://github.com/PTFS-Europe/koha-ill-freeform/commit/5d07c68f8058a9a1f35e... into this work. This is to keep this work up to date with latest FreeForm's work. To test, k-t-d: 1) (Skip if using sandboxes) Start off by ensuring this is a UNIMARC installation, run: $ reset_all_unimarc 2) (Skip if using sandboxes) Apply this bug 35570 3) Create a new Standard ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) Select type: book, input different values for title+author+isbn (the remaining fields are optional for this test) 5) Put in a cardnumber ('42' is kohaadmin if k-t-d/sandboxes). Select any library. Click 'Create'. 6) You should now see the ILL request details page. Click on the 'Bibliographic record ID' link. 7) Ensure the newly created biblio record has the title+author+isbn from the metadata originally submitted. Raised by Sonia Bouis at KohaCon's 2024 ILL workshop -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171315|0 |1 is obsolete| | Attachment #171316|0 |1 is obsolete| | Attachment #171317|0 |1 is obsolete| | Attachment #171318|0 |1 is obsolete| | Attachment #171319|0 |1 is obsolete| | Attachment #171320|0 |1 is obsolete| | Attachment #171321|0 |1 is obsolete| | Attachment #171322|0 |1 is obsolete| | Attachment #171323|0 |1 is obsolete| | Attachment #172219|0 |1 is obsolete| | --- Comment #94 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172722&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #95 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172723&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #96 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172724&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #97 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172725&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #98 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172726&action=edit Bug 35570: (QA follow-up): Follow QA script on Standard backend Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #99 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172727&action=edit Bug 35570: (QA follow-up): Standard backend: Show appropriate error message when type is missing Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #100 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172728&action=edit Bug 35570: (QA follow-up): Standard backend: Bug 36243 compatibility Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/c34be16ba34c840193ed... into this work. This is to keep this work up to date with latest FreeForm's fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #101 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172729&action=edit Bug 35570: (QA follow-up): Standard backend: Fix OPAC CSRF Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/6a37ce0daba8aab13130... into this work. This is to keep this work up to date with latest FreeForm's fixes. The test plan to demonstrate the issue this patch fixes: Test plan, k-t-d: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm branch to the one compatible with this work, i.e.: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Restart plack: koha-plack --restart kohadev 4) Go to OPAC ILL requests, login and visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl 5) Click "Create new request" 6) Change the 'type'. Notice you get a 403 error. Logs say: Programming error - op 'add_form' must start with 'cud-' for POST 7) Apply patch. Restart plack. Repeat 6) 8) Notice the change type works as expected. Click "Create". 9) Notice the request is created as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #102 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172730&action=edit Bug 35570: (QA follow-up): Rebase on final state of bug 35681 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #103 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172731&action=edit Bug 35570: (QA follow-up): Standard backend: Biblio creation: Add UNIMARC support Add FreeForm UNIMARC enhancement from https://github.com/PTFS-Europe/koha-ill-freeform/commit/5d07c68f8058a9a1f35e... into this work. This is to keep this work up to date with latest FreeForm's work. To test, k-t-d: 1) (Skip if using sandboxes) Start off by ensuring this is a UNIMARC installation, run: $ reset_all_unimarc 2) (Skip if using sandboxes) Apply this bug 35570 3) Create a new Standard ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) Select type: book, input different values for title+author+isbn (the remaining fields are optional for this test) 5) Put in a cardnumber ('42' is kohaadmin if k-t-d/sandboxes). Select any library. Click 'Create'. 6) You should now see the ILL request details page. Click on the 'Bibliographic record ID' link. 7) Ensure the newly created biblio record has the title+author+isbn from the metadata originally submitted. Raised by Sonia Bouis at KohaCon's 2024 ILL workshop -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #104 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172732&action=edit Bug 35570: (QA follow-up) Tidy Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #105 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172733&action=edit Bug 35570: Make strings in Standard.pm translatable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #106 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172734&action=edit Bug 35570: Use ->extended_attributes() Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #107 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172735&action=edit Bug 35570: Do not unbless iterator Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #108 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi, nice job :-D The only 'failure' I found is that choosing DVD when using the form makes it blow. I couldn't find the `dvd.inc` file in the original backend repo so I leave it to you. Some remarks: * Some of the code might fit somewhere else. For example the code for creating the record, that has those mappings for ISBNs, etc. BUT that's for another day and another project. * I'm not sure how we're gonna make those templates translatable. For the backends I worked with, this was the backend's implementation business, but being core we need to find a solution. Please provide the dvd.inc and mark as PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #109 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- It also feels a bit out of place to see the 'New request' and 'List requests' buttons when editing the request. But might be out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #110 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #108)
Please provide the dvd.inc and mark as PQA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197#c4 I'll provide the fix asap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172722|0 |1 is obsolete| | Attachment #172723|0 |1 is obsolete| | Attachment #172724|0 |1 is obsolete| | Attachment #172725|0 |1 is obsolete| | Attachment #172726|0 |1 is obsolete| | Attachment #172727|0 |1 is obsolete| | Attachment #172728|0 |1 is obsolete| | Attachment #172729|0 |1 is obsolete| | Attachment #172730|0 |1 is obsolete| | Attachment #172731|0 |1 is obsolete| | Attachment #172732|0 |1 is obsolete| | Attachment #172733|0 |1 is obsolete| | Attachment #172734|0 |1 is obsolete| | Attachment #172735|0 |1 is obsolete| | --- Comment #111 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172740&action=edit Bug 35570: Put 'FreeForm' backend into core as 'Standard' FreeForm copied as is from HEAD 369dffb159f1e70162b685b473dcf26c76f7e7e7 At https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ Only edits made were 'freeform' -> 'standard' in the markup of the .inc files and some occurrences of FreeForm in Standard.pm (previous Base.pm) file. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #112 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172741&action=edit Bug 35570: Consider 'Standard' core backend Added File::Basename qw( dirname ) Sorted Koha:: dependencies alphabetically DRYed load_backend a bit and included 'Standard' backend check Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #113 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172742&action=edit Bug 35570: Atomicupdate Move stuff out of 'FreeForm' into 'Standard' This atomicupdate will printout the changes it made, if any. It will also print out the report IDs of reports that may contain occurrences of 'FreeForm'. This is to give the sys admin the chance to fix those reports before users. To test, empty k-t-d: 1) Run updatedatabase, notice nothing happens 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new 'FreeForm' ILL batch (requires a metadata enrichment plugin like https://github.com/PTFS-Europe/koha-plugin-api-pubmed) 4) Add '123' to the pubmedid list of identifiers and finish creating the batch 5) Upon creating the batch, you will now have 1 request, 1 batch and a few illrequestattributes in the 'FreeForm' backend 6) Run the updatedatabase again, notice the print outs. 7) Create a saved sql report like: 'Select * from illrequests where backend="FreeForm";' 8) Run the updatedatabase again, notice you get a warning for the above report Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #114 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172743&action=edit Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed Test plan: 1) This patch should not be applied in order to be able to go through the previous patch's test plan 2) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Please note that you need to be using FreeForm's reorganize_ILL branch at: https://github.com/PTFS-Europe/koha-ill-freeform/commits/reorganize_ILL/ 4) Visit ILL page: /cgi-bin/koha/ill/ill-requests.pl 5) Notice there's a configuration error preventing the use of the ILL module. 6) Click the 'about page' link and verify there is a warning about FreeForm 7) Remove FreeForm from /kohadevbox/koha/Koha/Illbackends and refresh the page 8) Repeat 4), notice the requests are listed as expected and you can now use the ILL module again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #115 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172744&action=edit Bug 35570: (QA follow-up): Follow QA script on Standard backend Make QA script green, fix: - Variables declared in condition - Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) - missing_filter - forbidden pattern: Do not use line breaks inside template tags (bug 18675) - Attribute type should not be used for script tags (bug 20053) - File must have the exec flag - forbidden pattern: trailing space char - valid_template: /shared-includes/custom_fields.inc: not found Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #116 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172745&action=edit Bug 35570: (QA follow-up): Standard backend: Show appropriate error message when type is missing Add FreeForm fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/9c9da5ff2815fb6ce0af... into this work. This is to keep this work up to date with latest FreeForm's fixes. See bug 35685 for context and test plan. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #117 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172746&action=edit Bug 35570: (QA follow-up): Standard backend: Bug 36243 compatibility Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/c34be16ba34c840193ed... into this work. This is to keep this work up to date with latest FreeForm's fixes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #118 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172747&action=edit Bug 35570: (QA follow-up): Standard backend: Fix OPAC CSRF Add FreeForm CSRF fix from https://github.com/PTFS-Europe/koha-ill-freeform/commit/6a37ce0daba8aab13130... into this work. This is to keep this work up to date with latest FreeForm's fixes. The test plan to demonstrate the issue this patch fixes: Test plan, k-t-d: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm branch to the one compatible with this work, i.e.: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 3) Restart plack: koha-plack --restart kohadev 4) Go to OPAC ILL requests, login and visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl 5) Click "Create new request" 6) Change the 'type'. Notice you get a 403 error. Logs say: Programming error - op 'add_form' must start with 'cud-' for POST 7) Apply patch. Restart plack. Repeat 6) 8) Notice the change type works as expected. Click "Create". 9) Notice the request is created as expected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #119 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172748&action=edit Bug 35570: (QA follow-up): Rebase on final state of bug 35681 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #120 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172749&action=edit Bug 35570: (QA follow-up): Standard backend: Biblio creation: Add UNIMARC support Add FreeForm UNIMARC enhancement from https://github.com/PTFS-Europe/koha-ill-freeform/commit/5d07c68f8058a9a1f35e... into this work. This is to keep this work up to date with latest FreeForm's work. To test, k-t-d: 1) (Skip if using sandboxes) Start off by ensuring this is a UNIMARC installation, run: $ reset_all_unimarc 2) (Skip if using sandboxes) Apply this bug 35570 3) Create a new Standard ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) Select type: book, input different values for title+author+isbn (the remaining fields are optional for this test) 5) Put in a cardnumber ('42' is kohaadmin if k-t-d/sandboxes). Select any library. Click 'Create'. 6) You should now see the ILL request details page. Click on the 'Bibliographic record ID' link. 7) Ensure the newly created biblio record has the title+author+isbn from the metadata originally submitted. Raised by Sonia Bouis at KohaCon's 2024 ILL workshop Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #121 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172750&action=edit Bug 35570: (QA follow-up) Tidy Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #122 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172751&action=edit Bug 35570: Make strings in Standard.pm translatable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #123 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172752&action=edit Bug 35570: Use ->extended_attributes() Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #124 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172753&action=edit Bug 35570: Do not unbless iterator Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #125 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- (In reply to Pedro Amorim from comment #92)
Created attachment 172218 [details] [review] Bug 35570: (QA Follow-up: Standard backend: Biblio creation: Add UNIMARC support
Hi, Thanks Pedro for this addition! I've just tested this part. The actions from the test plan are OK but, I wonder if we should not put the author in the field 200$f instead of 700$a because 700$a is only for the surname, while you can put different elements of the name in 200$f. I have also tried to create a book ILL request from the OPAC and then, only the title was added in the biblio record (no author nor isbn). Strange thing, the request id from the one created from the OPAC had an prefix ILL- and not the one created from the staff. Last thought, in addition of book, the request for DVD or Thesis should also create biblio records as it's often physical documents. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #126 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172780&action=edit Bug 35570: Revert some strings translatability This patch reverts making core field descriptions translatable. It was an obvious move and a needed one. But it turns out our core templates are using those keys ('Author' and 'Title' in particular) and as such translating them would break display (at least in the OPAC). Without this patch, the ILL requests table in the OPAC doesn't display the title and author columns values (i.e. displays 'N/A' instead) Added a FIXME in the code, and will file a bug soo we fix this properly. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #127 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thank you Sonia for your testing, please read my replies below: (In reply to Sonia Bouis from comment #125)
The actions from the test plan are OK but, I wonder if we should not put the author in the field 200$f instead of 700$a because 700$a is only for the surname, while you can put different elements of the name in 200$f.
Fair point, I'll provide a follow-up correcting this. Thank you. (In reply to Sonia Bouis from comment #125)
I have also tried to create a book ILL request from the OPAC and then, only the title was added in the biblio record (no author nor isbn).
From step 4), if you click "Edit -> Edit record", you'll be shown the "Fast Add Framework". This framework does not have fields 010 and 700, so they're effectively stripped. If you then change to default, these fields don't carry over, because they've been effectivelly stripped by the "Fast Add Framework". To prove my point, access the edit biblio page using the Default frameworkcode
Not able to reproduce this. Running on an UNIMARC database: 1) Create a new OPAC ILL request: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 2) Pick Type:Book. Put a title, author and isbn, cardnumber + library. Click 'Create'. 3) On the detail screen. Click on the 'Bibliographic record ID'. 4) On the biblio detail page, confirm there's an entry for author and ISBN. 5) Click "Marc preview:Show". Confirm the MARC data is as expected. What I think you may be experiencing (on k-t-d/sandboxes): directly from the URL, like below (update staff_url and change '21651' to your test biblionumber): <staff_url>/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=21651&frameworkcode=Default You'll notice that in this view, all MARC data is shown, including ISBN+Author.
From here, if you switch to "Fast Add Framework" and then go back to "Default", you'll notice those fields are gone again. I believe this has always been the case in Koha since I can remember, but I may be wrong. Please let me know if this makes sense and describes what you're experiencing. I've done this exercise creating an ILL request from either Staff or OPAC, it's no different from my testing.
(In reply to Sonia Bouis from comment #125)
Strange thing, the request id from the one created from the OPAC had an prefix ILL- and not the one created from the staff.
This is because there's a <prefix> configured in koha-conf.xml for 'CPL' (Centerville library on stock k-t-d database). This 'ILL-' prefix will happen for any ILL request created for Centerville, regardless if created in the OPAC or Staff. Only Centerville has this configured, so any other library will not have a prefix. I believe this is working as designed. (In reply to Sonia Bouis from comment #125)
Last thought, in addition of book, the request for DVD or Thesis should also create biblio records as it's often physical documents.
My suggestion is that we file this as a follow-up bug, if you agree. This is additional functionality and in my opinion goes beyond the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #128 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172809&action=edit Bug 35570: (QA follow-up): Fix DVD type I've added some DVD specific fields: language, format, genre, studio. Happy to have this discussed and/or updated but hoping this is good enough for now. To test: 1) Create an ILL request of 'DVD' type on both OPAC and Staff 2) Verify the form is shown without issues 3) Fill all fields and verify all fields are stored and shown correctly on both OPAC and STaff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #129 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #108)
Please provide the dvd.inc and mark as PQA
Done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #130 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172811&action=edit Bug 35570: (QA follow-up): Update UNIMARC author to 200$f Reworked the logic here a bit to ensure the following scenario for UNIMARC: If both title and author exist, the result is: 200$aTitle$fAuthor In the previous logic, it would become: 200$aTitle 200$fAuthor I'm assuming the desired result is the former and not the latter. Test following the same test plan, but try having only author, or only title, and verify that the resulted MARC data is as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #131 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Pedro Amorim from comment #127)
Thank you Sonia for your testing, please read my replies below:
(In reply to Sonia Bouis from comment #125)
The actions from the test plan are OK but, I wonder if we should not put the author in the field 200$f instead of 700$a because 700$a is only for the surname, while you can put different elements of the name in 200$f.
Fair point, I'll provide a follow-up correcting this. Thank you.
Hi Sonia, I've now provided a patch that adds the author field information to 200$f instead of 700$a for UNIMARC. Please test when you're available. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38276 [Bug 38276] ILL Standard form does not consider DOI in openURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #132 from Mathieu Saby <mathsabypro@gmail.com> --- Hello I wanted to ask why DVD or Thesis requests did not create biblio records, but I see Sonia has already made this remark... It believe it could be a nice improvement after this patch is pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #133 from Mathieu Saby <mathsabypro@gmail.com> --- Pedro, if you use 200$f for the author in UNIMARC, would not it make sense to use 245$c in MARC21 (instead of 700$a), as this field have the same meaning? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #134 from Mathieu Saby <mathsabypro@gmail.com> --- I tested on a UNIMARC sandbox. Everything is fine in the record (010$a, 200$a, 200$f are created as expected) But we should not have a 942$n field. It is not a defined in UNIMARC Koha standard framework. However the proper handling of this information in UNIMARC is problematic in UNIMARC (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37600). So I suppose we can fix the code for ILL form for UNIMARC once a solution is pushed for bug 37600 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #135 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Mathieu Saby from comment #132)
Hello I wanted to ask why DVD or Thesis requests did not create biblio records, but I see Sonia has already made this remark... It believe it could be a nice improvement after this patch is pushed.
Hi Mathieu, thank you for testing and adding to the discussion! I'm fully on board with this and surely others are too. I'd prefer to keep the scope of this bug limited to just adding FreeForm into core Koha, even though we've added some enhancements here, I think it'd be better to add have any other additional enhancements to follow-up bugs instead. (In reply to Mathieu Saby from comment #133)
Pedro, if you use 200$f for the author in UNIMARC, would not it make sense to use 245$c in MARC21 (instead of 700$a), as this field have the same meaning?
A very good question. When I added the UNIMARC support for biblio creation, it did not cross my mind to review the MARC21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #136 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Mathieu Saby from comment #132)
Hello I wanted to ask why DVD or Thesis requests did not create biblio records, but I see Sonia has already made this remark... It believe it could be a nice improvement after this patch is pushed.
Hi Mathieu, thank you for testing and adding to the discussion! I'm fully on board with this and surely others are too. I'd prefer to keep the scope of this bug limited to just adding FreeForm into core Koha, even though we've added some enhancements here, I think it'd be better to add have any other additional enhancements to follow-up bugs instead. (In reply to Mathieu Saby from comment #133)
Pedro, if you use 200$f for the author in UNIMARC, would not it make sense to use 245$c in MARC21 (instead of 700$a), as this field have the same meaning?
A very good question. When I added the UNIMARC support for biblio creation, it did not cross my mind to review the MARC21 mapping. As above, something to discuss on a follow-up bug imo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38288 [Bug 38288] Provide openURL backwards compatibility with FreeForm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38289 [Bug 38289] ILL module should create biblios for DVD and Thesis documents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #137 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- Hi Pedro, Just to let you know that I've tested again the unimarc biblio creation and that it's ok (perhaps the change made by Tomas in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570#c126 resolved the problem of author and isbn in biblio created in the OPAC). Just wondering, is the status really passed QA? I don't see QA analysis on this. Thank you again for this job. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #138 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Sonia Bouis from comment #137)
Just wondering, is the status really passed QA? I don't see QA analysis on this.
Thank you again for this job. Sonia
(In reply to Pedro Amorim from comment #129)
(In reply to Tomás Cohen Arazi (tcohen) from comment #108)
Please provide the dvd.inc and mark as PQA
Done.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #139 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still applies, continueing work here tomorrow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #140 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please check: FAIL Koha/ILL/Backend/Standard.pm FAIL critic "$marc_isbn" is declared but not used at line 1179, column 5. Unused variables clutter code and make it harder to read. "$marc_author" is declared but not used at line 1180, column 5. Unused variables clutter code and make it harder to read. "$marc_title" is declared but not used at line 1181, column 5. Unused variables clutter code and make it harder to read. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #141 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some issues here that will require follow-ups: 1) Translatability a) Using __() in a .pm (nothing to do here) I am glad I double checked these, because I thought they would not work, but they do get parsed into the po files. Koha/ILL/Backend/Standard.pm + name => __('Switched provider'), + ui_method_name => __('Switch provider'), b) But this... hm: + # FIXME: This should all be made translatable as is basically a + # code => description mapping. The metadata() sub is using this + # descriptions as keys. I thought this was a bug on this backend + # but it turns out opac-illrequests.tt is using those descriptions + # as keys. for example: c) JS (definitely needs fixing): + '</span>Delete</button></li>'; 2) Unused variables (to fix, see QA script complaint): + my $marc_isbn; + my $marc_author; + my $marc_title; 3) Terminology (please fix) +<p><em>Please Note:</em> Branch is a mandatory field.</p> +[% ELSIF whole.status == 'invalid_borrower' %] +<p><em>Please Note:</em> The borrower details you entered are invalid.</p> +[% ELSIF whole.status == 'invalid_branch' %] +<p><em>Please Note:</em> The branch you chose is invalid.</p> +[% ELSE %] This repeats in several files, where the field itself has already been renamed to "Destination library". branch => library + <label class="required" for="brw">Borrower</label> Borrower => Patron 4) Database update (fixed) a) No need to repeat the bug number for each message, it will be at the beginning of the paragraph. + "Bug 35570: Updated ILL request attributes from 'FreeForm' to 'Standard'" I removed these when moving the database update to dbrevs. b) Can you explain this one? The English strings make me a little suspicious (question) + my $reports = join( + "\n", + map( "\tReport ID: " + . $_->id + . ' | Edit link: ' + . C4::Context->preference('staffClientBaseURL') + . '/cgi-bin/koha/reports/guided_reports.pl?reports=' + . $_->id + . "&phase=Edit%20SQL", + Koha::Reports->search( { savedsql => { -like => "%FreeForm%" } } )->as_list ) + ); 5) Wrong version (fixed) + <p>All 'FreeForm' ILL content should've been migrated to 'Standard' upon upgrading Koha to 24.05.</p> Changed to 24.11 in follow-up. 6) Unit tests (separate bug?) There are no unit tests, but it feels like there should be some... Maybe for a separate bug at this point. 7) Styling (separate bug) Some of the pages and elements in the forms have unusual styling. For example we are missing the "yellow" buttons for the main actions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_05, | |roadmap_24_11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #142 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate, | |roadmap_24_05 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 [Bug 38339] Standard backend _get_core_fields are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38340 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 [Bug 38340] Translatability - Standard form include files are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38341 [Bug 38341] Standard backend is missing unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #143 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173916&action=edit Bug 35570: (QA follow-up): Fix styling of confirmation buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #144 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173917&action=edit Bug 35570: (QA follow-up): Fix terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #145 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173918&action=edit Bug 35570: (QA follow-up): Fix translatability of 'Delete' This is also fixing the delete->trash icon and spacing between label+icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #146 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi Katrin, thank you very much for your work here and apologies not replying sooner: 1.a) Non-issue 1.b) Opened bug 38339 for this. 1.c) Patch submitted. Additional translatability work filed for bug 38340. 2) Non-issue, fixed upstream by commit 217b004. Thanks! 3) Patch submitted. 4.a) Thanks! 4.b) Yes, this produces the following warning if a report is found containing the word 'FreeForm'. This is to help administrators to update their reports reporting on FreeForm: Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing occurrences of 'FreeForm' were found. The following reports MUST be updated accordingly ('FreeForm' -> 'Standard'): Report ID: 1 | Edit link: http://kohadev-intra.myDNSname.org:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Edit%20SQL I did not consider translatability here (sorry!). I'm not entirely sure how to do it here, or if worth the investment. Let me know! 5) Fixed upstream. Thanks! 6) Yes, bug 38341 7) Patch submitted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This incorporates the ILL release notes| |backend previously known as | |"FreeForm" | |(https://github.com/PTFS-Eu | |rope/koha-ill-freeform) | |into core Koha, now labeled | |as "Standard". | |This allows | |the ILL module to be used | |as soon as the ILLModule | |system preference is | |enabled, without the need | |to install additional | |third-party backends, | |although the option to do | |so still exists. | |Upon | |upgrading, all prior | |"FreeForm" ILL requests, | |attributes, and comments | |will be transferred to the | |new "Standard" backend. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 --- Comment #147 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry Pedro, this one escaped me and I missed your great follow-ups. I'll try to merge the work on bug 36221 and here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 [Bug 39175] Send request to partners explodes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38339 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 [Bug 38339] Standard backend _get_core_fields are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38340 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 [Bug 38340] Translatability - Standard form include files are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40957 [Bug 40957] No need to maintain autocomplete compatibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1199 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #148 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Koha Manual updated (a few more tweaks to follow in the next few weeks). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org