[Bug 15550] New: Authority type pull down in OPAC authority search is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Bug ID: 15550 Summary: Authority type pull down in OPAC authority search is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org In the authority search form in the OPAC the pull down for choosing the authority type appears empty. Maybe similar to the bug report for the staff authority search? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Search dies with Can't call method "authtypetext" on an undefined value at /home/katrin/kohaclone/opac/opac-authorities-home.pl line 155. Updating severity a bit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15381 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46516&action=edit Bug 15550: Fix authority search and detail at the OPAC The author of Bug 15381 (me!) has mismatch the objects he was manipulating and forgotten to update a template. for the opac-aythorities-home, the variable is named authority_types, not authtypesloop. In opac-authoritiesdetail.pl, the $record is a MARC::Record and there is no authtypecode method. We need to retrieve the authtypecode using the new Koha::Authorities module. Test plan: Search for authorities at the OPAC and click on the detail link to go to the detail page. Without this patch, you will get errors. With this patch, the errors should have gone and everything should work as before bug 15381. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46516|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 46561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46561&action=edit [SIGNED-OFF]Bug 15550: Fix authority search and detail at the OPAC The author of Bug 15381 (me!) has mismatch the objects he was manipulating and forgotten to update a template. for the opac-aythorities-home, the variable is named authority_types, not authtypesloop. In opac-authoritiesdetail.pl, the $record is a MARC::Record and there is no authtypecode method. We need to retrieve the authtypecode using the new Koha::Authorities module. Test plan: Search for authorities at the OPAC and click on the detail link to go to the detail page. Without this patch, you will get errors. With this patch, the errors should have gone and everything should work as before bug 15381. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Pull down for choosing the auth_type displayed again detail fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46561|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46714&action=edit Bug 15550: Fix authority search and detail at the OPAC The author of Bug 15381 (me!) has mismatch the objects he was manipulating and forgotten to update a template. for the opac-aythorities-home, the variable is named authority_types, not authtypesloop. In opac-authoritiesdetail.pl, the $record is a MARC::Record and there is no authtypecode method. We need to retrieve the authtypecode using the new Koha::Authorities module. Test plan: Search for authorities at the OPAC and click on the detail link to go to the detail page. Without this patch, you will get errors. With this patch, the errors should have gone and everything should work as before bug 15381. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Pull down for choosing the auth_type displayed again Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 15575 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org