https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26762 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112094&action=edit Bug 26762: Modify template logic in opac-reserves.tt to avoid error This patch makes a change to the OPAC hold template to prevent certain cases where the output is invalid. To reproduce, perform a search in the OPAC which will return some titles which can be placed on hold and some which cannot. - Select all results (some holdable, some not) - Click the "Place hold" link - On the "Confirm holds" page the layout will be broken after the first instance of the message "There are no items that can be placed on hold." To test, apply the patch and repeat the process above. After the patch has been applied the "confirm holds" page should look correct. Validating the HTML source should return no errors. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112094|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 112392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112392&action=edit Bug 26762: Modify template logic in opac-reserves.tt to avoid error This patch makes a change to the OPAC hold template to prevent certain cases where the output is invalid. To reproduce, perform a search in the OPAC which will return some titles which can be placed on hold and some which cannot. - Select all results (some holdable, some not) - Click the "Place hold" link - On the "Confirm holds" page the layout will be broken after the first instance of the message "There are no items that can be placed on hold." To test, apply the patch and repeat the process above. After the patch has been applied the "confirm holds" page should look correct. Validating the HTML source should return no errors. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112392|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112439&action=edit Bug 26762: Modify template logic in opac-reserves.tt to avoid error This patch makes a change to the OPAC hold template to prevent certain cases where the output is invalid. To reproduce, perform a search in the OPAC which will return some titles which can be placed on hold and some which cannot. - Select all results (some holdable, some not) - Click the "Place hold" link - On the "Confirm holds" page the layout will be broken after the first instance of the message "There are no items that can be placed on hold." To test, apply the patch and repeat the process above. After the patch has been applied the "confirm holds" page should look correct. Validating the HTML source should return no errors. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26762 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26762 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.