[Bug 41976] New: [Vue] LinkWrapper.vue isn't scoped properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Bug ID: 41976 Summary: [Vue] LinkWrapper.vue isn't scoped properly Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jake.deery@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When using LinkWrapper in a context that is prone towards reuse, you can end up with one link modifying another. For example, when used in a relationshipWidget, you can end up with search parameters being appended to search parameters being appended to search parameters, etc. We think the solution to copy the props to a reference, and make any alterations to said reference. If this works, we will post a patch shortly. Ta, Jake -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 [Bug 14962] Temp Shelving Location / On Display Module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@openfifth.co.uk |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 194382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194382&action=edit Bug 41976: LinkWrapper no longer mangles links This patch fixes a bug where, context-dependent, LinkWrapper can keep referencing back to links that should be out of scope. This was causing odd behaviour whilst writing Bug 14962 - namely, links returning as the same value in a table of multiple rows due to LinkWrapper treating linkData.href as one and the same for each row. TO TEST: == APPLY PATCH == a) enable ERMModule syspref, go to /cgi-bin/koha/erm/erm.pl b) notice all links and buttons still work as expected c) go to /cgi-bin/koha/sip2/sip2.pl d) notice all links and buttons still work as expected e) go to /cgi-bin/koha/acquisition/vendors f) notice all links and buttons still work as expected g) enable PreservationModule syspref, go to /cgi-bin/koha/preservation/home.pl h) notice all links and buttons still work as expected == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #2 from Jake Deery <jake.deery@openfifth.co.uk> --- Short bug, and quick SO/QA would be appreciated. Feel free to MM me a quid-pro-quo :-) Ta, Jake -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194382|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 194403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194403&action=edit Bug 41976: LinkWrapper no longer mangles links This patch fixes a bug where, context-dependent, LinkWrapper can keep referencing back to links that should be out of scope. This was causing odd behaviour whilst writing Bug 14962 - namely, links returning as the same value in a table of multiple rows due to LinkWrapper treating linkData.href as one and the same for each row. TO TEST: == APPLY PATCH == a) enable ERMModule syspref, go to /cgi-bin/koha/erm/erm.pl b) notice all links and buttons still work as expected c) go to /cgi-bin/koha/sip2/sip2.pl d) notice all links and buttons still work as expected e) go to /cgi-bin/koha/acquisition/vendors f) notice all links and buttons still work as expected g) enable PreservationModule syspref, go to /cgi-bin/koha/preservation/home.pl h) notice all links and buttons still work as expected == SIGN OFF == Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I've only done basic testing: making sure I can add, edit and delete things. 2. So may require more thorough testing by someone who knows what is actually being fixed here (sounds like it can be hard to reproduce). 3. After applying the patch: yarn build and restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194403|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 194557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194557&action=edit Bug 41976: LinkWrapper no longer mangles links This patch fixes a bug where, context-dependent, LinkWrapper can keep referencing back to links that should be out of scope. This was causing odd behaviour whilst writing Bug 14962 - namely, links returning as the same value in a table of multiple rows due to LinkWrapper treating linkData.href as one and the same for each row. TO TEST: == APPLY PATCH == a) enable ERMModule syspref, go to /cgi-bin/koha/erm/erm.pl b) notice all links and buttons still work as expected c) go to /cgi-bin/koha/sip2/sip2.pl d) notice all links and buttons still work as expected e) go to /cgi-bin/koha/acquisition/vendors f) notice all links and buttons still work as expected g) enable PreservationModule syspref, go to /cgi-bin/koha/preservation/home.pl h) notice all links and buttons still work as expected == SIGN OFF == Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 --- Comment #7 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.04 |26.05.00,25.11.04,25.05.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: this was pushed for 25.05.11. --LE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38201 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Requires 38201, only in 25.11, will not be applied on 24.11.x. I think 25.05 should probably not include it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41976 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org