[Bug 7621] New: Circulation: Match age restriction of title with borrower's age without using categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Bug #: 7621 Summary: Circulation: Match age restriction of title with borrower's age without using categories Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: veron@veron.ch QAContact: koha.sekjal@gmail.com CC: gmcharlt@gmail.com The problem ----------- Public libraries and school libraries often have to deal with a lot of age restrictions, e.g. wit FSK (see www.fsk.de) or PEGI (Pan European Game Information, see www.pegi.info) and/or with regional rules regarding movies (virtually every canton in Switzerland has it's own rules). The classic way to implement age restrictions is to make use of a lot of categories. This gets soon very complicated, and is not easily maintainable. The librarians need an easy way to maintain age restrictions per title, otherwise they will not accept Koha. I tried to find a robust ad easily configurable way to match age restriction against the borrower's age. I implemented it on my test server. The concept ----------- 1) Have information about age restriction in field 521 a (Target audience) The entry can be anywhere in the field. It reads like PEGI 3 or FSK 12 (or any other 'tag' + age). 2) Have a preference like 'AgeRestrictionTags' where such tags are defined. It is a text field with a list like PEGI,FSK,Age... (Make things robust by accepting ,;: and space as delimiters...) 3) In circulation.pm, sub CanBookBeIssued, fetch the value from 521 a using the tags above. If the text after such tag is numeric, take this value as $restrictionyear. Add the years to the borrower's birth date. If the resulting date is in the future ( >today) , issuing is blocked by setting $issuingimpossible{AGE_RESTRICTION} = $restrictionyear; 4) In circulation.tt, part , add: [% IF ( AGE_RESTRICTION ) %] <li>Age restriction [% AGE_RESTRICTION %]</li> [% END %] Result ------- If a borrower tries to check out a restricted book and does not have the appropriate age, the circulation module will block the check out and issue a message like "Age restriction 12" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marc@msys.ch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #1 from Liz Rea <wizzyrea@gmail.com> 2012-02-29 16:54:28 UTC --- I might add that it might be helpful to have this for "canBookBeReserved" as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> 2012-02-29 18:08:30 UTC --- (In reply to comment #1)
I might add that it might be helpful to have this for "canBookBeReserved" as well.
It seems that CanBookBeReserved works on borrower and item data only (in Reserves.pm it loops through items and calls CanItemBeReserved ). The first idea would be to let CanBookBeReserved call CanBookBeIssued as well, but in this case at least the parameter handling of CanBookBeIssued would need modifications. It might even be necessary to break down CanBookBeIssued to several single sub routines (for each check one). This way, CanBokBeReserved and CanBookBeIssued could call the sub routines as appropriate. I think this would lead to some bigger architectural modifications. My proposition is to implement the functionality for CanBookBeIssued in a first step and to do the integration with CanBookBeIssued later. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-29 18:11:14 UTC --- Please make sure you wrap the behavior with a syspref so its only called for libraries that want it. Because it will cause a slight performance hit. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #4 from Marc Véron <veron@veron.ch> 2012-02-29 19:24:20 UTC --- (In reply to comment #3)
Please make sure you wrap the behavior with a syspref so its only called for libraries that want it. Because it will cause a slight performance hit.
I can do this with checking first C4::Context->preference('AgeRestrictionTags' ) If it is emtty, skip. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Some additional considerations: 1) The MARC field and subfield for age restriction needs to be configurable, so it can accommodate MARC21, UNIMARC and NORMARC equally. Note that Restrictions on Access are recorded in 506 in MARC21. UNIMARC 333 (Notes Pertaining to Users/Intended Audience) may be the best fit on that side. 2) A single delimiter for acceptable tags should be decided on. I recommend | to be consistent with other system preferences. Space should not be used, as someone will undoubtedly want to use a two-word tag (like "Age Restriction:"). 3) The behaviour should be configurable as to whether it completely blocks circ (issuingimpossible) or just prompts a confirmation box (needsconfirmation), since not every library will want to have this be a hard and fast rule. 4) Once DOM biblio indexing is in place, doing a numeric index on age restriction would make it searchable in the OPAC (and facetable, perhaps even with an "age appropriate for me?" facet for logged in users). 5) Should age restrictions interact at all with Analytics (passing through from serial record to monographic record)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #6 from Marc Véron <veron@veron.ch> --- I have implemented Ian Walls' suggestions #1-#3 on my server. Preferences in Section "Checkout Policy" read like this: 2 Fields: AgeRestrictionField AgeRestrictionSubField [ ] [ ] Marc field / subfield for age restriction. E.g. 521 a (Empty AgeRestrictionField - Do not apply age restriction) 1 Field: AgeRestrictionMarker [ ] E.g. FSK|PEGI|Age| (No white space near |). Entry in Marc e.g. PEGI 6 (Empty - Do not apply age restriction) 1 Drop down list: AgeRestrictionOverride [Prevent | Don't prevent] patrons from checking out an item whose age restriction would apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Version|unspecified |master Assignee|kyle.m.hall@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 9176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9176&action=edit Bug 7621 [ENH]- Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Edit preferences Circulation: AgeRestrictionField (521), AgeRestrictionSubField (a), AgeRestrictionMarker (FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Dont prevent) 2) Create a young patron account e.g. with age < 16 3) Create or edit a biblio with e.g. the value FSK 16 in the field 521a 4) Try to check out to young patron 5) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- I like the idea, but the patch is missing a few little things. It needs to do an updatedatabase.pl to add the syspref to the database, as well as updating the syspref.sql Another issue is the use of SELECT ExtractValue, this will fail on older mysql versions (pre 5.1) and is slow. It might be better to adapt the frameworks to link the MARC field to a column in biblioitems. Since you have all the columns in biblioitems available anyway. This would mean it would be the same query whatever MARC flavour, as the appropriate subfield would be linked to the column. Just a thought. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #9 from Marc Véron <veron@veron.ch> --- I'm implementing Chris' suggestions, please do not use the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 9219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9219&action=edit Bug 7621 [ENH]- Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9176|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- I'd like to sign off, but since I recommended the changes probably best if someone else does :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 9979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9979&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #13 from Marc Véron <veron@veron.ch> --- Previous patch did not longer apply. Remade patch and tested. Would be nice if somebody could sign off - thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9979|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10072&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Works well, has no effect unless the syspref is on. Safe change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: Fails QA for 2 reason, plus one request * Your patch introduce a perlcritic error: C4/Circulation.pm: Integer with leading zeros: "02" at line 976, column 41. See page 58 of PBP. (Severity: 5) * The description of the syspref look a little bit too complex to me: "Do not prevent patrons from checking out an item whose age restriction would apply". Saying "No" means "do not not prevent from ..." That's a typical "no-no" thing. It's much readable to have a yes-yes: "Prevent patrons from checking out..." "Yes/No". * for existing setups, it will be necessary to do some manual operations: - Add the Age Restriction marker and link it to biblioitems.agerestriction - if the Age Rescrition marker is already here, an UPDATE will be needed (something like "UPDATE biblioitems SET agerestriction=ExtractValue('@521$a',marcxml)") to fill the new biblioitems field That's worth adding a wiki page describing that and pointing to it during updatedatabase (I'll take care of this in the Release Notes as well) Note that this script is MARCflavour agnostic, so it should work in UNIMARC as well, (probably with field 333) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10072|0 |1 is obsolete| | --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 10136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10136&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restriction) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10136|0 |1 is obsolete| | --- Comment #18 from Marc Véron <veron@veron.ch> --- Created attachment 10141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10141&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restriction) (Added modified file) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10141|0 |1 is obsolete| | --- Comment #19 from Marc Véron <veron@veron.ch> --- Created attachment 10142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10142&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restrict (Added modified files..) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10142|0 |1 is obsolete| | --- Comment #20 from Marc Véron <veron@veron.ch> --- Created attachment 10143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10143&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restrict (Added modified files..,) Sorry for that many patches, mistaked with adding files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10143|0 |1 is obsolete| | --- Comment #21 from Marc Véron <veron@veron.ch> --- Created attachment 10144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10144&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restrict (Added modified files..,) Sorry for that many patches, mistaked with adding files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #22 from Marc Véron <veron@veron.ch> --- Finally I got all files :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10144|0 |1 is obsolete| | --- Comment #23 from Marc Véron <veron@veron.ch> --- Created attachment 10395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10395&action=edit [REBASED] BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #24 from delaye <stephane.delaye@biblibre.com> --- i test with a sandbox and an UNIMARC database; i use the tag 333$a where i enter the valeur FSK 16 but it didn't work : the young can checkout the issue. I must update biblioitems.agerestriction ? i must enter un flag in this new column ?... thank you for more information -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #25 from Marc Véron <veron@veron.ch> --- Hi Stephane, Thank you for testing! I se that teh wiki link is broken, it should be: http://wiki.koha-community.org/wiki/Age_restriction Did you follow the steps there? Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #26 from Marc Véron <veron@veron.ch> --- Ah I see you are testing in a sandbox. Maybe the prolbem is that you cann not update the database: --Snip Wiki ------- If you use the patch, make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' --End Snip Wiki ------- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #27 from delaye <stephane.delaye@biblibre.com> --- after apply the patch i can't update the system preference AgeRestrictionMarker and AgeRestrictionOverride i see the system preference in koha but une the table sql systempreferences i don't see them -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #28 from Marc Véron <veron@veron.ch> --- If the field 'agerestriction'is not in the table, you should run: installer/data/mysql/updatedatabase.pl or as alternative you can do the update directly using the following MySQL statement: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' ; Can you do that in the sandbox? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #29 from delaye <stephane.delaye@biblibre.com> --- mysql> desc biblioitems; +-----------------------+--------------+------+-----+-------------------+-----------------------------+ | Field | Type | Null | Key | Default | Extra | +-----------------------+--------------+------+-----+-------------------+-----------------------------+ | biblioitemnumber | int(11) | NO | PRI | NULL | auto_increment | | biblionumber | int(11) | NO | MUL | 0 | | | volume | mediumtext | YES | | NULL | | | number | mediumtext | YES | | NULL | | | itemtype | varchar(10) | YES | | NULL | | | isbn | varchar(30) | YES | MUL | NULL | | | issn | varchar(9) | YES | MUL | NULL | | | ean | varchar(13) | YES | MUL | NULL | | | publicationyear | text | YES | | NULL | | | publishercode | varchar(255) | YES | MUL | NULL | | | volumedate | date | YES | | NULL | | | volumedesc | text | YES | | NULL | | | collectiontitle | mediumtext | YES | | NULL | | | collectionissn | text | YES | | NULL | | | collectionvolume | mediumtext | YES | | NULL | | | editionstatement | text | YES | | NULL | | | editionresponsibility | text | YES | | NULL | | | timestamp | timestamp | NO | | CURRENT_TIMESTAMP | on update CURRENT_TIMESTAMP | | illus | varchar(255) | YES | | NULL | | | pages | varchar(255) | YES | | NULL | | | notes | mediumtext | YES | | NULL | | | size | varchar(255) | YES | | NULL | | | place | varchar(255) | YES | | NULL | | | lccn | varchar(25) | YES | | NULL | | | marc | longblob | YES | | NULL | | | url | varchar(255) | YES | | NULL | | | cn_source | varchar(10) | YES | | NULL | | | cn_class | varchar(30) | YES | | NULL | | | cn_item | varchar(10) | YES | | NULL | | | cn_suffix | varchar(10) | YES | | NULL | | | cn_sort | varchar(30) | YES | | NULL | | | agerestriction | varchar(250) | YES | | NULL | | | totalissues | int(10) | YES | | NULL | | | marcxml | longtext | NO | | NULL | | +-----------------------+--------------+------+-----+-------------------+---------------- INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AgeRestrictionMarker','','Markers for age restriction indication, e.g. FSK|PEGI|Age|. See: http://wiki.koha-community.org/wiki/Age_restriction',NULL,'free'); INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AgeRestrictionOverride',0,'Allow staff to check out an item with age restriction.',NULL,'YesNo'); select * from biblioitems where biblionumber=1979\G *************************** 1. row *************************** biblioitemnumber: 1979 biblionumber: 1979 volume: NULL number: NULL itemtype: LIVR isbn: 2869672020 issn: NULL ean: NULL publicationyear: 1993 publishercode: Vents d'ouest volumedate: NULL volumedesc: NULL collectiontitle: Grand large. collectionissn: NULL collectionvolume: NULL editionstatement: NULL editionresponsibility: NULL timestamp: 2012-06-27 16:41:24 illus: NULL pages: 46 p. notes: NULL size: 30 cm place: NULL lccn: NULL marc: 00516 2200193 4500001000500000010002100005090000900026100004100035200007300076210002400149215003400173225002300207101000800230615001200238676000700250333001100257700002600268701002800294 1979 a2869672020 d6.10 a1979 a20020311 frey50 1 aLe vol des urubus : La fièvre de l'or dtome 2 fEric Gutierrez bLIVR 1 cVents d'ouest d1993 1 a46 p. cBande dessinée d30 cm 1 aGrand large. vN°2 afre aFiction 1 aBD aFSK 16 1 92508 aGutierrez bEric 1 92509 aMigeat bFrançois url: NULL cn_source: NULL cn_class: NULL cn_item: NULL cn_suffix: NULL cn_sort: agerestriction: FSK 16 totalissues: NULL BUT the user who have 14 years can chekout the biblionumber 1979 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #30 from Marc Véron <veron@veron.ch> --- What is in the Preferences AgeRestrictionMarker and AgeRestrictionOverride ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #31 from delaye <stephane.delaye@biblibre.com> --- FSK|PEGI|Age and 0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #32 from Marc Véron <veron@veron.ch> --- Hmm, maybe a calculation issue with the birth date. What is the birthdate of the patron you tested with? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #33 from delaye <stephane.delaye@biblibre.com> --- birthdate of the borrower : 19/05/2001 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #34 from Marc Véron <veron@veron.ch> --- Thanks again for testing. I have to rebase to the current master, will try to get it done this evening. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #35 from delaye <stephane.delaye@biblibre.com> --- it's work!!!... thank you!! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #36 from Marc Véron <veron@veron.ch> --- Merveilleux, un grand merci! Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10395|0 |1 is obsolete| | --- Comment #37 from Marc Véron <veron@veron.ch> --- Created attachment 10550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10550&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion Rebased version. (Koha version: 3.09.00.018) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com QA Contact|koha.sekjal@gmail.com |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10550|0 |1 is obsolete| | --- Comment #38 from Mason James <mtj@kohaaloha.com> --- Created attachment 10650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10650&action=edit [PATCH] BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #39 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #38)
Created attachment 10650 [details] [PATCH] BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion
Passing QA on this... - fixed SQL typo in updatedatabase.pl then rebased patch on commit 'ce138ac96f3a5a729568f6d7db2e50ce3653b7bb' - patch passes 'perlcritic' and 'prove xt' tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10650|0 |1 is obsolete| | --- Comment #40 from Mason James <mtj@kohaaloha.com> --- Created attachment 10657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10657&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10657|0 |1 is obsolete| | --- Comment #41 from Mason James <mtj@kohaaloha.com> --- Created attachment 10658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10658&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #42 from Mason James <mtj@kohaaloha.com> ---
Passing QA on this...
- fixed SQL typo in updatedatabase.pl then rebased patch on commit 'ce138ac96f3a5a729568f6d7db2e50ce3653b7bb'
- patch passes 'perlcritic' and 'prove xt' tests
QA comment... - i added 'agerestriction' columns in kohastructure.sql, for biblioitems and deletedbiblioitems tables - and added 'agerestriction' column for deletedbiblioitems in updatedatabase.pl some little gotchas for adding new columns to a table in Koha ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #43 from Marc Véron <veron@veron.ch> --- Mason, Thanks a lot for passing QA and fixing beginner's mistakes! Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #44 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: I can't make it work. Here is what I did: * put "Age" in the AgeRestrictionMarker syspref * set "AgeRestrictionOverride" to allow * update default framework to map 330$a with biblioitems.agerestriction field * create a biblio, with Age 99, with an item * check-out the item to a patron that is born 01/01/1980 => checkout made without any warning. Am I missing something ? (note i've checked that biblioitems.agerestriction contains "Age 99", it does. QA question = shouldn't we update the MARC frameworks (in installer/data/mysql/<language>/marc_flavour/*.sql to connect agerestriction field to biblioitems ? failing QA until I can make it work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #45 from delaye <stephane.delaye@biblibre.com> --- I try again the patch test in a sandbox but I have this error message Applying: BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 7621 - Circulation: Match age restriction of title with borrower's age without using categories BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Apply? [yn] Patch left in /tmp/BUG-7621-ENH-Circulation-Match-age-restriction-of--YuivIy.patch **** I launch the following commands ALTER TABLE biblioitems ADD COLUMN agerestriction VARCHAR(255) DEFAULT NULL AFTER cn_sort; ALTER TABLE deletedbiblioitems ADD COLUMN agerestriction VARCHAR(255) DEFAULT NULL AFTER cn_sort; INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AgeRestrictionMarker','','Markers for age restriction indication, e.g. FSK|PEGI|Age|. See: http://wiki.koha-community.org/wiki/Age_restriction',NULL,'free'); INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AgeRestrictionOverride',0,'Allow staff to check out an item with age restriction.',NULL,'YesNo'); but i have always the problem , in koha i don't find the new system preference can you rebase the patch?.... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10658|0 |1 is obsolete| | --- Comment #46 from Marc Véron <veron@veron.ch> --- Created attachment 10859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10859&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion REBASED to Koha version: 3.09.00.025 Comparision part changed in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #47 from Marc Véron <veron@veron.ch> --- Typo in wiki link above, correct link is: http://wiki.koha-community.org/wiki/Age_restriction -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #48 from Marc Véron <veron@veron.ch> --- Comment on attachment 10859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10859 BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Hmm, seems that I forgot to commit changes. New patch follows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #49 from Mason James <mtj@kohaaloha.com> ---
REBASED to Koha version: 3.09.00.025 Comparision part changed in C4/Circulation.pm
Marc, can you provide a git-commit string, rather than the koha-version -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #50 from Marc Véron <veron@veron.ch> --- Created attachment 10866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10866&action=edit Bug 7621 . Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. Usage see http://wiki.koha-community.org/wiki/Age_restriction Changes in C4/Circulation.pm; - skip age restriciton part as well if no age restriction info in biblio record - more robust string comparision part (nested for... loops instead of grep and better handling of superfluous white space) - display whole age restriction string as information (e.g. FSK 16 instead of 16) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10859|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10658|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #51 from Paul Poulain <paul.poulain@biblibre.com> --- Ha ! I understang now why I couldn't make it work ! I needed almost 2 hours to understand !!! Try "Age" in the syspref, and enter Age 18 => epic fail In the code, the comparison line says: if (grep {uc($_) eq $value} @marker) { UC ! UC ! UC ! Try AGE, it works ! So, either fix the patch or fix the documentation 2 other reasons for failing QA: * You patch says: + my $td = Date_to_Days(Today); + my $ad = Date_to_Days(@alloweddate); + + if ( Date_to_Days(Today) < Date_to_Days(@alloweddate) -1 ) { => you make no use of $td and $ad * The patch also says: preference('AgeRestrictionOverride ') => the space at the end of the syspref is bad -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #52 from Marc Véron <veron@veron.ch> --- Paul, Thank you very much for testing and for your findings. I'm really sorry that I wasted your time with a basic Perl error. I'm coming from C++ and PHP and I'm not yet very used to Perl. Yesterday morning, I re-wrote the comparision part using a double for... loop to make the comparision code more readable, and it works now with "Age" (Upper-lower-case). But I could not manage to upload the new patch because git was down. I will try to get a new patch done this week if I find some time and a stable internet connection as well (still on vacation). Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #53 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #52)
Paul,
Thank you very much for testing and for your findings. I'm really sorry that I wasted your time with a basic Perl error. Don't worry for that, it's in my job ;-)
Yesterday morning, I re-wrote the comparision part using a double for... loop to make the comparision code more readable, and it works now with "Age" (Upper-lower-case). But I could not manage to upload the new patch because git was down. making it case agnostic is a good idea I think.
So comparing uc($_) eq uc($value) is probably a good idea imo -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10658|0 |1 is obsolete| | --- Comment #54 from Marc Véron <veron@veron.ch> --- Created attachment 10896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10896&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. Recoded comparision part to compare in upper case mode and to remove superfluous blanks. Message shows full reason e.g. PEGI 14 instead of 14. Usage: See http://wiki.koha-community.org/wiki/Age_restriction -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #55 from Marc Véron <veron@veron.ch> --- Finally managed to upload patch (I have a very bad internet connection at the moment). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #56 from Mason James <mtj@kohaaloha.com> --- Marc's latest patch needs a sign-off here... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10896|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11130&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> fix updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11130|0 |1 is obsolete| | --- Comment #58 from Marc Véron <veron@veron.ch> --- Created attachment 11550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11550&action=edit [SIGNED-OFF] BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> fix updatedatabase.pl New fix updatedatabase.pl to apply to current master by Marc Veron veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #59 from Marc Balmer <marc@msys.ch> --- (Mit Bezug zu comment 58)
Anhang 11550 angelegt (attachment 11550 [details]) [SIGNED-OFF] BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> fix updatedatabase.pl
New fix updatedatabase.pl to apply to current master by Marc Veron veron@veron.ch
The wiki page is actually at http://wiki.koha-community.org/wiki/Age_restriction -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11550|0 |1 is obsolete| | --- Comment #60 from Marc Véron <veron@veron.ch> --- Created attachment 11938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11938&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restriction Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> fix updatedatabase.pl New fix updatedatabase.pl to apply to current master by Marc Veron veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11938|0 |1 is obsolete| | --- Comment #61 from Marc Véron <veron@veron.ch> --- Created attachment 11939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11939&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> fix updatedatabase.pl New fix updatedatabase.pl to apply to current master by Marc Veron veron@veron.ch ...and fixed missing curly bracket after merging updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #62 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #61)
Created attachment 11939 [details] BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 52973fc) * b67201f BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories C4/Biblio.pm C4/Circulation.pm installer/data/mysql/kohastructure.sql installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #63 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed, well done everyone !!! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11939|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12132&action=edit Bug 7621: Followup: FIX warnings "Scalar value @values[$take] better written as $values[$take]" The previous patch introduces some perl warnings in log -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12132|0 |1 is obsolete| | --- Comment #65 from Marc Véron <veron@veron.ch> --- Created attachment 12133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12133&action=edit [SIGNED-OFF] Bug 7621: Followup: FIX warnings "Scalar value @values[$take] better written as $values[$take]" The previous patch introduces some perl warnings in log Signed-off-by: Marc Veron <veron@veron.ch> Tested with age restriction scenarios I used for development. Still works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #66 from Marc Véron <veron@veron.ch> --- Thanks for the follow up, Jonathan. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12133|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 12133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12133 [SIGNED-OFF] Bug 7621: Followup: FIX warnings "Scalar value @values[$take] better written as $values[$take]" Fix with Bug 8761 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #68 from Jonathan Druart <jonathan.druart@biblibre.com> --- adapting status -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #69 from Marc Véron <veron@veron.ch> --- Created attachment 12547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12547&action=edit Screenshots regarding usage PDF added to show how to use the Age restriction feature (on request of http://irc.koha-community.org/irclog/koha/2012-09-26#i_1088535) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #70 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12558&action=edit Bug 7621: Follow up to clarify preference language This patch changes strings only, not functionality. It will clarify the meaning of the AgeRestrictionMarker preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #71 from Nicole C. Engard <nengard@gmail.com> --- Follow up needs sign off. Original is already in master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12558|0 |1 is obsolete| | --- Comment #72 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12559&action=edit Bug 7621: Follow up to clarify preference language This patch changes strings only, not functionality. It will clarify the meaning of the AgeRestrictionMarker preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #73 from Nicole C. Engard <nengard@gmail.com> --- My last patch had typos. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12559|0 |1 is obsolete| | --- Comment #74 from Marc Véron <veron@veron.ch> --- Created attachment 12563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12563&action=edit [SIGNED-OFF] Bug 7621: Follow up to clarify preference language This patch changes strings only, not functionality. It will clarify the meaning of the AgeRestrictionMarker preference. Signed-off-by: Marc Veron <veron@veron.ch> Better wording of preference instructions. No code echange involved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #75 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #74)
Created attachment 12563 [details] [SIGNED-OFF] Bug 7621: Follow up to clarify preference language
This patch changes strings only, not functionality. It will clarify the meaning of the AgeRestrictionMarker preference.
Signed-off-by: Marc Veron <veron@veron.ch>
Better wording of preference instructions. No code echange involved.
passing QA, trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #76 from Paul Poulain <paul.poulain@biblibre.com> --- follow-up [SIGNED-OFF] Bug 7621: Follow up to clarify preference language pushed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org