[Bug 34382] New: Inconsistencies in Patron categories page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Bug ID: 34382 Summary: Inconsistencies in Patron categories page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Patron categories page, here is what should be changed to make it consistent with the other pages in the module: Page header - Add single quotes around the category code in Modify page - Add single quotes around the category code in Delete confirmation page - In the 'Cannot delete' page, the header styling is different - In the 'Delete confirmation' page, the header styling is different I'm not sure what to do about the deletion impossible page... It feels inconsistent, but I can't really find other examples. - The page title is "Cannot delete: category 'Y'"; the colon is what bugs me the most, 'Cannot' also feels informal to me - The breadcrumb is "Cannot delete: Category Y in use"; the colon, capital C on Category, no quotes around the category code, reason for error in breadcrumb? - The page header is "Category Y is in use. Deletion not possible!"; This is good information, but should it be the header? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154634&action=edit Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header This patch makes some changes to the patron categories administration page so that the page title, breadcrumb navigation, and headings are more consistent with each other. To test, apply the patch and go to Administration -> Patron categories. - Test all variations of the page: - Main page (listing categories) - New category - Edit category - Confirm deletion of category when the category is in use (there are existing patrons who have that category) - Confirm deletion of category when the category is not in use Note: This patch contains whitespace changes, so please ignore whitespace if you're checking the diff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154634|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154637&action=edit Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header This patch makes some changes to the patron categories administration page so that the page title, breadcrumb navigation, and headings are more consistent with each other. To test, apply the patch and go to Administration -> Patron categories. - Test all variations of the page: - Main page (listing categories) - New category - Edit category - Confirm deletion of category when the category is in use (there are existing patrons who have that category) - Confirm deletion of category when the category is not in use Note: This patch contains whitespace changes, so please ignore whitespace if you're checking the diff. Signed-off-by: Amanda Hovey <amanda.hovey@parliament.nsw.gov.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Amanda Hovey <amanda.hovey@parliament.nsw.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amanda.hovey@parliament.nsw | |.gov.au Status|Needs Signoff |Signed Off --- Comment #3 from Amanda Hovey <amanda.hovey@parliament.nsw.gov.au> --- Signed off by AH, JM, CN at KohaCon 2023 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154637|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154760&action=edit Bug 34382: Fix inconsistencies in Patron categories page titles, breadcrumbs, and header This patch makes some changes to the patron categories administration page so that the page title, breadcrumb navigation, and headings are more consistent with each other. To test, apply the patch and go to Administration -> Patron categories. - Test all variations of the page: - Main page (listing categories) - New category - Edit category - Confirm deletion of category when the category is in use (there are existing patrons who have that category) - Confirm deletion of category when the category is not in use Note: This patch contains whitespace changes, so please ignore whitespace if you're checking the diff. Signed-off-by: Amanda Hovey <amanda.hovey@parliament.nsw.gov.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 23.05.x, maybe depends on Bug 33909 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Depends on| |33909 Status|Pushed to master |RESOLVED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 [Bug 33909] Improve translation of title tags: Administration -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org