[Bug 36925] New: ERM eUsage reports : data table filter does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Bug ID: 36925 Summary: ERM eUsage reports : data table filter does not work Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: michaela.sieber@kit.edu CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com The data table filter does not work in the ERM module > eUsage > reports Just Processing... but nothing happens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167544&action=edit Test file - TR_J1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167545&action=edit Bug 36925: Remove filtering from usage reports The query behind a usage report is too complex for the datatables filtering options and so should be removed until we can add some datatables utility methods to assist with the filtering Test plan: 1) Navigate to E-resource management > eUsage > Data providers 2) Create a provider 3) Click into the provider and navigate to the Manual upload tab 4) Upload the file attached 5) Navigate to the Reports section in the left hand menu 6) Run a report that returns some data from the harvested file (report type is TR_J1) 7) Try to filter the table using the filter inputs, it will fail 8) Apply patch 9) Run yarn js:build to rebuild the Javascript 10) Hard refresh the browser 11) The filter options should not not be in the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- The query behind the reports table is too complex for the datatable filtering so in the short term we need to switch the filtering off. Reports can be exported to excel for filtering / analysis -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 167592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167592&action=edit Screentshot - Export option NOT visible after the patch is applied This works, however the 'Export' button/link is not there after the patch. See the attached screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167592|Screentshot - Export option |Screenshot - Export option description|NOT visible after the patch |NOT visible after the patch |is applied |is applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167856&action=edit Bug 36925: Reinstate export button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167545|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167857&action=edit Bug 36925: Remove filtering from usage reports The query behind a usage report is too complex for the datatables filtering options and so should be removed until we can add some datatables utility methods to assist with the filtering Test plan: 1) Navigate to E-resource management > eUsage > Data providers 2) Create a provider 3) Click into the provider and navigate to the Manual upload tab 4) Upload the file attached 5) Navigate to the Reports section in the left hand menu 6) Run a report that returns some data from the harvested file (report type is TR_J1) 7) Try to filter the table using the filter inputs, it will fail 8) Apply patch 9) Run yarn js:build to rebuild the Javascript 10) Hard refresh the browser 11) The filter options should not not be in the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167856|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167858&action=edit Bug 36925: Reinstate export button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167857|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 167862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167862&action=edit Bug 36925: Remove filtering from usage reports The query behind a usage report is too complex for the datatables filtering options and so should be removed until we can add some datatables utility methods to assist with the filtering Test plan: 1) Navigate to E-resource management > eUsage > Data providers 2) Create a provider 3) Click into the provider and navigate to the Manual upload tab 4) Upload the file attached 5) Navigate to the Reports section in the left hand menu 6) Run a report that returns some data from the harvested file (report type is TR_J1) 7) Try to filter the table using the filter inputs, it will fail 8) Apply patch 9) Run yarn js:build to rebuild the Javascript 10) Hard refresh the browser 11) The filter options should not not be in the table Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167858|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 167863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167863&action=edit Bug 36925: Reinstate export button Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 --- Comment #10 from David Nind <david@davidnind.com> --- One minor note, but wasn't a blocker for me: The Export link is now just after Last >>, rather than aligned to the far right. Testing notes (using KTD): 1. Details I used for a report (step 6). Go to Reports > Create report and use these values for the options: Data display: By year Choose data provide: [The provider you created in step 2] Choose report: TR_J1.... Start year: 2020 End year: 2024 Select report columns: select all available columns to display (I saved the report: enter a name for the report and the "Save report".) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Dave <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- What's the problem exactly with the filtering? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- datatables.js is used for other tables (and will be used for all tables after bug 26553). You should assume that the hasFilters flag is true by default, otherwise it removes the "clear" everywhere else. Eg. on branches.pl https://snipboard.io/Z5Jogq.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 38835 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 --- Comment #14 from Mathieu Saby <mathsabypro@gmail.com> --- I don't understand all the comments. Is the patch signd off or in failed qa? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36925 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org