[Bug 18419] New: Broken patron-blank image in viewlog.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Bug ID: 18419 Summary: Broken patron-blank image in viewlog.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org Created attachment 62062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62062&action=edit screenshot The theme's patron-blank.png image is incorrectly referenced from the viewlog.tt template, resulting in a broken image. One can see this by going to the logs tool, selecting the "Patrons" module, and filling in a borrowernumber under "object" which matches a patron who does not have a custom image. Screenshot attached. I believe this is due to the interaction between line #13 of circ-menu.inc and lines #58-66 of viewlog.tt. The circ menu include expects a value like "/intranet-tmpl" for the "interface" variable (this is what's used on circulation.tt, for instance) while viewlog.tt has a switch statement that assigns the value "Intranet" to the variable, causing the link to break. I'd offer a patch except I'm not sure how the interface value is used throughout viewlog.tt and its includes, or why it appears to refer to the same interface (the intranet) in two different forms for two different templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62691&action=edit Bug 18419 - Broken patron-blank image in viewlog.tt Because of a variable name collision the blank patron image doesn't display in viewlog.tt. This patch moves the image from the template to the stylesheet to avoid this problem. This patch also replaces the blank patron image PNG file with an SVG file. SVG support is wide enough to begin using whereever possible. This patch also removes some inline CSS from circ-menu.inc and puts it in the global stylesheet. To test, apply the patch and clear your browser cache if necessary. - Enable the patronimages system preference. - View a patron account which lacks a patron image. All views (details, fines, notices, etc) should show the "blank" patron image, including the modification log view. - View a patron account which has a patron image and check that it still displays correctly in all views. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62691|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 62729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62729&action=edit [SIGNED-OFF] Bug 18419 - Broken patron-blank image in viewlog.tt Because of a variable name collision the blank patron image doesn't display in viewlog.tt. This patch moves the image from the template to the stylesheet to avoid this problem. This patch also replaces the blank patron image PNG file with an SVG file. SVG support is wide enough to begin using whereever possible. This patch also removes some inline CSS from circ-menu.inc and puts it in the global stylesheet. To test, apply the patch and clear your browser cache if necessary. - Enable the patronimages system preference. - View a patron account which lacks a patron image. All views (details, fines, notices, etc) should show the "blank" patron image, including the modification log view. - View a patron account which has a patron image and check that it still displays correctly in all views. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62729|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62746&action=edit Bug 18419 - Broken patron-blank image in viewlog.tt Because of a variable name collision the blank patron image doesn't display in viewlog.tt. This patch moves the image from the template to the stylesheet to avoid this problem. This patch also replaces the blank patron image PNG file with an SVG file. SVG support is wide enough to begin using whereever possible. This patch also removes some inline CSS from circ-menu.inc and puts it in the global stylesheet. To test, apply the patch and clear your browser cache if necessary. - Enable the patronimages system preference. - View a patron account which lacks a patron image. All views (details, fines, notices, etc) should show the "blank" patron image, including the modification log view. - View a patron account which has a patron image and check that it still displays correctly in all views. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I promise I will try to not remove this empty div, but I cannot guarantee it :) I would have replaced the li id with something more explicit that "patronbasics". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #4)
I promise I will try to not remove this empty div, but I cannot guarantee it :)
I felt it was better to have the empty div as the placeholder for the blank image so that there was a more specific target for CSS (more specific than the <li>). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 --- Comment #8 from Eric Phetteplace <ephetteplace@cca.edu> --- Such a quick fix! Thanks everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18419 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org