[Bug 16877] New: GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Bug ID: 16877 Summary: GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: srdjan@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Despite the DBI docs, $sth->fetchall_arrayref( {} ) throws an error on xenial. Simple {Slice => {}} would fix it. But let's take this as an opportunity to replace it with Koha::Patron::Categories->search(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |srdjan@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 53212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53212&action=edit Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- To test: * Check the "Category" list on eg Patron attribute type maint screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53212|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 53213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53213&action=edit Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search() Followed plan from comment #2 * Check the "Category" list on eg Patron attribute type maint screens prove t/db_dependent/Members.t: Same results with and without patch (Test 1 fails, but not related to this patch) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 --- Comment #4 from Marc Véron <veron@veron.ch> --- Note: Error with t/db_dependent/Members.t was due to a local problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Srdjan, I have removed this subroutine on bug 15407 which is waiting for QA. I'd prefer to see it pushed and mark this one as a duplicate instead of rewriting a patch and rebasing the patchset. Would you agree? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Totally. I should have looked at the bug list again when I decided not to go with the simple fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 15407 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org