[Bug 8096] New: card number twice on patron search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Priority: P5 - low Change sponsored?: --- Bug ID: 8096 Assignee: oleonard@myacpl.org Summary: card number twice on patron search Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 9597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9597&action=edit card number twice Why is the card number showing twice on the patron search results? We really only need it once - either in it's own column or in parens. Twice is confusing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Display of the patron name and card number in the second column is handled by an include, patron-title.inc, which offers a way to display the patron name in a standard format in various places in the templates. We can't remove the display of the barcode in the second column without affecting other displays too. The card number in the first column seems useful since it's easier to scan down the column if you're looking for a number. And hopefully someday we'll have AJAX-driven DataTables support on this page and we'll be able to sort by card number. I'm inclined to say "wontfix" since there are good reasons to have the number in both places. What do others think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- The question I keep getting is - what is that second number in parens. It's hard enough to get people to understand the difference between borrowernumber and the cardnumber - showing two numbers on this results page is confusing people already. Obviously I'll go with the masses, but I wanted you all to know this comment isn't coming from me (but I do agree with it) it's coming from librarians seeing Koha 3.8. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid in the new patron search. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Assignee|oleonard@myacpl.org |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 33604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33604&action=edit Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|card number twice on patron |Card number twice on patron |search |search results -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Marc, Please convince me why the change below should be correct: - ([% cardnumber -%]) + [% IF ( borrower.cardnumber ) %] + ([% borrower.cardnumber %]) + [% END %] It was prefixed without borrower and now it is. You do only change templates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 --- Comment #6 from Marc Véron <veron@veron.ch> --- Hi Marcel, I will not even try to convince you, I simply mistaked. Patch with corrections follows. Groetjes Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33604|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 33626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33626&action=edit Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 --- Comment #8 from Marc Véron <veron@veron.ch> --- Patch still applies with current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33626|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34608&action=edit Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places. Signed-off-by: Chris <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34608|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34721&action=edit [PASSED QA] Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places. Signed-off-by: Chris <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=8096 Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org