[Bug 39739] New: OPAC's datatables.js out of sync with staff's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Bug ID: 39739 Summary: OPAC's datatables.js out of sync with staff's Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org When helping adapt bug 38340 to our coding guidelines and general style, I found the need to rewrite a manually crafted datatable using kohaTable. What I found is that key pieces (like x-koha-request-id handling) are missing. I propose we port the intranet version into the OPAC. With some caveats. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |katrin.fischer@bsz-bw.de, | |martin.renvoize@openfifth.c | |o.uk, tomascohen@gmail.com Assignee|oleonard@myacpl.org |tomascohen@gmail.com Status|NEW |Needs Signoff Blocks| |38340 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 [Bug 38340] Translatability - Standard form include files are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38340 |39600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 [Bug 38340] Translatability - Standard form include files are not translatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 [Bug 39600] Paginate (and modernize) OPAC ILL requests table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181444&action=edit Bug 39739: Sync OPAC's datatables.js with the staff interface's version This patch overwrites the OPAC version of `datatables,js` with the one for the staff interface. A block code adding links to the columns configuration page is removed as it doesn't apply to the OPAC and produces errors in the console for missing variable definitions that would be inherited from the caller context (looking for `CAN_user_parameters_manage_column_config`). To test: 1. Apply this patch 2. Find templates using `kohaTable`: $ cd koha-tmpl/opac-tmpl $ git grep kohaTable 3. Play in the UI with those pages => SUCCESS: Tables work, nothing's broken 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181444|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181506&action=edit Bug 39739: Sync OPAC's datatables.js with the staff interface's version This patch overwrites the OPAC version of `datatables,js` with the one for the staff interface. A block code adding links to the columns configuration page is removed as it doesn't apply to the OPAC and produces errors in the console for missing variable definitions that would be inherited from the caller context (looking for `CAN_user_parameters_manage_column_config`). To test: 1. Apply this patch 2. Find templates using `kohaTable`: $ cd koha-tmpl/opac-tmpl $ git grep kohaTable 3. Play in the UI with those pages => SUCCESS: Tables work, nothing's broken 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Simple resync.. agree with the singular removed function that's a staff only requirement and I've tested various tables in the OPAC. Happy it's all working.. QA script reports some new console.logs but I don't think there's anything to worry about here. Passing QA (I do think there's some tidying up we can do down the line to both the staff and opac versions of this.. feels like we're duplicating some code when I looked) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- This does not make sense. The tables and features *are* different on the two interfaces, and it has always been like that. This should be revert IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some of it was needed for bug 39600 I believe. I know we don't offer some of the features in the OPAC like the actual column settings, but we do have export and some others. Do we have negative side effects if we keep it? Having them in synch might be easier to maintain, even if some things are not used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- x-koha-request-id didn't exist in columns_settings.inc or datatables.js prior to bug 26553. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #7)
x-koha-request-id didn't exist in columns_settings.inc or datatables.js prior to bug 26553.
Sorry, can you explain a bit more? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #6)
Some of it was needed for bug 39600 I believe. I know we don't offer some of the features in the OPAC like the actual column settings, but we do have export and some others. Do we have negative side effects if we keep it? Having them in synch might be easier to maintain, even if some things are not used.
Yes, it's bad and wrong to have code that is not used: state, shareable link, colvis, etc. Always the UI is broken (see the export button) The dom was different on purpose, as well as other attributes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #8)
(In reply to Jonathan Druart from comment #7)
x-koha-request-id didn't exist in columns_settings.inc or datatables.js prior to bug 26553.
Sorry, can you explain a bit more?
In comment 0, Tomas want to have x-koha-request-id back at the OPAC. But I didn't find any traces of this before 26553. So my guess is that it never worked, and we should only add the code dealing with this header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it will conflict if I revert with the other bigger feature. Waiting for Tomas to see how we can move forward here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #11)
I think it will conflict if I revert with the other bigger feature. Waiting for Tomas to see how we can move forward here.
The patch reverts cleanly from main. I am not pushing this yet, waiting for feedback from Tomas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #12)
(In reply to Katrin Fischer from comment #11)
I think it will conflict if I revert with the other bigger feature. Waiting for Tomas to see how we can move forward here.
The patch reverts cleanly from main. I am not pushing this yet, waiting for feedback from Tomas.
For reverting it, you will need to also revert ad4a9777a2306ab8bf6f85e94aff2507695b5122 and also need a follow-up I can prepare. If Joubu insists I can go that route. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #14 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #10)
(In reply to Katrin Fischer from comment #8)
(In reply to Jonathan Druart from comment #7)
x-koha-request-id didn't exist in columns_settings.inc or datatables.js prior to bug 26553.
Sorry, can you explain a bit more?
In comment 0, Tomas want to have x-koha-request-id back at the OPAC. But I didn't find any traces of this before 26553. So my guess is that it never worked, and we should only add the code dealing with this header.
There's never been an API driven datatable in the OPAC it seems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |RM NOTE: REVERTED release notes| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are taking a step back here, to move forward again. Reverted this patch, which will break bug 39600 for the moment, but hope we can fix that quickly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|RM NOTE: REVERTED | release notes| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... not reverted yet (sorry for the back and forth) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #17 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I've submitted a patch for 39600 that would *only* introduce server side rendering in the OPAC's datatables, and could pair with reverting this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #18 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- This should be reverted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |RM NOTE: REVERTED release notes| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #18)
This should be reverted.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Reverted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #20)
Reverted.
So status need update right ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 | released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |WONTFIX --- Comment #22 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Feature parity should be discussed. It will probably happen when we really need it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39739 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #22)
Feature parity should be discussed. It will probably happen when we really need it.
If we ever push bug 35716, then this could be interesting to explore again. That said, I'd love to see a day where the OPAC is purely API-driven, and then it would make even more sense to keep them separate. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org