https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156324&action=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - Test the "Enroll" and "Cancel enrollment" buttons to confirm that look correct and work as expected. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156325&action=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - The "Enroll" and "Cancel enrollment" buttons should look correct and work as expected: - Click the "Enroll" button. - On the enrollment confirmation view, test both the "Finish enrollment" button and the "Cancel" link. - Test "Cancel enrollment" button. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156456|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 156460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156460&action=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - The "Enroll" and "Cancel enrollment" buttons should look correct and work as expected: - Click the "Enroll" button. - On the enrollment confirmation view, test both the "Finish enrollment" button and the "Cancel" link. - Test "Cancel enrollment" button. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156460|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156494&action=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - The "Enroll" and "Cancel enrollment" buttons should look correct and work as expected: - Click the "Enroll" button. - On the enrollment confirmation view, test both the "Finish enrollment" button and the "Cancel" link. - Test "Cancel enrollment" button. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.