https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 161576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161576&action=edit Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source Like Bug 19372, selecting MARC framework currently doesn't work when adding to basket from an external source. Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install. Looks like it comes from a bad syntaxe than needs to be replaced in any case. Test plan: 1) Add an order to a basket from an external source 2) Select another framework than the default one 3) Chek the framework code you will pick will be used in the created biblio record -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Needs Signoff |ASSIGNED --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Can't reproduce on a Ubuntu 20.04 ktd. tested on marc21 and unimarc an picked an appropriate external server source for each. Each time on the record, I got the framework that I picked in the search result view. --- Fridolin:

Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install.

Did you mean "I can't reproduce" ? --- David:

Happy to sign off if this is aimed at improving the code and no change in behavour.

Tested with patches on Ubuntu 20.04 with unimarc. At least no sign of regression indeed. @Fridolin: was this patch tested on the instance that had the issue? Back to assignee to avoid having more people try to test while a way is found to reproduce. And if not, we say that it's a hardening patch and testing is just needed to see that there is no obvious regression. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Oh no, it's Debian 9 and it's not supported anymore :o After many attempts, here is how to start an old image: # Somehow it needs elasticsearch, here opensearch works fine KOHA_IMAGE=22.05-stretch bin/ktd --os1 up # It works with the master branch of KTD repo # After trying, older branches don't help to simplify the operation. # and **while** it's starting go into the container and edit the repositories vim /etc/apt/sources.list # replace "httpredir" with "archive" and removed the 2nd line. # In the end the content should be ``` deb http://archive.debian.org/debian stretch main ``` # otherwise it will 404 when trying to install the cpanoutdated package and crash -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

After many attempts, here is how to start an old image:

(and Koha's code should be on 22.05.x) And all this to no even reproduce the bug T_T Anyway, let's go with David's suggestion to sign-off that there is no visible regression. As it fixed the bug on your production instance. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

this is a 22.05 bug?

No, it's just that one must go back to 22.05 to start a Debian 9, I tried that in case that was needed to reproduce. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162487|0 |1 is obsolete| | --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166555&action=edit Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source Like Bug 19372, selecting MARC framework currently doesn't work when adding to basket from an external source. Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install. Looks like it comes from a bad syntaxe than needs to be replaced in any case. Test plan: 1) Add an order to a basket from an external source 2) Select another framework than the default one on the search result view. Before doing 'add order' on choosen search result line. 3) Chek the framework code you will pick will be used in the created biblio record Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36620 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36620 [Bug 36620] Broken order management for suggestions with quantity -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.