[Bug 29498] New: Remove usage of deprecated Mojolicious::Routes::Route::detour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Bug ID: 29498 Summary: Remove usage of deprecated Mojolicious::Routes::Route::detour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 The method is used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 127705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127705&action=edit Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 It was used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. This patch makes use of the "partial" attribute instead, which does the same thing. Test plan: 1. Run `morbo bin/intranet` 2. Point your browser to what morbo says (should be localhost:3000) 3. Log in, and go to Administration » Libraries. This table uses the REST API, so if you see data in it, that means the API (and the patch) works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127705|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128676&action=edit Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 It was used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. This patch makes use of the "partial" attribute instead, which does the same thing. Test plan: 1. Run `morbo bin/intranet` 2. Point your browser to what morbo says (should be localhost:3000) 3. Log in, and go to Administration » Libraries. This table uses the REST API, so if you see data in it, that means the API (and the patch) works Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |mtj@kohaaloha.com, | |tomascohen@gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Trivial change that prepares the ground for upgrading Mojolicious (in the works). Works as expected, passes the QA checks. Straight QA as it will hardly find a good soul to QA it sooner than later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maybe we need a new component for Koha as a Mojolicious app. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Not backporting to 21.05, please ask if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org