[Bug 8288] New: showmarc.tt should not include full doc-head-close.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Priority: P5 - low Change sponsored?: --- Bug ID: 8288 Assignee: oleonard@myacpl.org Summary: showmarc.tt should not include full doc-head-close.inc Severity: minor Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: Templates Product: Koha showmarc.tt is only called by modal dialogs for previewing MARC records or card views in acquisitions and cataloging. Since it is a minimal page loaded within a page it doesn't need to load all the CSS and JS a full page does. It also creates the possibility of unintended consequences if you have intranetuserjs triggering something on document load: the event will be triggered again when the dialog loads. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 10438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10438&action=edit Bug 8288 - showmarc.tt should not include full doc-head-close.inc showmarc.tt and opac-showmarc.tt are used to load a plain view of a MARC record and thus do not need the full set of page assets loaded with other pages (CSS and JavaScript). Removing the standard doc-head-close include will reduce the load time of these pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10438|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10448&action=edit Bug 8288 - showmarc.tt should not include full doc-head-close.inc showmarc.tt and opac-showmarc.tt are used to load a plain view of a MARC record and thus do not need the full set of page assets loaded with other pages (CSS and JavaScript). Removing the standard doc-head-close include will reduce the load time of these pages. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Template only change to remove unnecessary code loading in the showmarc.tt context. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Bugfix pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org