[Bug 13696] New: Add support for Font Awesome icons in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Bug ID: 13696 Summary: Add support for Font Awesome icons in Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35829&action=edit Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Templates |and plumbing | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 35881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35881&action=edit Screenshot showing before and after Looks like it's not quite a drop-in replacement. I'd like to see more testing done to see why things look off-kilter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Owen, Are you doing the testing? I'm not sure what I'm seeing on this that's off kilter except that the bottom buttons are smaller. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #4 from Marc Véron <veron@veron.ch> --- Nice Icons. Is it possible to get kind of testig patch for a template just to see how it works, e.g. to reproduce Owens's screenshot? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36432&action=edit Bug 13636 SAMPLE: Add support for Font Awesome icons in Koha This is just a sample file, not part of the enhancement. Changing members-toolbar.inc to FontAwesome icons (fixed width). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36432|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36433&action=edit Bug 13636 SAMPLE: Add support for Font Awesome icons in Koha This is just a sample file, not part of the enhancement. Changing members-toolbar.inc to FontAwesome icons (fixed width). http://bugs.koha-community.org/show_bug.cgi?id=13696 Bug 13636 SAMPLE: Add support for Font Awesome icons in Koha Some more icons changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35829|0 |1 is obsolete| | --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36434&action=edit Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #8 from Mirko Tietgen <mirko@abunchofthings.net> --- Patch works as promised. I came across these icons some time ago and wondered if we could use them in Koha, nice enhancement! This is not supposed to invalidate Owen's concerns, just confirming that using the icons on a page works for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am hesitating about adding those without an idea on how we plan to make use of them. Why are they more free? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #10 from Marc Véron <veron@veron.ch> --- License of Glyphicons: http://glyphicons.com/license/ License of Font-Awesome: http://fortawesome.github.io/Font-Awesome/license/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, what's the plan here? How will we use these fonts? (In reply to Katrin Fischer from comment #9)
Why are they more free?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #11)
Kyle, what's the plan here? How will we use these fonts?
ping? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #13 from Kyle M Hall <kyle.m.hall@gmail.com> --- The idea is just to give us more options for icons. We don't need to replace the glyphicons wholesale once this is in Koha, but we could certainly migrate away from them over time! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36433|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42916&action=edit Bug 13696: Add new pref IconTheme This will permit to choose the icon theme to use: Glyphicons (default) or Font-Awesome. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42917&action=edit Bug 13696: Pass the classes to use for icons to the templates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trying to unblock this bug report: I have submitted 2 new patches, they insert a new pref 'IconTheme' which can be changed from Glyphicons to Font-Awasome. All the icons used should be impacted by this change. Was it the idea behind this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #17 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Jonathan Druart from comment #16)
Trying to unblock this bug report: I have submitted 2 new patches, they insert a new pref 'IconTheme' which can be changed from Glyphicons to Font-Awasome. All the icons used should be impacted by this change.
Was it the idea behind this?
That is not necessary! Glyphicons and Font-Awesome can be used side-by-side within Koha. There is no need to make this an either-or proposition! The primary reason to add support for Font-Awesome is that it is far more powerful than Glyphicons, and is also FOSS, unlike Glyphicons. If we add support for Font Awesome to Koha, then we can, over time, replace our current usage of Glyphicons with Font Awesome until we are no longer using Glyphicons at all. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So why don't we replace them? I don't see the point to integrate them into Koha if we don't use it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14915 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 [Bug 14915] Use Font Awesome instead of Glyphicons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #19 from Kyle M Hall <kyle.m.hall@gmail.com> --- I agree we should replace them! (In reply to Jonathan Druart from comment #18)
So why don't we replace them? I don't see the point to integrate them into Koha if we don't use it.
Ok! Let's do it! Bug 14915 switches the staff side to Font Awesome icons. I will file another patch for the opac side! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #20 from Kyle M Hall <kyle.m.hall@gmail.com> --- I think this can go back to signed off now! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42931&action=edit Bug 13696 [QA Followup] - Add Font Awesome license to the about page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36434|0 |1 is obsolete| | Attachment #42931|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42933&action=edit Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42934&action=edit Bug 13696 [QA Followup] - Add Font Awesome license to the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- IMO this should be pushed with bug 14915, or we should comment the change in koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc for the next release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14610 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place document delivery / article requests in Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44012&action=edit Bug 13696 [QA Followup] - Update FA to 4.4.0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44037&action=edit [PASSED QA] Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44038&action=edit [PASSED QA] Bug 13696 [QA Followup] - Add Font Awesome license to the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44039&action=edit [PASSED QA] Bug 13696 [QA Followup] - Update FA to 4.4.0 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42934|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good job Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org