http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 23899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23899&action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23899|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23906&action=edit Bug 11474: Remove errors caused by use of switch Have replaced a switch statement by an if so we do not get warnings on compilation Note the perldoc for the subroutine was not correct code was not testing that paramater equalled the values but that it contained them. Have amended accordingly Have documented behaviour in case parameter contains neither value. subroutine does not appear to me used elsewhere in codebase Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23906|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23913&action=edit [PASSED QA] Bug 11474: Remove errors caused by use of switch Have replaced a switch statement by an if so we do not get warnings on compilation Note the perldoc for the subroutine was not correct code was not testing that paramater equalled the values but that it contained them. Have amended accordingly Have documented behaviour in case parameter contains neither value. subroutine does not appear to me used elsewhere in codebase Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, especially t/DateUtils.t. -- You are receiving this mail because: You are watching all bug changes.