[Bug 39172] New: Merging records no longer compares side by side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Bug ID: 39172 Summary: Merging records no longer compares side by side Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 178372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178372&action=edit Before Bootstrap comparison After Bug 35402 the record merge now longer shows the final record next to the selected records, but shows instead. I checked out the commit before 35402 and then checked out 35402 to compare, then also confirmed on main. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 --- Comment #1 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 178800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178800&action=edit Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a release notes| |regression when merging | |records in the cataloging | |module. Columns will show | |side by side again when | |comparing records for a | |merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178800|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178807&action=edit Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178807|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 178809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178809&action=edit Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: jason vasche <jvasche@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178809|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 178810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178810&action=edit Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: jason vasche <jvasche@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178810|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179098&action=edit Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jason Vasche <jvasche@roundrocktexas.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Brenda <bowens@washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowens@washoecounty.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Rhonda Kuiper <rkuiper@roundrocktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov --- Comment #7 from Rhonda Kuiper <rkuiper@roundrocktexas.gov> --- Can this be backported to 24.11 since this restores function we had previously. Thanks, Rhonda K. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Rhonda Kuiper from comment #7)
Can this be backported to 24.11 since this restores function we had previously. Thanks, Rhonda K.
Hi Rhonda, usually bug fixes will be backported if the bug exists in the lower versions as well - it can help RMaints to have confirmation about that. I'll also add the rel... keyword to highlight it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Nancy M. <nmumford@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmumford@clamsnet.org --- Comment #10 from Nancy M. <nmumford@clamsnet.org> --- This issue was also a problem for comparing files during vendor uploads. The original record used to be side by side with the imported record. Post upgrade the imported record was pushed to the bottom, under the original record. This is still not fixed and was reported to Bywater today 3/31. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nancy M. from comment #10)
This issue was also a problem for comparing files during vendor uploads. The original record used to be side by side with the imported record. Post upgrade the imported record was pushed to the bottom, under the original record. This is still not fixed and was reported to Bywater today 3/31.
Hi Nancy, thanks for your comment. As this has already been pushed and backported to stable versions, we'll need a separate bug report to fix the vendor uploads. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Brian Pichman <brian.pichman@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39991 [Bug 39991] Side By Side Record Comparision in Vendor File - Results No Longer Side by Side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39172 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org