[Bug 25812] New: Display overdue fines for the document on SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Bug ID: 25812 Summary: Display overdue fines for the document on SIP checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Display overdue fines for the document on SIP checkin Test plan: - Using SIP, checkin an item that has one or several overdue fines. - Check that the following message is displayed (AF field): "You owe {correctly formatted price} for this document." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 106056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106056&action=edit Bug 25812: Display overdue fines for the document on SIP checkin. Test plan: - Using SIP, checkin an item that has one or several overdue fines. - Check that the following message is displayed (AF field): "You owe {correctly formatted price} for this document." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display overdue fines for |Display overdue fines for |the document on SIP checkin |the item on SIP checkin --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think document is not the right word here - i'd use item as it's neutral to what it is (it could be anything from keys to a multi-part language course). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #3 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 106340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106340&action=edit Bug 25812: Display overdue fines for the item on SIP checkin. Test plan: - Using SIP, checkin an item that has one or several overdue fines. - Check that the following message is displayed (AF field): "You owe {correctly formatted price} for this item." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106056|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Thanks for the feedback, Katrin. The new patch uses item instead of document. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106340|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139690&action=edit Bug 25812: Display overdue fines for the item on SIP checkin. Test plan: - Using SIP, checkin an item that has one or several overdue fines. - Check that the following message is displayed (AF field): "You owe {correctly formatted price} for this item." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good and works as designed.. I wonder if other outstanding charges associated with the patron and item combination should be taken into account.. i.e. issueing charges? Signing off, but form a QA perspective I'd love to see a Unit test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- I like this, but I think it needs to be optional. It would be nice if the feature accepted a TT template so the message could be translated, but even a simple on/off switch would suffice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display overdue fines for |Fines can be displayed on |the item on SIP checkin |SIP checkin/checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139690|0 |1 is obsolete| | --- Comment #8 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 144217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144217&action=edit Bug 25812: Fines can be displayed on SIP checkin/checkout This new patch adds the following: - rebased on master - adds a configuration option in SIPconfig.xml: show_outstanding_amount - extends the feature to SIP checkout - adds unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #9 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- I'm not sure if the status should be Signed Off or Needs Signoff, since Martin has signed off before, but the feature has been extended to checkouts. Feel free to change accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #10 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Also, not sure if show_outstanding_amount should be enabled or disabled by default in SIPconfig.xml. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests look solid to me.. my signoff still stands.. just need a QA on this now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144217|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144476&action=edit Bug 25812: Fines can be displayed on SIP checkin/checkout Test plan: - Enable show_outstanding_amount in SIPconfig.xml - Check that the total outstanding amout for the patron is displayed on SIP checkout (if it exists), for example: Patron has fines - You owe $10.00. - Check that the outstanding amout for a given item is displayed on SIP checkin (if it exists), for example: "You owe $10.00 for this item." - Check that it is not displayed when show_outstanding_amount is disabled. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- + $message .= (" - You owe " . Koha::Number::Price->new( $balance )->format({ with_symbol => 1}) . "."); .= a list? those parenthesis are not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |25815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 [Bug 25815] SIP Checkout: add more information on why the patron is blocked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38073 [Bug 38073] Missing use after Bug 25812 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org