[Bug 34119] New: After redesign, print.css no longer hides things at the top of report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Bug ID: 34119 Summary: After redesign, print.css no longer hides things at the top of report results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org The fistful of selectors in https://git.koha-community.org/Koha-community/Koha/src/commit/a57278f39b8c5b... intend to hide things like the header search and the button to send results to batch modification when SQL reports are printed, but after the redesign they no longer apply. I think that's because staff-global.css, which is referenced after print.css, previously wasn't setting display for them, and now for most it does. It can be fixed with my favorite CSS hammer, !important, but I've been told that's not the only hammer which exists. Is there something else we should do instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 29979 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 152775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152775&action=edit Bug 34119 - Use !important to make print.css beat staff-global.css at hiding SQL report cruft Test plan: 1. Run an SQL report (or create a simple one like "select itemnumber from items" if you don't have any). Shift-reload the results, since you probably have print.css cached. 2. File - Print 3. Make sure the print preview doesn't show the header search box, or the New report, Edit, Run report buttons (the logo, the hamburger menu and the help ? icon are a separate bug). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |phil@chetcolibrary.org --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- I should know better than to ask a question in any form other than a patch :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Should we hide the other elements on the page that would be unwanted when printing? The Koha logo and help link still appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- At the time I wrote it, this seemed like the simplest possible SO+PQA+backport patch to keep us from wasting a third of a sheet of paper any time someone prints a report, and then I was going to reopen cait's bug 29979 to deal with the problem of .navbar replacing, um, probably several of the selectors in this rule, I'm not sure exactly which, and adding in one for anything new that's not in .navbar. I'm going to be gone until August 1st, and I've already solved the problem for myself in IntranetUserCSS, so if someone wants to take this bug and sort through what selectors have completely disappeared, not just disappeared from reports, and replace them with the new thing, and also fix !important in the same patch, feel free. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #4)
Should we hide the other elements on the page that would be unwanted when printing? The Koha logo and help link still appear.
I'd say so! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Phil Ringnalda from comment #5)
At the time I wrote it, this seemed like the simplest possible SO+PQA+backport patch to keep us from wasting a third of a sheet of paper any time someone prints a report, and then I was going to reopen cait's bug 29979 to deal with the problem of .navbar replacing, um, probably several of the selectors in this rule, I'm not sure exactly which, and adding in one for anything new that's not in .navbar.
I'm going to be gone until August 1st, and I've already solved the problem for myself in IntranetUserCSS, so if someone wants to take this bug and sort through what selectors have completely disappeared, not just disappeared from reports, and replace them with the new thing, and also fix !important in the same patch, feel free.
Can you share your code? Also please don't reopen, almost always better to have a new bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- I copy-pasted this rule, added !important, and added the selector nav. Do we use a <nav> somewhere that it should be printed? Don't know, didn't test or grep. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|phil@chetcolibrary.org |oleonard@myacpl.org Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Better to avoid "In Discussion" unless there is an argument that needs more people to be resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Status|NEW |ASSIGNED Summary|After redesign, print.css |Improve staff interface |no longer hides things at |print stylesheet following |the top of report results |redesign Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 35016 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156798&action=edit Bug 34119: (Preliminary) Run stylelint fixes on print.css This patch corrects errors raised by the new stylelint configuration in print.css. Most of the fixes were made automatically by using the "--fix" option: npx stylelint koha-tmpl/intranet-tmpl/prog/css/print.css --fix Some examples of errors fixed automatically: - Expected indentation of 4 spaces - Unexpected whitespace before ":" - Unexpected unit - Expected single space before "{" - Expected newline after ";" in a multi-line declaration block Errors from use of "!important" have been ignored. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156799&action=edit Bug 34119: Improve staff interface print stylesheet following redesign This patch makes some updates to the staff interface print stylesheet in order to make it work better following the staff interface redesign. To test, apply the patch and clear your browser cache if necessary. In the staff client, go to various pages and view the print preview. The print view should exclude the header navigation, header search, page toolbars and page sidebars. - Pages with tabbed displays should show content from all tabs: e.g. bibliographic details, MARC editor. - In Reports, check that report results print well. - Pages with DataTables should print with table information visible but table controls hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156798|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156813&action=edit Bug 34119: (Preliminary) Run stylelint fixes on print.css This patch corrects errors raised by the new stylelint configuration in print.css. Most of the fixes were made automatically by using the "--fix" option: npx stylelint koha-tmpl/intranet-tmpl/prog/css/print.css --fix Some examples of errors fixed automatically: - Expected indentation of 4 spaces - Unexpected whitespace before ":" - Unexpected unit - Expected single space before "{" - Expected newline after ";" in a multi-line declaration block Errors from use of "!important" have been ignored. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156799|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156814&action=edit Bug 34119: Improve staff interface print stylesheet following redesign This patch makes some updates to the staff interface print stylesheet in order to make it work better following the staff interface redesign. To test, apply the patch and clear your browser cache if necessary. In the staff client, go to various pages and view the print preview. The print view should exclude the header navigation, header search, page toolbars and page sidebars. - Pages with tabbed displays should show content from all tabs: e.g. bibliographic details, MARC editor. - In Reports, check that report results print well. - Pages with DataTables should print with table information visible but table controls hidden. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
- Pages with DataTables should print with table information visible but table controls hidden.
- tested patron page with a few checkouts displayed - tested order basket - tested patron search results --- Are those undesirable table controls?: https://pic.infini.fr/wk6zBOFT/RP5P0YA0.webp --- minor findings: - on record detail page, should the content of the descriptions tab be after the list of items? And same for acquisition details. No reliable idea on what is more relevant when printing, mentioning this just in case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156813|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157160&action=edit Bug 34119: (Preliminary) Run stylelint fixes on print.css This patch corrects errors raised by the new stylelint configuration in print.css. Most of the fixes were made automatically by using the "--fix" option: npx stylelint koha-tmpl/intranet-tmpl/prog/css/print.css --fix Some examples of errors fixed automatically: - Expected indentation of 4 spaces - Unexpected whitespace before ":" - Unexpected unit - Expected single space before "{" - Expected newline after ";" in a multi-line declaration block Errors from use of "!important" have been ignored. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156814|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157161&action=edit Bug 34119: Improve staff interface print stylesheet following redesign This patch makes some updates to the staff interface print stylesheet in order to make it work better following the staff interface redesign. To test, apply the patch and clear your browser cache if necessary. In the staff client, go to various pages and view the print preview. The print view should exclude the header navigation, header search, page toolbars and page sidebars. - Pages with tabbed displays should show content from all tabs: e.g. bibliographic details, MARC editor. - In Reports, check that report results print well. - Pages with DataTables should print with table information visible but table controls hidden. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #15)
- Pages with DataTables should print with table information visible but table controls hidden.
- tested patron page with a few checkouts displayed - tested order basket - tested patron search results
---
Are those undesirable table controls?: https://pic.infini.fr/wk6zBOFT/RP5P0YA0.webp
---
I think removing them would be nice, but is probably a page specific change whie this takes care of the general elements. I think maybe we could take a closer look at other pages separately. Also: patron search results has a export
print option on the table that gives nice results :)
minor findings: - on record detail page, should the content of the descriptions tab be after the list of items? And same for acquisition details. No reliable idea on what is more relevant when printing, mentioning this just in case.
They both appear after the item list for me. And it doesn't matter which tab is active before switching to print layout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #18)
I think removing them would be nice, but is probably a page specific change whie this takes care of the general elements. I think maybe we could take a closer look at other pages separately. Also: patron search results has a export > print option on the table that gives nice results :)
Alright, let's go with the current proposal then! :)
minor findings: - on record detail page, should the content of the descriptions tab be after the list of items? And same for acquisition details. No reliable idea on what is more relevant when printing, mentioning this just in case.
They both appear after the item list for me. And it doesn't matter which tab is active before switching to print layout.
My phrasing was weird. I meant that they are indeed after the item list, but should they? (It sounded that like I was suggesting that they should be after. But it's already the case) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #19)
(In reply to Katrin Fischer from comment #18)
I think removing them would be nice, but is probably a page specific change whie this takes care of the general elements. I think maybe we could take a closer look at other pages separately. Also: patron search results has a export > print option on the table that gives nice results :)
Alright, let's go with the current proposal then! :)
minor findings: - on record detail page, should the content of the descriptions tab be after the list of items? And same for acquisition details. No reliable idea on what is more relevant when printing, mentioning this just in case.
They both appear after the item list for me. And it doesn't matter which tab is active before switching to print layout.
My phrasing was weird. I meant that they are indeed after the item list, but should they? (It sounded that like I was suggesting that they should be after. But it's already the case)
That's the sequence in the source code, I think it's correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Bug 34119 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org