[Bug 10222] New: Error when saving Demco label templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 Bug ID: 10222 Summary: Error when saving Demco label templates Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label printing Assignee: cnighswonger@foundations.edu Reporter: oleonard@myacpl.org If you open either of the Demco label templates (loaded by the sample data) and click "save" without making any changes you will get an error: Can't bless non-reference value at C4/Creators/Profile.pm line 92. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u, | |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Confirmed, it comes from installer/data/mysql/en/optional/sample_creator_data.sql It inserts a row into creator_templates with profile_id=13, but no printers_profile is inserted with this profile_id. Chris, could you have a look please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 37976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37976&action=edit Bug 10222 - Error when saving Demco label templates This patch fixes a bug whereby if you open either of the Demco label templates (loaded by the sample data) and click "save" without making any changes you will get an error: Can't bless non-reference value at C4/Creators/Profile.pm line 92. It also fixes another minor bug in the creator sample data. To test: 1. Install all sample data in a clean database. 2. In the label tool, edit either of the Demco label templates. 3. Save the template and observe the error mentioned above. 4. Drop and recreate the database. 5. Apply the patch. 6. Repeate steps 1-3 and note the successful save. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 37976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37976 Bug 10222 - Error when saving Demco label templates Review of attachment 37976: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10222&attachment=37976) ----------------------------------------------------------------- ::: installer/data/mysql/en/optional/sample_creator_data.sql @@ +27,4 @@
LOCK TABLES `printers_profile` WRITE; /*!40000 ALTER TABLE `printers_profile` DISABLE KEYS */; +INSERT INTO `printers_profile` VALUES (1,'Library Laser',1,'Bypass',-2,9,3,0,'POINT','Labels'),(13,'Library Laser',7,'Tray 1',0,0,0,0,'POINT','Labels'),(14,'Library Laser',12,'Tray 2',0,0,0,0,'POINT','Labels'),(16,'Test Printer 01',23,'Test Bin',0,0,0,0,'POINT','Patroncards'),(22,'Library Laser',0,'Tray 3',0,0,0,0,'POINT','Labels');
Why remove 11? Why are the columns not explicitly named? Also, perhaps splitting lines for human readability might be an idea. And maybe INSERT IGNORE? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to M. Tompsett from comment #3)
Why remove 11?
Because it was a mistake from the beginning. (I wrote the original, btw.)
Why are the columns not explicitly named?
Why should they be named?
And maybe INSERT IGNORE?
No need. This is only executed upon a fresh install. Why switch this back to "Needs Signoff?" Did you test it and have it fail? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- 1/ The change should be done for all languages. 2/ I also think it could be better to name the column, to prevent further changes to this table (add new column?) Marked as Failed QA for 1. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org