[Bug 29277] New: Replace the use of jQueryUI tabs on item circulation alerts page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Bug ID: 29277 Summary: Replace the use of jQueryUI tabs on item circulation alerts page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 29226 As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should replace the use of the jQueryUI tabs component on the "Item circulation alerts" page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129696&action=edit Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page This patch replaces jQueryUI tabs on the item circulation alerts page as a simple example to start the process of switching how we implement tabbed interfaces. The patch bumps the Bootstrap version from 3.3.7 to 3.4.1 and adds the tabs component. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> Item circulation alerts. - Confirm that the "Checkout" and "Check-in" tabs look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129696|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 129714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129714&action=edit Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page This patch replaces jQueryUI tabs on the item circulation alerts page as a simple example to start the process of switching how we implement tabbed interfaces. The patch bumps the Bootstrap version from 3.3.7 to 3.4.1 and adds the tabs component. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> Item circulation alerts. - Confirm that the "Checkout" and "Check-in" tabs look correct and work correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Before: https://snipboard.io/HLlery.jpg After : https://snipboard.io/gjpMyc.jpg We are loosing some borders and the tabs are less obvious. Is that expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)
We are loosing some borders and the tabs are less obvious. Is that expected?
No, I think you are seeing cached CSS. Please clear the browser cache and try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 [Bug 29998] Replace the use of jQueryUI tabs on item types administration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30000 [Bug 30000] Replace the use of jQueryUI tabs on the search engine configuration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129714|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130061&action=edit Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page This patch replaces jQueryUI tabs on the item circulation alerts page as a simple example to start the process of switching how we implement tabbed interfaces. The patch bumps the Bootstrap version from 3.3.7 to 3.4.1 and adds the tabs component. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Administration -> Item circulation alerts. - Confirm that the "Checkout" and "Check-in" tabs look correct and work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #4)
(In reply to Jonathan Druart from comment #3)
We are loosing some borders and the tabs are less obvious. Is that expected?
No, I think you are seeing cached CSS. Please clear the browser cache and try again.
Indeed! It was sticky! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 130479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130479&action=edit Screenshot with patch Indeed it works after a refresh of browser cache. Here is a screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30227 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 [Bug 30227] Replace the use of jQueryUI tabs on bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316 [Bug 30316] Replace the use of jQueryUI tabs on MARC detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317 [Bug 30317] Replace the use of jQueryUI tabs on search history page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org