[Bug 12727] New: Patron category filter in batch patron deletion tool is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 Bug ID: 12727 Summary: Patron category filter in batch patron deletion tool is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: abl@biblos.pk.edu.pl QA Contact: testopia@bugs.koha-community.org After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this ctriterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 --- Comment #1 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 30568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30568&action=edit Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Assignee|gmcharlt@gmail.com |abl@biblos.pk.edu.pl Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30568|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30608&action=edit Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30608|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30670&action=edit [PASSED QA] Bug 12727 - Patron category filter in batch patron deletion tool is broken After commit 6973e3b7d50777a147a29f2f3d213a6175c9eb74, patron category filter in batch patron deletion tool (tools/cleanborrowers.pl) doesn't work properly any longer. It's still possible to choose a patron category as selection criterion, but this criterion is being efectivelly ignored on futhers steps. As a result, all patrons (with no check-outs and no outstanding account balance) may get mistakenly deleted when using this tool, despite their respective categories. To test: 1/ apply patch 2/ follow the test plan[s] for Bug 11975 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12727 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jacek! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org