https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 136135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136135&action=edit Bug 30975: Fix framework plugins not working on cloned fields/subfields Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not work on a cloned field/subfield. That is because we rely on jQuery's `.data('events')` to clone event handlers to the cloned elements, and that was removed in jQuery 1.8.0 (I did not confirm but it's possible it continued to work after that thanks to jQuery Migrate) It is apparently still possible to access these event handlers by using `jQuery._data(element, "events")` but here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. Instead, what this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) Only 'click', 'focus' and 'blur' events are listened to now. They are the only ones we use, and the only ones we actually need. Events removed: change, mouseover, mouseout, mousedown, mouseup, mousemove, keydown, keypress, keyup. If you ever need one of those, you can still add event listeners in the 'focus' event handler, and remove them in the 'blur' event handler 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. All framework plugins have been updated 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3544 CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> ---

Do we have to modify the framework in order to test this?

Yes, but I'd say it's no big deal if you cannot do these tests on a plugin if that plugin is always used in a non-repeatable field/subfield. Testing that the plugin still works in its single field should be enough. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136135|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 138318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138318&action=edit Bug 30975: Fix framework plugins not working on cloned fields/subfields Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not work on a cloned field/subfield. That is because we rely on jQuery's `.data('events')` to clone event handlers to the cloned elements, and that was removed in jQuery 1.8.0 (I did not confirm but it's possible it continued to work after that thanks to jQuery Migrate) It is apparently still possible to access these event handlers by using `jQuery._data(element, "events")` but here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. Instead, what this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) Only 'click', 'focus' and 'blur' events are listened to now. They are the only ones we use, and the only ones we actually need. Events removed: change, mouseover, mouseout, mousedown, mouseup, mousemove, keydown, keypress, keyup. If you ever need one of those, you can still add event listeners in the 'focus' event handler, and remove them in the 'blur' event handler 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. All framework plugins have been updated 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD and a MARC21 instance). Replicating the issue for cloned fields/subfields not working * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1. For the BKS framework, edit the subfields for 260 2. For 260$b add the marc21_field_260b.pl plugin 3. Edit an existing record's 260$b: . Remove what is in the field . Start typing the name of a publisher that exists (requires first three letters), for example: O'R (for O'Reilly) or Apr (for Apress) . Select the full name 4. Clone the subfield 5. If you repeat step 3, note that the autocomplete doesn't work 6. Repeat/duplicate the 260 tag and follow steps 3-5 After the patch is applied, flush_memcached, restart_all, clear browser cache, etc., step 5 should now work. I found this Monday Minutes from ByWater Solutions very helpful for coming up with an example of a subfield that could be cloned to replicate the issue - Monday Minutes: Publisher Drop-down in Cataloging (26 July 2021): https://bywatersolutions.com/education/monday-minutes-publisher-drop-down-in... Testing pages that have the MARC editor ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Run the tests as indicated (labeled with letters in the next section) to check the various pages where the MARC editor is used. Except as noted, these should work as expected before and after the patch is applied. Add a new catalog record (addbiblio.pl): 1. Cataloging > New record (select Nooks, Booklets, Workbooks from the drop-down list) 2. Run test D 3. Replicate the issue for cloned fields/subfields Notes: - Cloned subfields don't work before the patch is applied Add a new item to a record (additem.pl) 1. Add a new item to an existing record 2. Run tests A, B, and C 3. These should work before and after the patch is applied Add a new authority record (authorities.pl) 1. Run test E Notes: - I'm not familiar enough with authority records to suggest a subfield and plugin that would replicate the cloning issue Acquisitions - create items when placing an order (neworderempty.pl) 1. Acquisitions > click search for Vendor in the manage orders section, and select 'My Vendor'. 2. Create a new basket with 'placing an order' selected for the 'Create items when' field 3. Select Add to basket and choose 'From a new (empty) record' 4. Run tests A (barcode) and C (date fields) Acquisitions - receiving an order (orderreceive.pl) 1. Acquisitions > click search for Vendor in the manage orders section, and select 'My Vendor'. 2. Create a new basket with 'receiving an order' selected for the 'Create items when' field 3. Close the basket 4. Select Receive shipments for the vendor 5. Enter anything you like for the invoice number and select 'Next' 6. Select 'Receive' for the basket you created 7. Run tests A (barcode) and C (date fields) Tests for plugins that use different types of events ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --A.-- 'focus' event plugin - barcode.pl: 1. Set the system preference autoBarcode to 'generated in the form <year>-0001, <year>-0002. 2. Add a new item for any record. 3. Click on the p - Barcode field 4. Result: it should be populated with the autoBarcode pattern --B.-- 'blur' event plugin - callnumber.pl 1. For the itemcallnumber system preference add 082ab,092ab 2. For the BKS framework, add the callnumber.pl plugin to 952$o 3. Edit any record and add some values to 082$a, 082$b, and 082$c if it doesn't already entries for these subfields 4. Add a new item to the record 5. Result: the 'o - Full call number' field should be populated with the values from 082 --C.-- 'click' events - dateaccessioned.pl: 1. Add a new item to a record 2. Click on any of the date fields, such as d - date acquired or w - Price effective from 3. Result: date picker pop-up should appear, selecting a date should populate the field --D.-- 'click' events - new cataloguing record: 1. Add a new catalogue record for the BKS framework 2. Click in the fields for 000, 005, and 008 3. Result: these should be populated with values --E.-- 'click' events - new authority record: 1. Add a new Personal Name authority record 2. Click in the fields for 000, 003, 005, 008, and 0040 3. Result: these should be populated with values -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am worried by the scope of this one. The changes to every plugin disqualifies this patch for backporting, especially because of the breaking changes:

This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) Only 'click', 'focus' and 'blur' events are listened to now. They are the only ones we use, and the only ones we actually need. Events removed: change, mouseover, mouseout, mousedown, mouseup, mousemove, keydown, keypress, keyup. If you ever need one of those, you can still add event listeners in the 'focus' event handler, and remove them in the 'blur' event handler 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. All framework plugins have been updated 3) Event handlers do not pollute the global scope anymore

We do have those custom framework plugins and I know other libraries do as well. Also not sure about removing events - some libraires may have used them and is there a strong reason to remove? Could we imagine a less invasive fix to the problem, that could also be applied to stable releases? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this has been kind of one of the first 'plugin' infrastructures Koha had, so I think we should keep people in mind that have written their own. Breaking changes are not always avoidable, but we should provide some documentation/warning in release notes. I'd love Marcel to have a look here, as he has worked on improving plugins in the past. Julian - could you maybe provide the patch for the older versions soon? I'd really love to see this fixed for libraries using the plugin for 7xx linking etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Here's the patch for 22.05 (which is the only release affected by this I believe). Much simpler, but please note that it does not include all fixes made to individual plugins in the main patch. Some plugins will "work" but will update the wrong field (ex: unimarc_field_115a.pl) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 140810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140810&action=edit Bug 30975: Fix framework plugins on cloned fields/subfields This patch uses the internal method jQuery._data to retrieve and clone all events attached to a cloned field/subfield. It's intended for stable releases only, so they can stay compatible with existing plugins Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #15 from David Nind <david@davidnind.com> --- Also, I seemed to have mucked up the 22.05 attachments, and I'm not sure how to fix... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 [Bug 32813] Fix cataloguing/value_builder/barcode.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 [Bug 32815] Fix cataloguing/value_builder/callnumber.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32819 [Bug 32819] Fix cataloguing/value_builder/stocknumberam123.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 [Bug 32821] Fix cataloguing/value_builder/stocknumber.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32823 [Bug 32823] Fix cataloguing/value_builder/unimarc_field_100_authorities.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32825 [Bug 32825] Fix cataloguing/value_builder/unimarc_field_105.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32827 [Bug 32827] Fix cataloguing/value_builder/unimarc_field_110.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32829 [Bug 32829] Fix cataloguing/value_builder/unimarc_field_115b.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831 [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833 [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32835 [Bug 32835] Fix cataloguing/value_builder/unimarc_field_122.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32837 [Bug 32837] Fix cataloguing/value_builder/unimarc_field_123d.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32839 [Bug 32839] Fix cataloguing/value_builder/unimarc_field_123f.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32841 [Bug 32841] Fix cataloguing/value_builder/unimarc_field_123i.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32843 [Bug 32843] Fix cataloguing/value_builder/unimarc_field_124a.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32845 [Bug 32845] Fix cataloguing/value_builder/unimarc_field_124c.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32847 [Bug 32847] Fix cataloguing/value_builder/unimarc_field_124e.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32849 [Bug 32849] Fix cataloguing/value_builder/unimarc_field_124g.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32851 [Bug 32851] Fix cataloguing/value_builder/unimarc_field_125a.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32853 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32855 [Bug 32855] Fix cataloguing/value_builder/unimarc_field_126b.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32857 [Bug 32857] Fix cataloguing/value_builder/unimarc_field_127.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32859 [Bug 32859] Fix cataloguing/value_builder/unimarc_field_128b.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32861 [Bug 32861] Fix cataloguing/value_builder/unimarc_field_130.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32863 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32863 [Bug 32863] Fix cataloguing/value_builder/unimarc_field_140.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 [Bug 32865] Fix cataloguing/value_builder/unimarc_field_146a.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 [Bug 32867] Fix cataloguing/value_builder/unimarc_field_146i.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 [Bug 32877] Fix cataloguing/value_builder/upload.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- I split the patch into smaller ones (one patch per plugin, see "Depends on"). That should be easier to test and push. Leaving this one as BLOCKED until all other patches are pushed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This introduces a breaking release notes| |change for users that have | |custom framework plugins: | |the first parameter of | |javascript functions is now | |always an Event object. | |Before that it was possible | |to receive a string | |containing an HTML ID. This | |ID is available in | |`event.data.id` (assuming | |the first parameter is | |named `event`) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32817 Depends on|32817 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32865 Depends on|32865 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 [Bug 32865] Fix cataloguing/value_builder/unimarc_field_146a.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32866 Depends on|32866 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32877 Depends on|32877 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 [Bug 32877] Clean up cataloguing/value_builder/upload.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 146817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146817&action=edit Bug 30975: Call preventDefault only for click events -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to David Nind from comment #22)

I think I may have made a mistake in testing the bugs I have signed off so far.

I had not been testing cloning subfields, until I came to bug 32830 - unimarc_field_116.pl. (Up until then I hadn't been making subfields repeatable).

I think you are doing fine (and thank you for testing by the way). Plugins on cloned subfields are not supposed to be fixed until all patches, including bug 30975's patches, are pushed. In all "Depends on" bugs, framework plugins should work the same before and after the patch. So as long as the bug on cloned subfield also exists before applying the patch (which should be the case), it's OK -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I tried to test a patch and forgot to check if it had pending dependencies and ended up applying over 9000 dependent bugs and ended up with this one not applying.

Bug 30975: Fix framework plugins not working on cloned fields/subfields

Anyway it's not ready until the dependencies are dealt with. Since it's status is BLOCKED, I'm not changing it and letting the info here for futur. (or in case you want gradual rebases instead of a big one) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32823, which changed state. Bug 32823 Summary: Fix cataloguing/value_builder/unimarc_field_100_authorities.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32823 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32825, which changed state. Bug 32825 Summary: Fix cataloguing/value_builder/unimarc_field_105.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32825 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32828, which changed state. Bug 32828 Summary: Fix cataloguing/value_builder/unimarc_field_115a.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32835, which changed state. Bug 32835 Summary: Fix cataloguing/value_builder/unimarc_field_122.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32835 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32815, which changed state. Bug 32815 Summary: Fix cataloguing/value_builder/callnumber.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Zeno Tajoli <ztajoli@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ztajoli@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32818 | Depends on| |32818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32867 | Depends on| |32867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32865 | Depends on| |32865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I managed to test and PQA on all but:

- unimarc_field_125.pl (bug 32853) - unimarc_field_126.pl (bug 32856)

These also work in theory, but don't appear to make sense. Some insight would be good. I am missing some plugins in the list - especially almos all marc21* ones. Do we have a way to check which plugins still need updating? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32814, which changed state. Bug 32814 Summary: Fix cataloguing/value_builder/callnumber-KU.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32816, which changed state. Bug 32816 Summary: Fix cataloguing/value_builder/cn_browser.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand@gmail.com --- Comment #28 from Lari Strand <lmstrand@gmail.com> --- We use our custom value builder plugins for adding various keywords from an online vocabulary using dynamically created select2 elements. These patches fixed the issue with plugins not initialising on cloned fields. I needed to change the code so the plugin gets initialised with a click-function, formerly mouseover in the input field. "Events removed: change, mouseover, mouseout, mousedown, mouseup, mousemove, keydown, keypress, keyup. If you ever need one of those, you can still add event listeners in the 'focus' event handler, and remove them in the 'blur' event handler" How would I bring mouseover back as a valid function in code? What kind of performance issues do you mean by "'mouseover' and 'mousemove' are not used and would trigger too much events."? I also received a report that the patch breaks field/subfield cloning on Firefox 78.12.0esr. Apparently the field does not get cloned and the page goes to the top. They've tried to clear the browser cache. Does this make any sense? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> ---

How would I bring mouseover back as a valid function in code? Can you post a link to your plugin ?

What kind of performance issues do you mean by "'mouseover' and 'mousemove' are not used and would trigger too much events."? I admit I did not measure it, but with the new method used here (event delegation), the browser would have to trigger tens of mouse events every time the mouse move inside the editor, which I assumed would introduce perfomance issues.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #32 from Lari Strand <lmstrand@gmail.com> --- These patches seems to break the functionality in barcode generator plugin barcode.pl. I removed the patches and it started generating barcodes again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Lari Strand from comment #33)

(In reply to Lari Strand from comment #32)

...

These patches seems to break the functionality in barcode generator plugin barcode.pl. I removed the patches and it started generating barcodes again.

This problem has been addressed in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813

Do not try to test this patch without all the other patches applied. They are marked as dependencies for a good reason ;) (and the status is "BLOCKED" for this reason as well) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- *** Bug 33744 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Where are we with this? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Looks like there is only two bugs left : bug 32853 and bug 32856. Both blocked because they are apparently not correct regarding UNIMARC. As they are only "refactoring" patches, can we open new bug reports for these problems in order to not block bug 30975 ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #40)

Also can't test if we updated all plugins. David's list on comment 27 shows some missing, for example marc21_linking_section that also works on repeated fields (7xx).

marc21_linking_section does not need to be updated since the JS function already uses its event parameter. A quick grep (git grep '\<function\>' cataloguing/value_builder/ | grep -v '(ev') shows that unimarc_field_125 and unimarc_field_126 are the only ones that do not use their event parameter. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #42 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 34221 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #43 from David Cook <dcook@prosentient.com.au> --- Looks like it's still a problem in master for marc21_field_007.pl and marc21_field_006.pl at the very least. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply --- Comment #44 from David Nind <david@davidnind.com> --- The patches no longer apply: Apply? [(y)es, (n)o, (i)nteractive] Y Applying: Bug 30975: Fix framework plugins on cloned fields/subfields Applying: Bug 30975: Fix framework plugins not working on cloned fields/subfields Using index info to reconstruct a base tree... M C4/Items.pm M authorities/authorities.pl M koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt M koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt M koha-tmpl/intranet-tmpl/prog/js/additem.js M koha-tmpl/intranet-tmpl/prog/js/cataloging.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/cataloging.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/cataloging.js Auto-merging koha-tmpl/intranet-tmpl/prog/js/additem.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc Auto-merging authorities/authorities.pl Auto-merging C4/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 30975: Fix framework plugins not working on cloned fields/subfields hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-30975-Fix-framework-plugins-not-working-on-clo-2hwhjubx.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #46 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to David Nind from comment #45)

- Comment #27: List of all plugins/value builders and the related bug numbers. It is not clear to me why some don't need updating, but I assume it is because no change is required, and they are not affected. It would be good to get confirmation of this. Your assumption is correct. Though I haven't checked if other plugins have been created/modified recently

- EXAMPLE.pl may need updating to reflect the changes from this bug/the refactoring. EXAMPLE.pl correctly uses event.data.id so it does not need to be updated.

- Two dependencies are Failed QA: . Bug 32856 - Fix cataloguing/value_builder/unimarc_field_126.pl . Bug 32853 - Fix cataloguing/value_builder/unimarc_field_125.pl I think they should not be in this state as the issue discussed in not caused by the patches (see bug 32853 comment 6)

Other things:

- This may (or may not) affect those who have developed their own custom plugins. How do we give advance warning of this and make the transition as seamless as possible? I guess this depends a little on whether it is back ported - 23.11 is three months away, it may be some time before those using their own plugins upgrade. I think it's preferable to backport bug 33744 instead of this one as 33744 does not break compatibility. As for the warning, there is one in the "release notes" field. It should be enough, right ?

Regarding the DNA status, I intend to rebase the patches once all dependencies pushed, not before. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32874, which changed state. Bug 32874 Summary: Fix cataloguing/value_builder/unimarc_field_700-4.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146146|0 |1 is obsolete| | Attachment #146817|0 |1 is obsolete| | --- Comment #49 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 158064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158064&action=edit Bug 30975: Fix framework plugins not working on cloned fields/subfields Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not work on a cloned field/subfield. That is because we rely on jQuery's `.data('events')` to clone event handlers to the cloned elements, and that was removed in jQuery 1.8.0 (I did not confirm but it's possible it continued to work after that thanks to jQuery Migrate) It is apparently still possible to access these event handlers by using `jQuery._data(element, "events")` but here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. Instead, what this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found a pre-existing bug in authority and cataloguing editor while testing, but all seemed to still work as before with the patch set applied: Bug 35194 - Javascript error when a repeatable field is repeated In the acquisition module I found a problem: * Activate UseACQFrameworkForBiblioRecords * Crate a new basket, create an order from 'new' * Open the Leader plugin - works * Apply patch, restart_all etc. * Leader plugin no longer opens :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Btw can we change the title of this report now? And move to enh? The clone bug is actually resolved. But this is a good enhancement(!) to simplify and modernize the plugin code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement Summary|Framework plugins do not |Use event delegation for |work on cloned |framework plugins to avoid |fields/subfields |using private jQuery method -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_11_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pablo López Liotti from comment #56)

Hi, i need use the callnumber.pl to auto-complete 952$o with 080$a and 092$a marc fields to make a full item call number.

The ITEMCALLNUMBER syspref holds '080a,092a' value. The 952$o subfield in BKS framework have plugin->callmunber.pl value. I make a biblio record with 080$a = '025' and 092$a = 'T 345' values.

Executing additems.pl only it shows '025' in the form.

Any ideas?

Thks Pablo

Hi Pablo, this bug is not related to your problem. When in doubt: ask on the mailing list or in the IRC chat first :) But: as stated in the system preference description, only the first field listed with a value will be used. So the preference is behaving as expected. You can currently not combine contents from different fields. You could file a new and separate enhancement request bug for this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #59 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi :) (In reply to Pablo López Liotti from comment #58)

This enhancemente will be most useful for many people.

Here is the place to open a new ticket: https://bugs.koha-community.org/bugzilla3/enter_bug.cgi Here is documentation about opening tickets, mostly centered on proper bugs (stuff broken) but still has some info about enhancements/new feature requests: https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm confused.. what's the current state of this.. what needs doing to get it over the finish line? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #63 from Julian Maurice <julian.maurice@biblibre.com> --- The bug found by Katrin in comment 51 needs to be fixed too -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158064|0 |1 is obsolete| | --- Comment #64 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 170499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170499&action=edit Bug 30975: Fix framework plugins not working on cloned fields/subfields Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not work on a cloned field/subfield. That is because we rely on jQuery's `.data('events')` to clone event handlers to the cloned elements, and that was removed in jQuery 1.8.0 (I did not confirm but it's possible it continued to work after that thanks to jQuery Migrate) It is apparently still possible to access these event handlers by using `jQuery._data(element, "events")` but here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. Instead, what this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #66 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased + fix for comment 51 Back to NSO -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170499|0 |1 is obsolete| | --- Comment #68 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171513&action=edit Bug 30975: Fix framework plugins not working on cloned fields/subfields Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not work on a cloned field/subfield. That is because we rely on jQuery's `.data('events')` to clone event handlers to the cloned elements, and that was removed in jQuery 1.8.0 (I did not confirm but it's possible it continued to work after that thanks to jQuery Migrate) It is apparently still possible to access these event handlers by using `jQuery._data(element, "events")` but here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. Instead, what this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #70 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebase to fix a minor conflict -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #72 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- A few quick observations: 856$u Upload does not respond anymore Had some issues with dateaccessioned and cloning it in the normal editor (unusual of course). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #74 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Any more needed here? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171514|0 |1 is obsolete| | --- Comment #76 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175433&action=edit Bug 30975: Fix framework plugins on acqui/neworderempty.pl Test plan: - Activate UseACQFrameworkForBiblioRecords - Make sure you have an ACQ cataloguing framework that uses at least one plugin - Create a new basket, create an order from 'new' - Verify that framework plugins work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175432|0 |1 is obsolete| | --- Comment #78 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175435&action=edit Bug 30975: Use event delegation for framework plugins This is to avoid using private jQuery method _data. Here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. What this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175434|0 |1 is obsolete| | --- Comment #80 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175437&action=edit Bug 30975: Fix upload plugin The upload plugin button has no 'buttonDot' class (unlike other plugins buttons) so its click event were not listened to. This patch fix the CSS selector in order to listen on click events for all plugins buttons -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #82 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Julian Maurice from comment #0)

Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not work on a cloned field/subfield. [...] but it's possible it continued to work after that thanks to jQuery Migrate)

Is there something to test that will be fixed by these patches? Or is this strictly a refactoring/cleanup? It seems framework plugins did not work at some point but then they worked? Or is there still a scenario where the jquery upgrade caused a regression? On main. I found a field that had a plugin and both the original and a clone worked. Removing jquery migrate prevents the editor from loading so I couldn't go further this way. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #84 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Julian Maurice from comment #83)

(In reply to Victor Grousset/tuxayo from comment #82)

...

Is there something to test that will be fixed by these patches? Or is this strictly a refactoring/cleanup? At the beginning this was about a bug but the bugfix was moved to bug 33744. Now only the refactoring remains.

Looking here again. We really should get this in now.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175435|0 |1 is obsolete| | --- Comment #85 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177612&action=edit Bug 30975: Use event delegation for framework plugins This is to avoid using private jQuery method _data. Here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. What this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175437|0 |1 is obsolete| | --- Comment #87 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177614&action=edit Bug 30975: Fix upload plugin The upload plugin button has no 'buttonDot' class (unlike other plugins buttons) so its click event were not listened to. This patch fix the CSS selector in order to listen on click events for all plugins buttons Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #89 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177616&action=edit Bug 30975: (QA follow-up) Improve copyright and author line This fundamental improvement may well be reflected in those lines. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #91 from David Cook <dcook@prosentient.com.au> --- I'll take a look shortly especially on 'acquisition (neworderempty/orderreceive) and batchmod'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177612|0 |1 is obsolete| | --- Comment #92 from David Cook <dcook@prosentient.com.au> --- Created attachment 177719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177719&action=edit Bug 30975: Use event delegation for framework plugins This is to avoid using private jQuery method _data. Here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. What this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177614|0 |1 is obsolete| | --- Comment #94 from David Cook <dcook@prosentient.com.au> --- Created attachment 177721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177721&action=edit Bug 30975: Fix upload plugin The upload plugin button has no 'buttonDot' class (unlike other plugins buttons) so its click event were not listened to. This patch fix the CSS selector in order to listen on click events for all plugins buttons Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177616|0 |1 is obsolete| | --- Comment #96 from David Cook <dcook@prosentient.com.au> --- Created attachment 177723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177723&action=edit Bug 30975: (QA follow-up) Improve copyright and author line This fundamental improvement may well be reflected in those lines. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This introduces a breaking |**This introduces a release notes|change for users that have |breaking change for users |custom framework plugins: |that have custom framework |the first parameter of |plugins:** the first |javascript functions is now |parameter of JavaScript |always an Event object. |functions is now always an |Before that it was possible |Event object. Before that |to receive a string |it was possible to receive |containing an HTML ID. This |a string containing an HTML |ID is available in |ID. This ID is available in |`event.data.id` (assuming |`event.data.id` (assuming |the first parameter is |the first parameter is |named `event`) |named `event`) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177719|0 |1 is obsolete| | --- Comment #99 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 178721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178721&action=edit Bug 30975: Use event delegation for framework plugins This is to avoid using private jQuery method _data. Here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. What this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.