[Bug 34726] New: Clicking the title of a record in cart creates URL with duplicate query strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 Bug ID: 34726 Summary: Clicking the title of a record in cart creates URL with duplicate query strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org If you click a title in the OPAC cart, it will create a URL like the following: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=114?biblionum... This is because of competing functionality in the template and the Javascript. The output of the following "biblio_a_href" is fed into "openBiblio". koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc [% BLOCK biblio_a_href -%] [%- IF Koha.Preference('BiblioDefaultView') == 'marc' -%] [%- SET this_biblio_href = "/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=" -%] [%- ELSIF Koha.Preference('BiblioDefaultView') == 'isbd' -%] [%- SET this_biblio_href = "/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=" -%] [%- ELSE -%] [%- SET this_biblio_href = "/cgi-bin/koha/opac-detail.pl?biblionumber=" -%] [%- END -%] [%- this_biblio_href | url %][% biblionumber | url -%] [%- END %] koha-tmpl/opac-tmpl/bootstrap/js/basket.js function openBiblio(dest,biblionumber) { var openerURL = dest + "?biblionumber=" + biblionumber; opener.document.location = openerURL; opener.focus(); } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34725 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34725 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Since openBiblio is only used in opac-basket.tt, I think we should change how it works. It's an easy enough change to make. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725 [Bug 34725] Remove use of onclick for OPAC cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Note that the duplicate query strings don't create a functional problem, but it's still wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |bosse@gustavsson.one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Sometimes I forget just how many bug reports I've opened 🤣 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org