[Bug 26389] New: OPAC renewal failure due to automatic renewal does not have a failure message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Bug ID: 26389 Summary: OPAC renewal failure due to automatic renewal does not have a failure message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: - Check out an auto-renewing item to a patron - confirm in circ rules that the rule allows at least one renewal - log into OPAC, confirm your summary shows item is scheduled for auto-renewal - click Renew All - Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 109685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109685&action=edit Bug 26389: Add auto renewal error to opac-user.tt Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All 5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons 6 Apply patch 7 Repeat 3-5 8 See appropriate error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- System preference OpacRenewalAllowed must be on "Allow" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Lucas Gass from comment #1)
Created attachment 109685 [details] [review] Bug 26389: Add auto renewal error to opac-user.tt
Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All
I was able to display "Renew All" when item is in auto-renewal. But one can run directly the URL to simulate it : /cgi-bin/koha/opac-renew.pl?from=opac_user&item=<itemnumber>&borrowernumber=<borrowernumber> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109685|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110892&action=edit Bug 26389: Add auto renewal error to opac-user.tt Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All 5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons 6 Apply patch 7 Repeat 3-5 8 See appropriate error Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110892|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111459&action=edit Bug 26389: Add auto renewal error to opac-user.tt Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All 5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons 6 Apply patch 7 Repeat 3-5 8 See appropriate error Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I can't reproduce this in 19.11.x. Clicking Renew All doesn't do anything at all - no error. not backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org