[Bug 27395] New: Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Bug ID: 27395 Summary: Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you have set up the cronjobs for deleting unverified and "unfinished" opac self registrations, a wrong setting in the PatronSelfRegistrationDefaultCategory system preference can lead to accidental deletion of a lot of your patrons. This will happen if you enter one of your regular patron category codes instead of using a specific one for self registrations. It will then delete all patrons that have registere more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago. This is also a complete deletion, not moving the data to deletedborrowers, making it even harder to fix the mistake. I think it would be great to add a hint or warning about this to the system preference description. It currently reads: Use the patron category code ____ as the default patron category for patrons registered via the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |eden.bacani@gmail.com |ity.org | Status|NEW |ASSIGNED CC| |eden.bacani@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #1 from Eden <eden.bacani@gmail.com> --- Created attachment 115364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115364&action=edit Bug 27395: Add warning to PatronSelfRegistrationDefaultCategory. Test Plan 1. Check that warning message appears under PatronSelfRegistrationDefaultCategory when searched for in system preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Hi Eden. A slight wording change. Current proposed wording: WARNING: If user enters one of there regular patron category codes instead of using a specific one for self registrations, some patrons may be accidentally deleted. Suggested wording: WARNING: If a regular patron category code is used instead of a specific code for self registration, some patrons may be deleted if cronjobs are setup to delete unverified and unfinished OPAC self registrations. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #3 from David Nind <david@davidnind.com> --- I have read this again, and have come up with some alternative wording: WARNING: Do not use a regular patron category code for self registration. If the misc/cronjobs/cleanup_database.pl cronjob is setup to delete unverified and unfinished OPAC self registrations, it may result in the permanent and unrecoverable deletion of all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago. As this was an academy bug, I'm happy to do a follow up patch, or amend. It's a bit long, but the consequence of changing this system preference to a regular patron category code seems quite major. Also, is "it may result" correct? That is, rather than "it may result" in deletion, it will result in deletion? Or are there other factors involved? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It had quite severe results here, so I am in favor of warning that is hard to ignore. It will delete if the cron is set up according to the delay configured. So unless the delay is very high, deleting patrons is a very sure thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 115734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115734&action=edit Bug 27395: Add a warning to PatronSelfRegistrationDefaultCategory This patch adds a warning to the PatronSelfRegistrationDefaultCategory system preference to not use a regular patron category for self registration. If a regular patron category code is used and the cleanup_database cronjob is setup to delete unverified and unfinished OPAC self registrations, it permanently and and unrecoverably deletes all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago. It also removes unnecessary apostrophes at the end of two self registration and modification system preference descriptions. Test plan: 1. Apply the patch. 2. Check that the warning message for the PatronSelfRegistrationDefaultCategory system preference is clear and makes sense. 3. Sign off! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115364|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Comment on attachment 115364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115364 Bug 27395: Add warning to PatronSelfRegistrationDefaultCategory. I amended the commit message and updated the warning to: WARNING: Do not use a regular patron category for self registration. If the misc/cronjobs/cleanup_database.pl cronjob is setup to delete unverified and unfinished OPAC self registrations, it will permanently and unrecoverably delete all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115734|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115846&action=edit Bug 27395: Add a warning to PatronSelfRegistrationDefaultCategory This patch adds a warning to the PatronSelfRegistrationDefaultCategory system preference to not use a regular patron category for self registration. If a regular patron category code is used and the cleanup_database cronjob is setup to delete unverified and unfinished OPAC self registrations, it permanently and and unrecoverably deletes all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago. It also removes unnecessary apostrophes at the end of two self registration and modification system preference descriptions. Test plan: 1. Apply the patch. 2. Check that the warning message for the PatronSelfRegistrationDefaultCategory system preference is clear and makes sense. 3. Sign off! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a warning release notes| |to the | |PatronSelfRegistrationDefau | |ltCategory system | |preference to not use a | |regular patron category for | |self registration. | | | |If a | |regular patron category | |code is used and the | |cleanup_database cronjob is | |setup | |to delete unverified | |and unfinished OPAC self | |registrations, it | |permanently and | |and | |unrecoverably deletes all | |patrons that have | |registered more than | |PatronSelfRegistrationExpir | |eTemporaryAccountsDelay | |days ago. | | | |It also removes | |unnecessary apostrophes at | |the end of two self | |registration | |and | |modification system | |preference descriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am wondering how librarians moved the selfreg users out of the default selfreg category My feeling is that the first part of the WARNING is ok, but the second one (about the cronjob) is confusing and add too much info "WARNING: DON'T DO IT" is enough imo Should not we add a warning on the patron's detail page, like "This patron has the temporary SELFREG category"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
I am wondering how librarians moved the selfreg users out of the default selfreg category My feeling is that the first part of the WARNING is ok, but the second one (about the cronjob) is confusing and add too much info
I think the second part of the warning is helpful and gives context on why they should not use a 'regular' category.
Should not we add a warning on the patron's detail page, like "This patron has the temporary SELFREG category"?
Indeed, a warning that 'patron will be deleted in x days (based on the pref) would be an excellent enhancement on another bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 to what Nick said. I think it's nicer to explain than just forbid. In my experience that is less likely to be ignored :) I have filed a new bug for Jonathan's suggestion: Bug 27564 - Add a hint to patron records that still use the self registration patron category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27564 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #12)
Enhancement not pushed to 20.11.x
Hi Frido, could you please reconsider this one? We had a library hurt badly by this one and I'd like to see others not run into it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #13)
(In reply to Fridolin Somers from comment #12)
Enhancement not pushed to 20.11.x
Hi Frido, could you please reconsider this one? We had a library hurt badly by this one and I'd like to see others not run into it.
OK I'm on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03Pushed to released in| |20.11.x for 20.11.03 Status|Pushed to master |Pushed to stable --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 I had to review a bit the patch, 20.11.x does not have links preferences in .pref files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03Pushed to |21.05.00,20.11.03 released in|20.11.x for 20.11.03 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #15)
Pushed to 20.11.x for 20.11.03
I had to review a bit the patch, 20.11.x does not have links preferences in .pref files.
Thx Frido and sorry for the extra work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09. I have also lived in fear of someone inadvertently deleting a lot of patrons with this syspref :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, Manual | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Noticed this warning just recently. What is the suggested work flow here then? Should every registered patron be moved to another category? Cant this be done more intelligently? We are using the verification step too. So why should we remove patrons from borrowers table? If they do not accept, they are just in some temporary table? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> ---
Should every registered patron be moved to another category?
Yes, that's the intended workflow.
Cant this be done more intelligently?
The assumption among libraries I've worked with is that staff need to manually verify validity of the account, which generally means physically checking some proof of address. In theory, one could automate the category change using the update_patrons_category cronjob, but I'm not sure more automated is more intelligently.
We are using the verification step too. So why should we remove patrons from borrowers table? If they do not accept, they are just in some temporary table?
If you're also using the email verification step, then you're correct, those patrons aren't in the borrowers table at all until they click the link in their email. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe that for reasons of data privacy and such libraries often still require that something is signed in order to finish the registration process. The suggestion with update_patrons_category is a good one I think if you want to automate the process. You could also just NOT delete the patrons in the temporary category by disabling the cron. Empty pref might also work, not sure there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew Fuerste-Henry from comment #20) Hi Andrew, Thx for your fast reply.
Should every registered patron be moved to another category?
Yes, that's the intended workflow.
We are actually not interested to check each of these accounts (in our special library). We only check patrons that also register with us for a library card and come to our desk. Until now we had no need to change patron category at that time. But running cleanup with 'del-exp-selfreg' would indeed be a disaster.. I still have the idea that this needs more attention. Especially when hearing that several libraries unfortunately did so already. Is putting a warning on an Admin page all we can do? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #21)
I believe that for reasons of data privacy and such libraries often still require that something is signed in order to finish the registration process. The suggestion with update_patrons_category is a good one I think if you want to automate the process. You could also just NOT delete the patrons in the temporary category by disabling the cron. Empty pref might also work, not sure there.
As long as you dont add the specific flag, you are safe. But I do no longer feel so safe as I did :) Will open up a new report to think about some solution out of here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28943 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- So bug 28943. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org