https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76066&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days and item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76066|0 |1 is obsolete| | Attachment #76067|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76068&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days and item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martha Fuerst <mfuerst@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst@hmcpl.org --- Comment #6 from Martha Fuerst <mfuerst@hmcpl.org> --- Tested - works fine for me! Signed off - Martha Fuerst -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76065|0 |1 is obsolete| | Attachment #76068|0 |1 is obsolete| | Attachment #76069|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77302&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77304&action=edit Bug 20912: Update schema file Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply - please rebase! (might need some more XSS filters) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81142&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days and item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting here with QA script and code review: 1) QA Script FAIL t/db_dependent/Circulation.t OK critic OK forbidden patterns OK git manipulation OK pod FAIL spelling calulated ==> calculated OK valid FAIL t/db_dependent/Koha/ItemTypes.t OK critic OK forbidden patterns OK git manipulation OK pod FAIL spelling calulated ==> calculated OK valid 2) Code review 2.1) <span class="hint">This fee is charged a checkout/renewal time for each day between the checkout/renewal date and due date.</span> ==> charged at... 2.2) Why the check on notforloan? What if the notforloan is overriden? + <td> + [% UNLESS ( itemtype.notforloan ) %] + [% itemtype.rental_charge_daily | $Price %] + [% END %] + </td> 3) Tests Circulation.t needs to be updated to run 120 tests (not 119) There is a new warn in the other tests: t/db_dependent/Koha/ItemTypes.t .. 23/25 Use of uninitialized value in string eq at /home/vagrant/kohaclone/Koha/ItemType.pm line 43. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed 1) and the first part of 3). Still needs some love :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81772&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days and item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81774&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81778&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd like to see some tests for various combinations of process_fee, rentalcharge and rental_charge_daily before passing this. Looking at the code there seems to be a little disparity between charging the amount returned by GetIssuingCharges followed by a second charge calculated using rental_charge_daily.. sometimes it looks like a combined charge, sometimes it looks like two charges and sometimes two charges with the second change also being a combined charge. Hence the asking for a few more tests ;) Also.. i think I'd prefer that the calculation was folded into GetIssuingCharges myself.. it seems somewhat fraught with peril to be duplicating this code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I have a few remarks: my ($rentalCharge) = GetIssuingCharges( $item->{'itemnumber'}, $patron->borrowernumber ); + my $itemtype = Koha::ItemTypes->find( $item->{itype} ); # GetItem sets effective itemtype + $rentalCharge += $itemtype->calc_rental_charge_daily( { from => dt_from_string(), to => $duedate } ); This doesn't look right, shouldn't it be either a fixed charge or the daily calculated one but not both?? If it was two different charges, we might better have separate offsets for them, right? I would remove any fee calculation from Koha::ItemType (same for using userenv). It should only return the 'daily' charge and let some other class handle the calculation. I've been thinking of my $fee = Koha::Fee->new({ library => $library, patron => $patron, item => $item, datetime_due => $dt }); This is of course out of the scope of this bug, but with that in mind, I concur on Martin's proposal of having GetIssuingCharges do it on this bug. The only concern I have is offsets. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Kyle M Hall from comment #26)

(In reply to Tomás Cohen Arazi from comment #25)

...

I have a few remarks:

my ($rentalCharge) = GetIssuingCharges( $item->{'itemnumber'}, $patron->borrowernumber ); + my $itemtype = Koha::ItemTypes->find( $item->{itype} ); # GetItem sets effective itemtype + $rentalCharge += $itemtype->calc_rental_charge_daily( { from => dt_from_string(), to => $duedate } );

This doesn't look right, shouldn't it be either a fixed charge or the daily calculated one but not both?? If it was two different charges, we might better have separate offsets for them, right?

Yes, a library should be allowed to have a flat fee plus a daily fee if they wish. This patch set already ensures they will have separate offsets.

...

I would remove any fee calculation from Koha::ItemType (same for using userenv). It should only return the 'daily' charge and let some other class handle the calculation.

That's fine by me!

...

I've been thinking of my $fee = Koha::Fee->new({ library => $library, patron => $patron, item => $item, datetime_due => $dt });

This is of course out of the scope of this bug, but with that in mind, I concur on Martin's proposal of having GetIssuingCharges do it on this bug. The only concern I have is offsets.

Integrating this into GetIssuingCharges seems like a step backwards. What if I created Koha::Fees and moved the method to it? What I imagine is basically

my @fees = Koha::Fee->new({ library => $library, patron => $patron, item =>

...

$item, datetime_due => $dt })->get_fees, where the return is a list of Koha::Fee objects. To limit the scope creep, I will only move calc_rental_charge_daily into Fees.pm, and leave the breaking up and moving of the rest of GetIssuingCharges as a later exercise.

What do you think?

I agree. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82195&action=edit Bug 20912: Move calculation to Koha::Fees -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81771|0 |1 is obsolete| | Attachment #81772|0 |1 is obsolete| | Attachment #81773|0 |1 is obsolete| | Attachment #81774|0 |1 is obsolete| | Attachment #81775|0 |1 is obsolete| | Attachment #81778|0 |1 is obsolete| | Attachment #82196|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84412&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84414&action=edit Bug 20912: Update schema file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84416&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84418&action=edit Bug 20912: Move calculation to Koha::Fees -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84420&action=edit Bug 20912 (QA Follow-up): Fix up unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84412|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84570&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84414|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84572&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84416|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84574&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84418|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84576&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84578&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84580&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84582&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84584&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I have given this a thorough testing and added a few qa followups to fix some failing test cases and improve test coverage. I also felt it important to add support for hourly loan periods and as such, I've added a pair of follow-ups to add this. As such, although I'd PQA on all work preceding my own, I've asked Tomas and Kyle to cast their eyes over the followup as a final QA signoff. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84420|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84611&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84613&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84615&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84617&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84619&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84621&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84623&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84625&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84618|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84620|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84622|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #74 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84708&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #76 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84710&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84712&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #80 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84714&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #82 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84716&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #84 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84718&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #86 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84720&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #88 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84722&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #90 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84724&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #91)

Kyle implemented the things we suggested on QA, and Martin and I discussed the changes he made. We are all on the same page about this.

Great, thx! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85292&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85294&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85296&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #100 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85298&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #102 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85300&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #104 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85302&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #106 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85304&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #108 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85306&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #110 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85308&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not strictly a blocker for 14825, but I believe it will cause a requirement to rebase or at least revisit the affected routine for the add_devit/add_credit conversion tree so I'm adding it there to aid my own tracking. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85316&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85292|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85544&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85294|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85546&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85296|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85548&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85298|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85550&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85300|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85552&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85302|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85554&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85304|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85556&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85306|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85558&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85308|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85560&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #135 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Nick Clemens from comment #112)

2 - The OPAC patron summary lists any general rental fees, but does not list the periodic rental fees - ideally I think the patron would have to confirm acceptance of charges before completing the transaction, but warning ahead of time is needed at a minimum - I can file a new bug for confirmation of renewing with rental charges

OK, I understand now.. I'll mark it back to failed qa.. hopefully one of us will get to it some time soon. In short, I think we need to add Koha::Charges::Fees into opac/opac-user.pl to add in predicted renewal fees for a period based fee so that they display in the checkouts table where the user can opt to renew items. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #137 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Yup, nick even showed me a screenshot 😉. It's not obvious though to be fair, it's just a note within renew field of the table. It's says "Fee for item type 'Book': 1.00" - https://snag.gy/MWntYk.jpg -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #138 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #137)

Yup, nick even showed me a screenshot 😉. It's not obvious though to be fair, it's just a note within renew field of the table. It's says "Fee for item type 'Book': 1.00" - https://snag.gy/MWntYk.jpg

I think this was added not too long ago, which might explain it not being well known: Bug 13796 - Alert in OPAC when renewing an item with a rental charge (signed by Kyle :) ) I agree that information/confirmation is needed before charging from a user's point of view, but I think also probably legally in some cases. I remember discussions here about labelling buttons for ordering clearly. Better to be safe. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85543|0 |1 is obsolete| | --- Comment #141 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86140&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85545|0 |1 is obsolete| | --- Comment #143 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86142&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85547|0 |1 is obsolete| | --- Comment #145 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86144&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85549|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86146&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85551|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86148&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85553|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86151&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85555|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86153&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85557|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86155&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85559|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86157&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85561|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86159&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86140|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86244&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86142|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86246&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86144|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86248&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86146|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86250&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86148|0 |1 is obsolete| | --- Comment #169 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86252&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86151|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86254&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86153|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86256&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86155|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86258&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86157|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86260&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86159|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86262&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #181 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86264&action=edit Bug 20912: (QA follow-up) Rebase error corrections The automatic rebase after bug 21206 required a helping hand. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86244|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86282&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86246|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86284&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86248|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86286&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.