[Bug 29760] New: Show patron category in Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Bug ID: 29760 Summary: Show patron category in Holds Queue Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, nick@bywatersolutions.com It would be useful to be able to see a patron's category in the Holds Queue. This would help libraries avoid filling holds placed on bibs with a mix of item types when the patron has 0 allowed holds for that specific item's item type, as in bugs 11350 and 23172 (reservesallowed = 0, but the patron isn't ineligible per hold_allowed). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Text to go in the| |Adds the patron category to release notes| |the holds queue on | |view_holdsqueue.tt Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129047&action=edit Bug 29760: Show patron category on view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category 3. Apply patch 4. Look again, you can now see the patron category in the patron column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the-minh.luong@inlibro.com --- Comment #3 from The Minh Luong <the-minh.luong@inlibro.com> --- (In reply to Lucas Gass from comment #2)
Created attachment 129047 [details] [review] Bug 29760: Show patron category on view_holdsqueue.tt
To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category 3. Apply patch 4. Look again, you can now see the patron category in the patron column
I tested and the patch seems to work according to the test plan. However, I think that it would be better to have a Patron Category column, instead of having the patron category inside the patron column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129047|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129354&action=edit Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129354|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129414&action=edit Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Adds the patron category to |Adds the patron category as release notes|the holds queue on |a new column to Circulation |view_holdsqueue.tt |> Holds queue. Summary|Show patron category in |Show patron category in |Holds Queue |Holds queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129414|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130541&action=edit Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see HTML classes are : + <th class="hq-patroncategory">Patron category</th> + <td class="hq-patroncategory"> + <td class="hq-patron-category">... Is third one with a dash on purpose ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #7)
I see HTML classes are : + <th class="hq-patroncategory">Patron category</th> + <td class="hq-patroncategory"> + <td class="hq-patron-category">...
Is third one with a dash on purpose ?
I think that was a mistake, I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130619&action=edit Bug 29760: (follow-up) Fix class name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org