https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123584&action=edit Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123584|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 123600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123600&action=edit Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123600|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123663&action=edit Bug 28825: Can't edit local cover image for item from details page This patch corrects the markup for local cover images attached to items. The correction allows correct display of an "edit" link when the user clicks an item's cover image and views it in the lightbox-style modal. To test, apply the patch and make sure the "LocalCoverImages" system preference is enabled. - View the details of a bibliographic record in the catalog which has items attached.. - In the table of holdings, click Edit -> Upload image. - Upload an image for the item and return to the bibliographic detail page. - Your image should now be displayed in the holdings table. - Click the image to view it. - In the footer of the modal there is an edit link: "Local cover image (edit). Before this patch the edit link would lead to a missing page. After applying the patch the link should take you to the "Image view" where you have the option of deleting the image or uploading another one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28825 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.