[Bug 27956] New: Catch extended attributes exceptions in controllers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27956 Bug ID: 27956 Summary: Catch extended attributes exceptions in controllers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 27857 proposes to add the (previously skipped) required validation to the Koha::Patron->extended_attributes setter. We need to adjust the callers so they have better handling of this new exceptions: $ git grep '\->extended_attributes(' C4/Auth_with_ldap.pm: $patron->extended_attributes([$attribute->unblessed]); Koha/Patrons/Import.pm: $patron->extended_attributes($patron_attributes); Koha/Patrons/Import.pm: $patron->extended_attributes($patron_attributes); members/memberentry.pl: $patron->extended_attributes($extended_patron_attributes); opac/opac-memberentry.pl: $patron->extended_attributes($attributes); t/db_dependent/Koha/Patron/Modifications.t: $patron_modification->extended_attributes( t/db_dependent/Koha/Patrons.t: $patron_1->extended_attributes($attributes_for_1); t/db_dependent/Koha/Patrons.t: $patron_2->extended_attributes($attributes_for_2); t/db_dependent/Koha/Pseudonymization.t: $patron->extended_attributes($attribute_values); t/db_dependent/Utils/Datatables_Members.t:Koha::Patrons->find( $john_doe->{borrowernumber} )->extended_attributes( t/db_dependent/Utils/Datatables_Members.t:Koha::Patrons->find( $jane_doe->{borrowernumber} )->extended_attributes( t/db_dependent/Utils/Datatables_Members.t:Koha::Patrons->find( $john_smith->{borrowernumber} )->extended_attributes( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27956 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 [Bug 27857] Koha::Patron->extended_attributes skips checks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27956 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27956 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27956 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27957 [Bug 27957] Attributes removed in LDAP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27956 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Bug 27957 takes care of LDAP as we actually found a bug on the current code. The new code won't use ->extended_attributes. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org