[Bug 3195] New: No entry in branchtransfers table causes improper holds processing.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3195 Summary: No entry in branchtransfers table causes improper holds processing. Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: critical Priority: P1 Component: Hold requests AssignedTo: galen.charlton@liblime.com ReportedBy: rch@liblime.com Estimated Hours: 0.0 Change sponsored?: --- Symptoms: * Titles continue to appear in holds queue even after staff initiates a transfer to fill a hold. * If staff checks in an item on the hold shelf at the source branch, they should be prompted (again) to send the item to the destination branch. They are not. * Patron details page 'On Hold' tab shows two conflicting messages: * Item is waiting Item hasn't been transfered yet from (sourcebranch) * (also note typo in template). * Detail page for the title, in the holds tab, shows status of Waiting (but the item is actually still in transit), shows " Itembeing transfered to" (again, sic) with no destination branch, and "No Barcode". Cause: * looks like call to C4::Circulation::ModItemTransfer in C4::Reserves is the culprit, since this sub was moved to C4::Items. patch on the way; requires further testing to ensure there's not more going on. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3195 --- Comment #1 from Ryan Higgins <rch@liblime.com> 2009-05-07 02:54:15 --- More here: after fixing the bad function call, we see that the sub that is responsible for initiating the transfer GetOtherReserves : sub GetOtherReserves { my ($itemnumber) = @_; my $messages; my $nextreservinfo; my ( $restype, $checkreserves ) = CheckReserves($itemnumber); if ($checkreserves and $restype ne "Waiting" ) { However, CheckReserves() returns 'Waiting' if reserves.priority==0. And we have a zero priority after a branch transfer is initiated, but reserves.found is still NULL. A quick git blame : 257a439d C4/Reserves.pm (Nahuel ANGELINETTI 2009-03-10 15:28:17 +0100 366) if ($checkreserves and $restype ne "Waiting" ) { commit message : (bug #3025) multiple check-in of a multiple times reserved item go wrong This patch check that an item is not "Waiting" before do something in GetOtherReserves(because is the item is waiting, we don't need to do something). So this patch should be reverted and another fix for bug 3025 needs to be found. (Also apply patch to fix the call to ModItemTransfer) -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3195 Ryan Higgins <rch@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |3025 -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3195 Ryan Higgins <rch@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 |PATCH-Sent -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3195 --- Comment #2 from Galen Charlton <galen.charlton@liblime.com> 2009-05-08 16:20:47 --- Patch pushed. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3195 Cookie Wolfrom <cookie.wolfrom@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cookie.wolfrom@liblime.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3195 Deborah <zingarde@oplin.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zingarde@oplin.org Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠liblime.com