[Bug 30221] New: Make the tables on opac-user.tt column configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Bug ID: 30221 Summary: Make the tables on opac-user.tt column configurable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org There are several tables on opac-user.tt that would benefit from being column configurable. ( check-outs, overdues, charges, holds, article requests ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |arthur.suzuki@biblibre.com Assignee|oleonard@myacpl.org |arthur.suzuki@biblibre.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16759 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 172214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172214&action=edit Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/arthur.s | |uzuki/Koha/-/commits/bug302 | |21 --- Comment #2 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- We had a request from Lyon 2 Uni to make checkouts, overdues, holds and relative's issues configurable but I've just seen this bug so attached my patch to it instead of creating a new bug. Didn't handled the charges and article requests pages though, shall we make a followup to do handle those? Also I guess a couples of system preferences are made obsolete if the table is configurable, like "OPACFinesTab"... shall we make a followup patch to remove this? It probably need a closer look to see if thoses are not used somewhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This is missing Recalls, Article requests, Clubs, Credits, and Charges tables. They should all be configurable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Lucas Gass from comment #3)
This is missing Recalls, Article requests, Clubs, Credits, and Charges tables. They should all be configurable.
Hi Lucas, maybe we can make this small improvement go through and file a linked bug for any other tables which needs to go to table settings? Also those other tables are not in opac-user.tt but in opac-account.tt or even includes templates, touching them all in a single bug would increase the risk of conflicting... :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172214|0 |1 is obsolete| | --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 172451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172451&action=edit Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 172452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172452&action=edit Bug 30221: add the checkout branch to the checkouts table on opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 172453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172453&action=edit Bug 30221: made opac-readingrecord.pl table configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 172454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172454&action=edit Bug 30221: clean unused code in opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 172455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172455&action=edit Bug 30221: fix Javascript error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 172456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172456&action=edit Bug 30221: (QA follow-up) perl-tidyness -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Arthur Suzuki from comment #4)
(In reply to Lucas Gass from comment #3)
This is missing Recalls, Article requests, Clubs, Credits, and Charges tables. They should all be configurable.
Hi Lucas, maybe we can make this small improvement go through and file a linked bug for any other tables which needs to go to table settings? Also those other tables are not in opac-user.tt but in opac-account.tt or even includes templates, touching them all in a single bug would increase the risk of conflicting... :(
That's fair. But one more question. I do see the Columns ( gear icon ) button on those OPAC tables. Do we want OPAC users to be able to adjust which columns are visible? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38103 [Bug 38103] Change in default sorting in OPAC checkout history tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Lucas Gass from comment #11)
That's fair. But one more question. I do see the Columns ( gear icon ) button on those OPAC tables. Do we want OPAC users to be able to adjust which columns are visible?
It is possible to disable which columns are visible and/or configurable by opac users by going to the Admin > Tables settings : https://koha-community.org/manual/latest/en/html/administration.html#table-s... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Arthur Suzuki from comment #12)
(In reply to Lucas Gass from comment #11)
That's fair. But one more question. I do see the Columns ( gear icon ) button on those OPAC tables. Do we want OPAC users to be able to adjust which columns are visible?
It is possible to disable which columns are visible and/or configurable by opac users by going to the Admin > Tables settings : https://koha-community.org/manual/latest/en/html/administration.html#table- settings
I'm aware of Table settings. Have a look at other OPAC tables that are column configurable. The OPAC user cannot adjust what columns are visible when viewing the table. (Columns ( gear icon )) Should we not be consistent with this behavior with all OPAC tables? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- I agree that we should not expose the column visibility feature in the OPAC. I think that introduces more complexity for the user than is necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #14)
I agree that we should not expose the column visibility feature in the OPAC. I think that introduces more complexity for the user than is necessary.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 172581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172581&action=edit Bug 30221: (QA follow-up) remove columns settings for OPAC users -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172451|0 |1 is obsolete| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172610&action=edit Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172452|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172611&action=edit Bug 30221: add the checkout branch to the checkouts table on opac-user.pl Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172453|0 |1 is obsolete| | --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172613&action=edit Bug 30221: made opac-readingrecord.pl table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172454|0 |1 is obsolete| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172615&action=edit Bug 30221: clean unused code in opac-user.tt Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172455|0 |1 is obsolete| | --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172616&action=edit Bug 30221: fix Javascript error Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172456|0 |1 is obsolete| | --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172618&action=edit Bug 30221: (QA follow-up) perl-tidyness Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172581|0 |1 is obsolete| | --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172620&action=edit Bug 30221: (QA follow-up) remove columns settings for OPAC users Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- -Signed off, adding a couple notes: 1. I can hide every column. Should there be any that we consider cannot_be_toggled or cannot_be_modified? 2. I can hide the renew column but still seeing buttons for Renew/Renew all. Turning off the OpacRenewalAllowed fixes this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #25 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Lucas Gass (lukeg) from comment #24)
-Signed off, adding a couple notes:
1. I can hide every column. Should there be any that we consider cannot_be_toggled or cannot_be_modified?
2. I can hide the renew column but still seeing buttons for Renew/Renew all. Turning off the OpacRenewalAllowed fixes this.
So maybe a "cannot_be_modified/cannot_be_toggled" flag on the "renew" column? What other columns did you have in mind which should not be configurable? I can make a small follow-up patch to solve this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #26 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 174014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174014&action=edit Bug 30221: (QA follow-up) Fix column "renew" cannot be toggled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #27 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 174015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174015&action=edit Bug 30221: (QA follow-up) add checkout branch information to other tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #28 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 174016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174016&action=edit Bug 30221: (QA follow-up) make holdshistory table configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174014|0 |1 is obsolete| | --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174046&action=edit Bug 30221: (QA follow-up) Fix column "renew" cannot be toggled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174015|0 |1 is obsolete| | --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174047&action=edit Bug 30221: (QA follow-up) add checkout branch information to other tables Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174016|0 |1 is obsolete| | --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174048&action=edit Bug 30221: (QA follow-up) make holdshistory table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Arthur, the follow-ups look good. I am adding my SO line to the last 3 follow-ups. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #33 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thank you Lucas! Very happy to get some more of my patches to Koha :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- KohaTable does not have bKohaColumnsUseNames at the OPAC, this cannot work correctly now. You need bug 26553 and friends. I would recommend to base this patch set on top of it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 [Bug 26553] Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Bug 30221 depends on bug 26553, which changed state. Bug 26553 Summary: Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172610|0 |1 is obsolete| | Attachment #172611|0 |1 is obsolete| | Attachment #172613|0 |1 is obsolete| | Attachment #172615|0 |1 is obsolete| | Attachment #172616|0 |1 is obsolete| | Attachment #172618|0 |1 is obsolete| | Attachment #172620|0 |1 is obsolete| | Attachment #174046|0 |1 is obsolete| | Attachment #174047|0 |1 is obsolete| | Attachment #174048|0 |1 is obsolete| | --- Comment #35 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192154&action=edit Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #36 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192155&action=edit Bug 30221: add the checkout branch to the checkouts table on opac-user.pl Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #37 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192156&action=edit Bug 30221: made opac-readingrecord.pl table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #38 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192157&action=edit Bug 30221: (QA follow-up) perl-tidyness Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #39 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192158&action=edit Bug 30221: (QA follow-up) Fix column "renew" cannot be toggled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #40 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192159&action=edit Bug 30221: (QA follow-up) add checkout branch information to other tables Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #41 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 192160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192160&action=edit Bug 30221: (QA follow-up) make holdshistory table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #42 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Jonathan Druart from comment #34)
KohaTable does not have bKohaColumnsUseNames at the OPAC, this cannot work correctly now.
You need bug 26553 and friends. I would recommend to base this patch set on top of it.
The patch set was conflicting when trying to apply so I've rebased them on top of latest main. Made the changes needed to get it to work with bug 26553 (now in main). QA scripts are happy :) changing status to signed-off since all patches has already been signed by Lucas (but another signoff is always welcome I guess) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- It's better but still not how it works. 1. bKohaColumnsUseNames is not set on the table you modified 2. Columns must be displayed, then you adjust the content and the visibility example: ``` [% IF show_itemtype_column %] <th data-colname="item_type">Requested item type</th> [% END %] ... [% IF show_itemtype_column %] <td>[% some_data %]</td> [% END %] ``` Must be: // Always add the column to the DOM <th data-colname="item_type">Requested item type</th> ... [% IF show_itemtype_column %] <td>[% some_data %]</td> [% ELSE %] // Empty the column, do not leak data <td></td> [% END %] THEN hide the column in the JS part: let itemtype_column = table_settings.columns.find(c => c.columnname == 'item_type'); [% IF !show_itemtype_column %] itemtype_column.is_hidden = 1; itemtype_column.cannot_be_toggled = 1; itemtype_column.force_visibility = 1; [% ELSE %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24364 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #44 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 193361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193361&action=edit Bug 30221: (QA follow-up) make DOM consistent for modified tables Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #45 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Jonathan Druart from comment #43)
It's better but still not how it works.
Hello Jonathan! I've addressed all the comments you made, also had to make a slight modification to sco-main.tt because it uses holds-table.inc as well as opac-user.tt, everything still works as expected (tried with SCO web page). My thoughts after fixing the QA is that some of those sysprefs are made useless by this patch set, this probably needs a further analysis to check which syspref are only used for hiding columns and which ones have more impact on Koha's behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41604 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Lyon 2 University list of Sponsors| | Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192155|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #46 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195830&action=edit Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #47 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195831&action=edit Bug 30221: add the checkout branch to the checkouts table on opac-user.pl Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #48 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195832&action=edit Bug 30221: made opac-readingrecord.pl table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #49 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195833&action=edit Bug 30221: (QA follow-up) perl-tidyness Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #50 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195834&action=edit Bug 30221: (QA follow-up) Fix column "renew" cannot be toggled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #51 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195835&action=edit Bug 30221: (QA follow-up) add checkout branch information to other tables Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #52 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195836&action=edit Bug 30221: (QA follow-up) make holdshistory table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #53 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 195837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195837&action=edit Bug 30221: (QA follow-up) make DOM consistent for modified tables Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195830|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #54 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 196070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196070&action=edit Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #55 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 196071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196071&action=edit Bug 30221: add the checkout branch to the checkouts table on opac-user.pl Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #56 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 196072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196072&action=edit Bug 30221: made opac-readingrecord.pl table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #57 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 196073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196073&action=edit Bug 30221: (QA follow-up) perl-tidyness Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #58 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 196074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196074&action=edit Bug 30221: (QA follow-up) Fix column "renew" cannot be toggled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #59 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 196075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196075&action=edit Bug 30221: (QA follow-up) add checkout branch information to other tables Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #60 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 196076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196076&action=edit Bug 30221: (QA follow-up) make holdshistory table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 --- Comment #61 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 196077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196077&action=edit Bug 30221: (QA follow-up) make DOM consistent for modified tables Sponsored-by: BibLibre Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew.auld@openfifth.co.uk --- Comment #62 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Cool, I like it! Thanks Arthur. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #63 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. TT tags within script tags are no longer allowed 2. IMO this should be on top of bug 41604, but it's still NSO and we need to confirm the behaviour of visibility_condition I would suggest to wait a bit before continuing here, maybe test bug 41604 and confirm that it's working correctly. Let me know if you have any questions! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org