[Bug 12377] New: Add date pickers to serials-edit.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Bug ID: 12377 Summary: Add date pickers to serials-edit.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com There are two date fields when receiving serials on serials-edit.pl, these input should have a calendar widget like other date fields in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28686&action=edit Bug 12377 - Add date pickers to serials-edit.pl There are two date fields when receiving serials on serials-edit.pl, these inputs should have a calendar widget like other date fields in Koha. Test Plan: 1) Apply this patch 2) Recieve a serial 3) Note when clicking on the "Published on" or "Expected on" fields you will now have a calendar popup. Note you can still manually edit the date if you wish to. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 28752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28752&action=edit Bug 12377 - Add date pickers to serials-edit.pl There are two date fields when receiving serials on serials-edit.pl, these inputs should have a calendar widget like other date fields in Koha. Test Plan: 1) Apply this patch 2) Recieve a serial 3) Note when clicking on the "Published on" or "Expected on" fields you will now have a calendar popup. Note you can still manually edit the date if you wish to. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Why did you set the readonly attributes on the second input? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, can I get an answer please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29653&action=edit Bug 12377 [QA Followup] - Remove readonly from input -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
Why did you set the readonly attributes on the second input?
My bad! Followup to fix issue is attached. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28752|0 |1 is obsolete| | Attachment #29653|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29694&action=edit Bug 12377 - Add date pickers to serials-edit.pl There are two date fields when receiving serials on serials-edit.pl, these inputs should have a calendar widget like other date fields in Koha. Test Plan: 1) Apply this patch 2) Recieve a serial 3) Note when clicking on the "Published on" or "Expected on" fields you will now have a calendar popup. Note you can still manually edit the date if you wish to. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29695&action=edit Bug 12377 [QA Followup] - Remove readonly from input Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org