https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83839&action=edit Bug 22119: Add price formatting in more places in circulation This adds some missing Price filters to some places in circulation. To check verify the amount are displayed according to setting of CurrencyFormat (use FR or CH for seeing a change) Use a patron account with no pending fines at the beginning for all tests. 1) - Switch RentalFeesCheckoutConfirmation to "Ask" - Check out an item with a rental charge - Verify message is formatted correctly: Rental charge for this item: ... 2) - Switch RentalsInNoissuesCharge to "Don't include" - Make sure patron has only Rental fines on their account - Check out another item - Verify message is formatted correctly: The patron has unpaid charges for holds, rentals etc ... 3) - Switch BatchCheckouts to "Allow" - Add the patron category of your test patron to BatchCheckoutsValidCategories - Checkout any item - Verify the message in the information column is formatted correctly: The patron has unpaid charges for holds, rentals etc of ... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83839|0 |1 is obsolete| | --- Comment #2 from Jasmine Amohia <jasmineamohia.student@wegc.school.nz> --- Created attachment 83921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83921&action=edit Bug 22119: Add price formatting in more places in circulation This adds some missing Price filters to some places in circulation. To check verify the amount are displayed according to setting of CurrencyFormat (use FR or CH for seeing a change) Use a patron account with no pending fines at the beginning for all tests. 1) - Switch RentalFeesCheckoutConfirmation to "Ask" - Check out an item with a rental charge - Verify message is formatted correctly: Rental charge for this item: ... 2) - Switch RentalsInNoissuesCharge to "Don't include" - Make sure patron has only Rental fines on their account - Check out another item - Verify message is formatted correctly: The patron has unpaid charges for holds, rentals etc ... 3) - Switch BatchCheckouts to "Allow" - Add the patron category of your test patron to BatchCheckoutsValidCategories - Checkout any item - Verify the message in the information column is formatted correctly: The patron has unpaid charges for holds, rentals etc of ... Signed-off-by: Jasmine Amohia <jasmineamohia.student@wegc.school.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83921|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84885&action=edit Bug 22119: Add price formatting in more places in circulation This adds some missing Price filters to some places in circulation. To check verify the amount are displayed according to setting of CurrencyFormat (use FR or CH for seeing a change) Use a patron account with no pending fines at the beginning for all tests. 1) - Switch RentalFeesCheckoutConfirmation to "Ask" - Check out an item with a rental charge - Verify message is formatted correctly: Rental charge for this item: ... 2) - Switch RentalsInNoissuesCharge to "Don't include" - Make sure patron has only Rental fines on their account - Check out another item - Verify message is formatted correctly: The patron has unpaid charges for holds, rentals etc ... 3) - Switch BatchCheckouts to "Allow" - Add the patron category of your test patron to BatchCheckoutsValidCategories - Checkout any item - Verify the message in the information column is formatted correctly: The patron has unpaid charges for holds, rentals etc of ... Signed-off-by: Jasmine Amohia <jasmineamohia.student@wegc.school.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- $Price, $Price, $Price... Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not to push formatting changes to 17.11.x -- You are receiving this mail because: You are watching all bug changes.