http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In result page, |In result page items with | |negative notforloan are | |available -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13145&action=edit Proposed patch Small patch. Test with an item with notforloan < 0. Without patch, it is available. With patch, it is unavailable and notforloan description is displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13145|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13147&action=edit [SIGNED-OFF] Bug 8996: In result page items with negative notforloan are available Signed-off-by: Owen Leonard <oleonard@myacpl.org> --- Before --- 4 items, 2 available: Athens [YA Taylor] (2) Circulating 2 unavailable: Athens [YA Taylor] Download (1) Circulating The Plains [YA Taylor] Staff Collection (1) Circulating --- After --- 4 items, 1 available: Athens [YA Taylor] (1) Circulating 3 unavailable: Athens [YA Taylor] Ordered (1) Circulating Athens [YA Taylor] Download (1) Circulating The Plains [YA Taylor] Staff Collection (1) Circulating -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: I would agree with your second adjustment on line 1840 (removing the >0 condition, including negative notforloan). I am not sure about your first adjustment on line 1802 (changing ==-1 to <0 ). As I understand, a negative notforloan value does not immediately imply that the item is on order. Historically, the value of -1 means on order, although someone could change or remove the authvalue. (In that case he would be hindered by the hardcoded -1 tests in code..) But where do we say that -2 means on order too? Please clarify or correct me where my conclusion seems wrong. Changing status to reflect need of clarification. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #5)

I would say yes, I found several places in actual code indicating that all negative notforloan values mean "On order" :

Well, enough to convince me. Will send a mail to Nicole asking if this is already documented somewhere too. Status to Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8996 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.