http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18191&action=edit Proposed patch See commit message. I know there is a work on QueryParser but this patch is very small. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Trying to test, but Test plan : - Desactivate all searching sysprefs. Which ones? - Create a new index called "ansa" number 8999 into bib1.att, ccl.properties and records.abs How? (I mean, what's the syntax on each file?, you have an example?) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18191|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21297&action=edit [SIGNED-OFF] Bug 10271 - An index containing ns or nb does not work When an index does not contain a structure part, the structure "wrdl" is automatically added and a structure is mandatory to build search query (to convert ':' into '='). But the code that tests that the structure is not already defined looks in entire index string : $index =~ /(st-|phr|ext|wrdl|nb|ns)/ It should look for a comma followed by a structure and in the case of "nb" and "ns" look for an exact match. The consequence is that an index containing ns or nb or phr or etc does not work. This patch modifies the regexp for this part and other parts looking at structures into index. Test plan : - Desactivate all searching sysprefs. - Create a new index called "ansa" number 8999 into bib1.att, ccl.properties and records.abs - Index a biblio with a value on this index, ie "VALUE" - Perform a search on this index by editing url : http://<server>/cgi-bin/koha/catalogue/search.pl?idx=ansa&q=VALUE => Without patch, the search does not work. The PQF query is "@and ansa: VALUE" => With patch, the search works. The PQF query is "@attr 1=8999 VALUE"; - Perform same test with an index containing a structure ie "aphra" - Set QueryAutoTruncate syspref to automatically => Check * is added to operand : PQF query is "@attr 1=8999 @attr 4=6 @attr 5=1 VALUE" - You may check stopwords removal but this feature is obsolete Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: as far as I can test, this works. Small tab error reported by koha-qa, fixed in a followup. This kind of patch is difficult to test without explicit instructions, not everyone knows how to check what kind of PQF search is used. I don't know. But I can test search results. Test: 1) Deactivate search sysprefs QueryAutoTruncate = only if * is added QueryFuzzy = Don't try QueryStemming = Don't try QueryWeightFields = Disable UseQueryParser = Do not try 2) Create new index 'ansa' bib1.att : att 8999 ansa ccl.properties : ansa 1=8999 records.abs : melm 999 ansa:w,ansa:p 1) and 2) from comment 3 on Bug 3) In the undestanding that index refers to field 999, edited default framework, made 999a visible on editor 4) Edit sample record, add 'VALUE' to 999a, save, reindex 5) Search with /cgi-bin/koha/catalogue/search.pl?idx=ansa&q=VALUE No results 6) Apply patch, repeat search Got results That's all I can test. If not enough for QA, then this must wait until further and explicit test instructions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21298|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22233&action=edit Bug 10271 - followup - Correct tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a patch that adds a regression test. For MARC21, there is an existing index that this patch fixes: Code-institution. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes.