[Bug 32155] New: Course reserves - instructors display is misaligned on course information page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Bug ID: 32155 Summary: Course reserves - instructors display is misaligned on course information page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 143587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143587&action=edit Screenshot - course information instructor misalignment On the course reserve information page, the instructors section is misaligned. See the attached screenshot. To replicate: 1. Create or edit an existing course. 2. Search and add an instructor. 3. Note that the columns are misaligned: the name of the course instructor is shown first, then the label "Instructors" is shown next. 4. Add another three instructors. 5. Note that this pushes the labels for the next few fields to the right. Note that bug 32146 fixes the page-section style. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |30952 Blocks|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 143874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143874&action=edit Bug 32155: Fix alignment of course details page This patch eliminates some unnessesary CSS and converts the course details div into a fieldset. To test: 1. Create or edit an existing course. 2. Search and add an instructor. 3. Note that the columns are misaligned: the name of the course instructor is shown first, then the label "Instructors" is shown next. 4. Add another three instructors. 5. Note that this pushes the labels for the next few fields to the right. 6. Apply patch 7. Try steps 1-4 again and confirm everthing looks and works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143874|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143879&action=edit Bug 32155: Fix alignment of course details page This patch eliminates some unnessesary CSS and converts the course details div into a fieldset. To test: 1. Create or edit an existing course. 2. Search and add an instructor. 3. Note that the columns are misaligned: the name of the course instructor is shown first, then the label "Instructors" is shown next. 4. Add another three instructors. 5. Note that this pushes the labels for the next few fields to the right. 6. Apply patch 7. Try steps 1-4 again and confirm everthing looks and works correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Lucas for fixing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143879|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143913&action=edit Bug 32155: Fix alignment of course details page This patch eliminates some unnessesary CSS and converts the course details div into a fieldset. To test: 1. Create or edit an existing course. 2. Search and add an instructor. 3. Note that the columns are misaligned: the name of the course instructor is shown first, then the label "Instructors" is shown next. 4. Add another three instructors. 5. Note that this pushes the labels for the next few fields to the right. 6. Apply patch 7. Try steps 1-4 again and confirm everthing looks and works correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155 Bug 32155 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org