[Bug 41518] New: "Scheduled for automatic renewal" displays even if patron does not allow automatic renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 Bug ID: 41518 Summary: "Scheduled for automatic renewal" displays even if patron does not allow automatic renewals Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com As discussed in bug 36021, the "Scheduled for automatic renewal" displays if the checkout has auto_renew set, but if the patron does not have "autorenew_checkouts", it doesn't make sense to say it's scheduled for automatic renewal, since automatic_renewals.pl won't select checkouts from that borrower. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36021 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 190883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190883&action=edit Bug 41518: Only show autorenewal text if autorenewal allowed This change makes the "Scheduled for automatic renewal" text appear in the staff interface and OPAC only if both the issue has auto_renew and the borrower has autorenew_checkouts set. These are the criteria that automatic_renewals.pl uses for processing automatic renewals. Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Checkout an item as an automatic renewal (ie either set it as Automatic renewal using the checkout option or have the circ and fines rules set to use Automatic renewals) 3. View the checkout in both the staff interface and the OPAC 4. Note that they both show "Scheduled for automatic renewal" or "This item is scheduled for auto renewal" for the OPAC 5. In the patron record change "Allow auto-renewal of items" from "Yes" to "No" 6. Note that the text talking about the item being scheduled for automatic renewal no longer displays Bonus points: 1. Run 'perl ./misc/cronjobs/automatic_renewals.pl -v' 2. Note that the automatic renewal doesn't show when "Allow auto-renewal of items" is set to "No" but it does show when it's set to "Yes" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jessica.andersson@alingsas. | |se, | |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem@etf.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- How does this sound to people? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 192171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192171&action=edit Bug 41518: Only show autorenewal text if autorenewal allowed This change makes the "Scheduled for automatic renewal" text appear in the staff interface and OPAC only if both the issue has auto_renew and the borrower has autorenew_checkouts set. These are the criteria that automatic_renewals.pl uses for processing automatic renewals. Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Checkout an item as an automatic renewal (ie either set it as Automatic renewal using the checkout option or have the circ and fines rules set to use Automatic renewals) 3. View the checkout in both the staff interface and the OPAC 4. Note that they both show "Scheduled for automatic renewal" or "This item is scheduled for auto renewal" for the OPAC 5. In the patron record change "Allow auto-renewal of items" from "Yes" to "No" 6. Note that the text talking about the item being scheduled for automatic renewal no longer displays Bonus points: 1. Run 'perl ./misc/cronjobs/automatic_renewals.pl -v' 2. Note that the automatic renewal doesn't show when "Allow auto-renewal of items" is set to "No" but it does show when it's set to "Yes" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This change makes the release notes| |"Scheduled for automatic | |renewal" text only appear | |in the renew column of | |checkouts table in the | |staff interface and OPAC | |when the item will | |automatically be renewed. | | | |The text was showing, even | |if the item would not | |automatically be renewed | |(either from circulation | |rules, or where the patron | |record has "Allow | |auto-renewal of items" set | |to no under library | |management). | | | |This now matches the | |criteria that | |misc/cronjobs/automatic_ren | |ewals.pl uses for | |processing automatic | |renewals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This change makes the |This change makes the release notes|"Scheduled for automatic |"Scheduled for automatic |renewal" text only appear |renewal" text only appear |in the renew column of |in the renew column of |checkouts table in the |checkouts table in the |staff interface and OPAC |staff interface and OPAC |when the item will |when the item will actually |automatically be renewed. |be considered for automatic | |renewal. |The text was showing, even | |if the item would not |The text was showing, even |automatically be renewed |if the item would not |(either from circulation |automatically be renewed |rules, or where the patron |due to automatic renewals |record has "Allow |being disallowed at the |auto-renewal of items" set |patron level. |to no under library | |management). |This now matches the | |criteria that |This now matches the |misc/cronjobs/automatic_ren |criteria that |ewals.pl uses for |misc/cronjobs/automatic_ren |processing automatic |ewals.pl uses for |renewals. |processing automatic | |renewals. | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Thanks for that, David. I've tweaked the release notes a bit but thanks for filling them in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #4)
Thanks for that, David. I've tweaked the release notes a bit but thanks for filling them in.
Thanks David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192171|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 193777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193777&action=edit Bug 41518: Only show autorenewal text if autorenewal allowed This change makes the "Scheduled for automatic renewal" text appear in the staff interface and OPAC only if both the issue has auto_renew and the borrower has autorenew_checkouts set. These are the criteria that automatic_renewals.pl uses for processing automatic renewals. Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Checkout an item as an automatic renewal (ie either set it as Automatic renewal using the checkout option or have the circ and fines rules set to use Automatic renewals) 3. View the checkout in both the staff interface and the OPAC 4. Note that they both show "Scheduled for automatic renewal" or "This item is scheduled for auto renewal" for the OPAC 5. In the patron record change "Allow auto-renewal of items" from "Yes" to "No" 6. Note that the text talking about the item being scheduled for automatic renewal no longer displays Bonus points: 1. Run 'perl ./misc/cronjobs/automatic_renewals.pl -v' 2. Note that the automatic renewal doesn't show when "Allow auto-renewal of items" is set to "No" but it does show when it's set to "Yes" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Looks good! Thanks, David! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Emily Lamancusa (emlam) from comment #7)
Looks good! Thanks, David! Passing QA
Thanks, Emily! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.04 |26.05.00,25.11.04,25.05.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: this was pushed for 25.05.11. --LE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.04,25.05.11 |26.05.00,25.11.04,25.05.11, released in| |24.11.16 Status|Pushed to oldstable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.16 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41518 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org