[Bug 28377] New: Use the API to suspend/resume holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Bug ID: 28377 Summary: Use the API to suspend/resume holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have routes for suspending and resuming holds. We can deprecate the svc/holds/* scripts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121129&action=edit Bug 28377: Use the API to suspend/resume holds This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121130&action=edit Bug 28377: (follow-up) Remove svc/hold/{resume|suspend} This files are no longer used and thus removed. Their functionality is already present on the API POST /holds/:hold_id/suspension DELETE /holds/:hold_id/suspension To test: 1. Apply this patch 2. Run: $ git grep 'hold/suspend' $ git grep 'hold/resume' => SUCCESS: No references to the scripts 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28521 [Bug 28521] [OMNIBUS] Replace svc scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28377: Use the API to suspend/resume holds Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt M koha-tmpl/intranet-tmpl/prog/js/holds.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/holds.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 28377: Use the API to suspend/resume holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121129|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125052&action=edit Bug 28377: Use the API to suspend/resume holds This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121130|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 125053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125053&action=edit Bug 28377: (follow-up) Remove svc/hold/{resume|suspend} This files are no longer used and thus removed. Their functionality is already present on the API POST /holds/:hold_id/suspension DELETE /holds/:hold_id/suspension To test: 1. Apply this patch 2. Run: $ git grep 'hold/suspend' $ git grep 'hold/resume' => SUCCESS: No references to the scripts 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #3)
Patch no longer applies 8-(..
Thanks for your time! Rebased! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125052|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 125057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125057&action=edit Bug 28377: Use the API to suspend/resume holds This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125053|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 125058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125058&action=edit Bug 28377: (follow-up) Remove svc/hold/{resume|suspend} This files are no longer used and thus removed. Their functionality is already present on the API POST /holds/:hold_id/suspension DELETE /holds/:hold_id/suspension To test: 1. Apply this patch 2. Run: $ git grep 'hold/suspend' $ git grep 'hold/resume' => SUCCESS: No references to the scripts 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Given this patchset includes getting and settings dates via the API I believe it will fall short on the same grounds that bug 24608 is currently stuck. We need to properly handle RFC dates in dt_from_string before I'd be comfortable with us moving to using the API for date setting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #9)
Given this patchset includes getting and settings dates via the API I believe it will fall short on the same grounds that bug 24608 is currently stuck.
We need to properly handle RFC dates in dt_from_string before I'd be comfortable with us moving to using the API for date setting.
Is there a bug for RFC dates and should this be moved to BLOCKED? I'd not like to do so with a clear path forward (bug dependencies) tbh. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24850 Status|Signed Off |BLOCKED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Verified the bug in question that needs resolving first would be bug 24850. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 [Bug 22206] Add routes to enable suspension or resumption of holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125057|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127270&action=edit Bug 28377: Use the API to suspend/resume holds This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125058|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127271&action=edit Bug 28377: (follow-up) Remove svc/hold/{resume|suspend} This files are no longer used and thus removed. Their functionality is already present on the API POST /holds/:hold_id/suspension DELETE /holds/:hold_id/suspension To test: 1. Apply this patch 2. Run: $ git grep 'hold/suspend' $ git grep 'hold/resume' => SUCCESS: No references to the scripts 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, great work.. all works as expected :). Passing QA.. I thought it OK to remove the /svc scripts without a deprecation warning as in theory /svc was always a private api. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Bug 28377 depends on bug 24850, which changed state. Bug 24850 Summary: Koha::DateUtils ignores offsets in RFC3339 datetimes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- "Suspend until" is not saved. + var suspend_until_date = $("#suspend-modal-until").datepicker("getDate"); We are not using flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- + if (jqXHR.status === 404) { What about other errors? We shouldn't ignore them IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #15)
"Suspend until" is not saved.
+ var suspend_until_date = $("#suspend-modal-until").datepicker("getDate");
We are not using flatpickr
Right, it was migrated after the patches were tested.
+ if (jqXHR.status === 404) {
What about other errors? We shouldn't ignore them IMO.
I'm not sure. I mean, it is doing the exact same thing it did before. Would you agree with a fallback for the rest of the errors like 'Your request could not be processed. Check the logs' kind of thing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #17)
(In reply to Jonathan Druart from comment #15)
+ if (jqXHR.status === 404) {
What about other errors? We shouldn't ignore them IMO.
I'm not sure. I mean, it is doing the exact same thing it did before. Would you agree with a fallback for the rest of the errors like 'Your request could not be processed. Check the logs' kind of thing?
Yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #18)
(In reply to Tomás Cohen Arazi from comment #17)
(In reply to Jonathan Druart from comment #15)
+ if (jqXHR.status === 404) {
What about other errors? We shouldn't ignore them IMO.
I'm not sure. I mean, it is doing the exact same thing it did before. Would you agree with a fallback for the rest of the errors like 'Your request could not be processed. Check the logs' kind of thing?
Yes.
Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128380&action=edit Bug 28377: (28937 follow-up) Flatpickr change Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128381&action=edit Bug 28377: (QA follow-up) Fallback error handling The code only dealt with 404, this patch makes it have a fallback message for failure codes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127270|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128402&action=edit Bug 28377: Use the API to suspend/resume holds This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127271|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128403&action=edit Bug 28377: (follow-up) Remove svc/hold/{resume|suspend} This files are no longer used and thus removed. Their functionality is already present on the API POST /holds/:hold_id/suspension DELETE /holds/:hold_id/suspension To test: 1. Apply this patch 2. Run: $ git grep 'hold/suspend' $ git grep 'hold/resume' => SUCCESS: No references to the scripts 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128380|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128404&action=edit Bug 28377: (28937 follow-up) Flatpickr change Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128381|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128405&action=edit Bug 28377: (QA follow-up) Fallback error handling The code only dealt with 404, this patch makes it have a fallback message for failure codes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Retested, back to PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the patron page (detail and | |circulation) so that is | |uses the API to suspend and | |resume holds on the holds | |tab. | | | |It also removes the | |svc/hold/{resume|suspend} | |files as they are no longer | |used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- + alert(_("Your request could not be processed. Check the logs")); It is in holds.js, shouldn't it use __("foo") ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #27)
+ alert(_("Your request could not be processed. Check the logs")); It is in holds.js, shouldn't it use __("foo") ?
Yes, good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128458&action=edit Bug 28377: (QA follow-up) .js files should use __() As noted by QA, this bug contained uses of _() which is not correct in include .js files [1]. There was another occurence from prior patches (mine :-/) that gets fixed as well. [1] https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_transla... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Fridolin Somers from comment #27)
+ alert(_("Your request could not be processed. Check the logs")); It is in holds.js, shouldn't it use __("foo") ?
Thanks for spotting that. I was really lost in the translation arena until you pointed this here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #29)
There was another occurence from prior patches (mine :-/) that gets fixed as well.
Should be on its own bug report if it's in stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128458|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128461&action=edit Bug 28377: (QA follow-up) .js files should use __() As noted by QA, this bug contained uses of _() which is not correct in include .js files [1]. [1] https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_transla... Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #31)
(In reply to Tomás Cohen Arazi from comment #29)
There was another occurence from prior patches (mine :-/) that gets fixed as well.
Should be on its own bug report if it's in stable.
Right, removed from here, submitting somewhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23149 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org