[Bug 6902] New: Add integration for EBSCO's Novelist Select service
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Bug #: 6902 Summary: Add integration for EBSCO's Novelist Select service Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: OPAC AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org Add support for Novelist Select content to be displayed in the OPAC Add a group of preferences to the Enhanced Content tab for Novelist NovelistSelectEnabled NovelistSelectProfile NovelistSelectPassword NovelistSelectView Integrate Novelist content in to the bib detail page in the OPAC (in NovelistSelectEnabled is set to "enabled") If NovelistSelectView indicates “in a tab” (the default setting), then a new tab shall be added along side the holdings, title notes, comments, etc. If NovelistSelectView indicates “beneath the Holdings table”, the content shall appear below the holdings table. If NovelistSelectView indicates “above the Holdings table”, the content shall appear above the holdings table. If NovelistSelectView indicates “under Save Record”, the content shall appear below the Save Record div, on the right of the screen. The precise content, HTML and styling will be handled by EBSCO as part of the Novelist Select service. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-22 20:27:50 UTC --- Created attachment 5547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5547 Proposed Patch (functionality) Adds Novelist Select functionality to OPAC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 --- Comment #2 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-22 20:28:35 UTC --- Created attachment 5548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5548 Proposed patch (DB changes) Adds necessary sysprefs to sysprefs.sql and updatedatabase.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5547|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-10-07 15:23:19 UTC --- Created attachment 5776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5776 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5548|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-10-07 15:28:15 UTC --- Created attachment 5777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5777 Signed-off patch These patches tested fine for me. The changes to the code are minimal, since the Novelist data, like LibraryThing data, is pulled in via JavaScript. A couple of comments, neither of which would prevent this from going forward: The option to put the content in the right-hand sidebar doesn't really work well because of the quantity of content. It's too squeezed. Since the position of the content is controlled by a system preference, this is easily avoided. A good follow-up might be to add <noscript> text following the model of the LibraryThing content. Otherwise users with JS disabled will see the Novelist heading but no content and no explanation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-07 16:42:55 UTC --- Chris, as this patch introduces new strings, I'd like to mark Passed QA now. This is purely self-interest, however, and I would prefer another set of eyes on it. It's largely a template-only change, and turning off the feature leave the OPAC exactly as it is now, but I just feel shady about pushing this through when I'm the author. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-11 02:30:16 UTC --- Have tested this, it introduces no regressions and is a nice feature, pushing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- As far as I can tell, this is working properly. Closing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6902 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11606 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org