http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11392 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@pttk.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@pttk.fi> --- Created attachment 28126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28126&action=edit Allow translating the viewlog module and action names When viewing the logs, the user can see module and action, such as "SYSTEMPREFERENCE", "MEMBERS" or "CREATE", "MODIFY", etc. These texts are not translatable. This patch allows translating those. It also adds the missing "CREATE" action to the pulldown. To test: 1) Go browse the system logs. Note the contents of the "Action" and "Module" -pulldowns, and the contents of those columns in the log table. 2) Apply patch 3) Go browse the system logs again. The pull-downs should work, and show the same values as before (plus "Create" for Action), and the Action and Module -columns in the log table should not be in ALL CAPS. 4) cd misc/translator 5) perl translate update xx-YY 6) Check that the po/xx-YY-i-staff-t-prog-v-3006000.po contains the values for the pull-downs in it. (Look for eg. "System prefs") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11392 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28126|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 28191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28191&action=edit Bug 11392: Allow translating the viewlog module and action names When viewing the logs, the user can see module and action, such as "SYSTEMPREFERENCE", "MEMBERS" or "CREATE", "MODIFY", etc. These texts are not translatable. This patch allows translating those. It also adds the missing "CREATE" action to the pulldown. To test: 1) Go browse the system logs. Note the contents of the "Action" and "Module" -pulldowns, and the contents of those columns in the log table. 2) Apply patch 3) Go browse the system logs again. The pull-downs should work, and show the same values as before (plus "Create" for Action), and the Action and Module -columns in the log table should not be in ALL CAPS. 4) cd misc/translator 5) perl translate update xx-YY 6) Check that the po/xx-YY-i-staff-t-prog-v-3006000.po contains the values for the pull-downs in it. (Look for eg. "System prefs") Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11392 --- Comment #4 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Jonathan Druart from comment #3)

I got

"%s %s %s %s %sCatalog %sAuthorities %sPatrons %sAcquisitions %sSerials " "%sCirculation %sLetter %sFines %sSystem prefs %s%s %s %s %s %s %sAdd " "%sDelete %sModify %sCheckout %sReturn %sCreate %s%s %s %s " msgstr ""

in the po file. Is it what is expected?

Yes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11392 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28191|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28276&action=edit Bug 11392: Allow translating the viewlog module and action names When viewing the logs, the user can see module and action, such as "SYSTEMPREFERENCE", "MEMBERS" or "CREATE", "MODIFY", etc. These texts are not translatable. This patch allows translating those. It also adds the missing "CREATE" action to the pulldown. To test: 1) Go browse the system logs. Note the contents of the "Action" and "Module" -pulldowns, and the contents of those columns in the log table. 2) Apply patch 3) Go browse the system logs again. The pull-downs should work, and show the same values as before (plus "Create" for Action), and the Action and Module -columns in the log table should not be in ALL CAPS. 4) cd misc/translator 5) perl translate update xx-YY 6) Check that the po/xx-YY-i-staff-t-prog-v-3006000.po contains the values for the pull-downs in it. (Look for eg. "System prefs") Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11392 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master and 3.16.x, along with a follow-up that fixes a syntax error in the Template (that maybe TT didn't care about in previous versions?) Thanks, Pasi! -- You are receiving this mail because: You are watching all bug changes.