[Bug 25893] New: Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Bug ID: 25893 Summary: Log viewer no longer searches using wildcards Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 22363 updated the log viewer from using C4::Logs::GetLogs to Koha::ActionLogs->search, however, GetLogs appended wildcards to the search and viewlogs.pl does not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |22363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 [Bug 22363] Move C4::Logs::GetLogs to Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 106415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106415&action=edit Bug 25893: Use wildcards when searching logs The restores the wildcards that were used in the past I also clean up a few warns and unused param To test: 0 - Ensure cataloguing logs and issues logs are enabled 1 - Edit an item 2 - Circulate that same item 3 - Browse to tools-> log viewer 4 - Put the itemnumber in the 'info' box 5 - You see only the circulation 6 - Put the itemnumber in the object box 7 - You see only the cataloging modification 8 - Apply patch 9 - Put itemnumber in info box 10 - you see both actions 11 - Put the itemnumber in the object box 12 - You see only the catalogiong modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106415|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106433&action=edit Bug 25893: Use wildcards when searching logs The restores the wildcards that were used in the past I also clean up a few warns and unused param To test: 0 - Ensure cataloguing logs and issues logs are enabled 1 - Edit an item 2 - Circulate that same item 3 - Browse to tools-> log viewer 4 - Put the itemnumber in the 'info' box 5 - You see only the circulation 6 - Put the itemnumber in the object box 7 - You see only the cataloging modification 8 - Apply patch 9 - Put itemnumber in info box 10 - you see both actions 11 - Put the itemnumber in the object box 12 - You see only the catalogiong modification Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |matthias.meusburger@biblibr | |e.com --- Comment #3 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- The patch works as intended. However, using a wildcard on object (which is an identifier) does not seem to be a good idea, since you will retrieve many unwanted results. Moreover, the wildcard in C4::Logs::GetLogs was only on info, and not on object: if ($object) { $query .= " AND object = ? "; push( @parameters, $object ); } Hence, it doesn't restore the old behavior, but changes it. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 106602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106602&action=edit Bug 25893: Don't wildcard object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Matthias Meusburger from comment #3)
The patch works as intended.
However, using a wildcard on object (which is an identifier) does not seem to be a good idea, since you will retrieve many unwanted results.
Moreover, the wildcard in C4::Logs::GetLogs was only on info, and not on object:
if ($object) { $query .= " AND object = ? "; push( @parameters, $object ); }
Hence, it doesn't restore the old behavior, but changes it.
What do you think?
Yup, I just got mixed up, removed wildcards from object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think a better example for why this is useful is searching for system preference changes. Like put any pref in info to see when it was toggled and to which settings. It doesn't work without this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106602|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106891&action=edit Bug 25893: Don't wildcard object Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106433|0 |1 is obsolete| | Attachment #106891|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107084&action=edit Bug 25893: Use wildcards when searching logs The restores the wildcards that were used in the past I also clean up a few warns and unused param To test: 0 - Ensure cataloguing logs and issues logs are enabled 1 - Edit an item 2 - Circulate that same item 3 - Browse to tools-> log viewer 4 - Put the itemnumber in the 'info' box 5 - You see only the circulation 6 - Put the itemnumber in the object box 7 - You see only the cataloging modification 8 - Apply patch 9 - Put itemnumber in info box 10 - you see both actions 11 - Put the itemnumber in the object box 12 - You see only the catalogiong modification Signed-off-by: Jason Robb <jrobb@sekls.org> Bug 25893: Don't wildcard object Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The removal of enabled_staff_search_views is not correct. koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt 316 [% INCLUDE 'biblio-view-menu.inc' %] Usually it's not a good idea to embed unrelated changes ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107084|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107802&action=edit Bug 25893: Use wildcards when searching logs The restores the wildcards that were used in the past To test: 0 - Ensure cataloguing logs and issues logs are enabled 1 - Edit an item 2 - Circulate that same item 3 - Browse to tools-> log viewer 4 - Put the itemnumber in the 'info' box 5 - You see only the circulation 6 - Put the itemnumber in the object box 7 - You see only the cataloging modification 8 - Apply patch 9 - Put itemnumber in info box 10 - you see both actions 11 - Put the itemnumber in the object box 12 - You see only the catalogiong modification Signed-off-by: Jason Robb <jrobb@sekls.org> Bug 25893: Don't wildcard object Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107803&action=edit Bug 25893: (follow-up) Undo unrelated changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26137 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107802|0 |1 is obsolete| | Attachment #107803|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107869&action=edit Bug 25893: Use wildcards when searching logs The restores the wildcards that were used in the past To test: 0 - Ensure cataloguing logs and issues logs are enabled 1 - Edit an item 2 - Circulate that same item 3 - Browse to tools-> log viewer 4 - Put the itemnumber in the 'info' box 5 - You see only the circulation 6 - Put the itemnumber in the object box 7 - You see only the cataloging modification 8 - Apply patch 9 - Put itemnumber in info box 10 - you see both actions 11 - Put the itemnumber in the object box 12 - You see only the catalogiong modification Signed-off-by: Jason Robb <jrobb@sekls.org> Bug 25893: Don't wildcard object Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 25893: (follow-up) Undo unrelated changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in| |19.11.09 CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org