[Bug 27733] New: Sort pickup locations by library name instead of branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Bug ID: 27733 Summary: Sort pickup locations by library name instead of branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org Depends on: 27732 When you start the process of placing a hold in the staff interface for a title which already has holds, the table showing information about those holds has controls for changing the existing holds' pickup location. That dropdown queries the API to get available pickup locations, but the list of libraries is returned in order by branchcode. It should be ordered by library name instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27732 [Bug 27732] JavaScript error on place hold page in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117087&action=edit Bug 27733: Add "_sort_by" paramter to pickup_locations API query On the place hold page in the staff interface, add a "_sort_by" parameter with the "name" value so that the list of libraries is returned in name order. To test, apply the patch and locate a title in the staff interface which has holds on it. - View the holds information for that title. - In the table of exising holds, expand the "Pickup library" dropdown for any of the entries. The list of libraries should be in order by library name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117087|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 117093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117093&action=edit Bug 27733: Add "_sort_by" paramter to pickup_locations API query On the place hold page in the staff interface, add a "_sort_by" parameter with the "name" value so that the list of libraries is returned in name order. To test, apply the patch and locate a title in the staff interface which has holds on it. - View the holds information for that title. - In the table of exising holds, expand the "Pickup library" dropdown for any of the entries. The list of libraries should be in order by library name. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Much better, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117093|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117159&action=edit Bug 27733: Add "_sort_by" paramter to pickup_locations API query On the place hold page in the staff interface, add a "_sort_by" parameter with the "name" value so that the list of libraries is returned in name order. To test, apply the patch and locate a title in the staff interface which has holds on it. - View the holds information for that title. - In the table of exising holds, expand the "Pickup library" dropdown for any of the entries. The list of libraries should be in order by library name. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Bug 27733 depends on bug 27732, which changed state. Bug 27732 Summary: JavaScript error on place hold page in the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27732 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27733 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27732 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org