https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51609&action=edit Bug 16549 - Remove the use of "onclick" from header search forms This patch removes the use of "onclick" from all header search forms for the purpose of triggering the "keep_text" function. This behavior is now handled in the globally-included JS file. To test, apply the patch and clear your cache if necessary. - Enter text in any header search form field. Click to each other tab in the header and confirm that your text is copied to each. - Test the behavior of the header search form on at least one page where each is included: - The staff client home page - The advanced search page - The authorities home page - The administration home page - The cataloging home page - The checkin page - The circulation home page - The patrons home page - Acquisitions -> Vendor -> Contracts - Administration -> Cities - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Printers (why is this page still around?) - Administration -> System preferences - Administration -> Z39.50/SRU servers - Tools -> Notices & slips This patch modifies does not fix the existing (unreported) bug which prevents the keep text function from working in the include file used on these pages: - Acquisitions -> Vendor -> Basket -> New order from suggestion - Administration -> Budgets - The serials home page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51609|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 51981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51981&action=edit Bug 16549 - Remove the use of "onclick" from header search forms This patch removes the use of "onclick" from all header search forms for the purpose of triggering the "keep_text" function. This behavior is now handled in the globally-included JS file. To test, apply the patch and clear your cache if necessary. - Enter text in any header search form field. Click to each other tab in the header and confirm that your text is copied to each. - Test the behavior of the header search form on at least one page where each is included: - The staff client home page - The advanced search page - The authorities home page - The administration home page - The cataloging home page - The checkin page - The circulation home page - The patrons home page - Acquisitions -> Vendor -> Contracts - Administration -> Cities - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Printers (why is this page still around?) - Administration -> System preferences - Administration -> Z39.50/SRU servers - Tools -> Notices & slips This patch modifies does not fix the existing (unreported) bug which prevents the keep text function from working in the include file used on these pages: - Acquisitions -> Vendor -> Basket -> New order from suggestion - Administration -> Budgets - The serials home page Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51981|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52646&action=edit Bug 16549 - Remove the use of "onclick" from header search forms This patch removes the use of "onclick" from all header search forms for the purpose of triggering the "keep_text" function. This behavior is now handled in the globally-included JS file. To test, apply the patch and clear your cache if necessary. - Enter text in any header search form field. Click to each other tab in the header and confirm that your text is copied to each. - Test the behavior of the header search form on at least one page where each is included: - The staff client home page - The advanced search page - The authorities home page - The administration home page - The cataloging home page - The checkin page - The circulation home page - The patrons home page - Acquisitions -> Vendor -> Contracts - Administration -> Cities - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Printers (why is this page still around?) - Administration -> System preferences - Administration -> Z39.50/SRU servers - Tools -> Notices & slips This patch modifies does not fix the existing (unreported) bug which prevents the keep text function from working in the include file used on these pages: - Acquisitions -> Vendor -> Basket -> New order from suggestion - Administration -> Budgets - The serials home page Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Colin Campbell from comment #6)

This patch appears to introduce a bug reverting previous behaviour.

This should be fixed by Bug 16903, which says it has been pushed to master but I don't think it really has been. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16903 -- You are receiving this mail because: You are watching all bug changes.