[Bug 16363] New: Use floating toolbar on advanced search and item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Bug ID: 16363 Summary: Use floating toolbar on advanced search and item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use floating toolbar on |Use floating toolbar on |advanced search and item |advanced search |search | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50784&action=edit Bug 16363: Add floating toolbar to advanced search To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I like the look of the toolbar. I'm not sure about the change from "new search" to "clear fields." I'd like to hear more opinions on that. I would like to see one minor change: Toolbar buttons should use "btn-small" instead of "btn-mini." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50847&action=edit This is how it should look showing fewer options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50847|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Comment on attachment 50847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50847 This is how it should look showing fewer options Sorry, wrong bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50784|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50849&action=edit Bug 16363: Add floating toolbar to advanced search EDIT: Ah yes I was so sure it wasn't mini but couldn't remember what to use! Thanks for that Owen To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50849|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50857&action=edit [SIGNED-OFF] Bug 16363: Add floating toolbar to advanced search EDIT: Ah yes I was so sure it wasn't mini but couldn't remember what to use! Thanks for that Owen To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50857|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50891&action=edit [PASSED QA] Bug 16363: Add floating toolbar to advanced search EDIT: Ah yes I was so sure it wasn't mini but couldn't remember what to use! Thanks for that Owen To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Should be in the May 2016 release! Shukran Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just found a bug, to reproduce: - Click on more options - you get /catalogue/search.pl?expanded_options=1 - Click on "Clear fields" - you get /catalogue/search.pl?do=Clear => You have lost the expanded_options flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #10)
=> You have lost the expanded_options flag
As far as I can tell this bug existed before the changes made by this patch. I can reproduce it in our 3.18.x catalog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #11)
(In reply to Jonathan Druart from comment #10)
=> You have lost the expanded_options flag
As far as I can tell this bug existed before the changes made by this patch. I can reproduce it in our 3.18.x catalog.
Indeed! I have opened bug 16398. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16398 [Bug 16398] Keep expanded view after clearing the search form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confused - I don't see the floating toolbar in master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16363 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Never mind - a problem with my branch not being as current as I had thought. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org