[Bug 28690] New: Important and mandatory not checked on all item forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 Bug ID: 28690 Summary: Important and mandatory not checked on all item forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If item subfields has marked as mandatory or important, there is no alert when the item is added from the acquisition or serial modules. acqui/neworderempty.tt: var empty_item_mandatory = CheckMandatorySubfields(ff); acqui/orderreceive.tt: var total_errors = CheckMandatorySubfields(form); serials/serials-edit.tt: total_errors = total_errors + CheckMandatorySubfields(this); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27526 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122859&action=edit Bug 28689: Extra %s in alert message when saving an items This patch removes an unnecessary %s in the text built to show when there are errors in the cataloging add item form. To reproduce, open the add item form in cataloging and click "Add item" without filling in all mandatory fields. You should see an alert message that contains, "- %s 1 mandatory fields empty (highlighted)" To test, apply the patch and return to the add item form. Now when you save an incomplete form the message should omit the %s: - 1 mandatory fields empty (highlighted) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122859|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #1)
Created attachment 122859 [details] [review] Bug 28689: Extra %s in alert message when saving an items
Sorry, wrong bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 --- Comment #3 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Hi Jonathan, I am testing Koha 20.11.10. In acquisition module i can't reproduce the problem on neworderempty.pl (it works for me) but I can notice this problem in addorderiso2709.pl (cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=777&basketno=9077&booksellerid=131). When placing orders from a batch (from a staged file as Electre). Hope it can help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org