[Bug 25605] New: exporting report as a tab delimited file can produce a lot of warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Bug ID: 25605 Summary: exporting report as a tab delimited file can produce a lot of warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: didier.gautheron@biblibre.com Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org tabulation export uses a plain join function, but if there's null values you get zillion: Use of uninitialized value in join or string at /kohadevbox/koha/reports/guided_reports.pl line 904. in /var/log/koha/kohadev/plack-error.log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 --- Comment #1 from didier <didier.gautheron@biblibre.com> --- Created attachment 105357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105357&action=edit Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text Test plan : 1- Create a new report : select * from items; 2- Run it 3- Download the report as a tab separated text 4- There's a lot of 'use of uninitialized value in join or string at ...koha/reports/guided_reports.pl line xxx.' in plack-error.log 5- Apply patch 6- Restart all 7- Redo 2 and 3 8- No more warning. 9- diff both downloaded files, they must be the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105357|0 |1 is obsolete| | --- Comment #2 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108509&action=edit Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text Test plan : 1- Create a new report : select * from items; 2- Run it 3- Download the report as a tab separated text 4- There's a lot of 'use of uninitialized value in join or string at ...koha/reports/guided_reports.pl line xxx.' in plack-error.log 5- Apply patch 6- Restart all 7- Redo 2 and 3 8- No more warning. 9- diff both downloaded files, they must be the same. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |marco.abi-ramia@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|exporting report as a tab |Exporting report as a tab |delimited file can produce |delimited file can produce |a lot of warning |a lot of warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108509|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108561&action=edit Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text Test plan : 1- Create a new report : select * from items; 2- Run it 3- Download the report as a tab separated text 4- There's a lot of 'use of uninitialized value in join or string at ...koha/reports/guided_reports.pl line xxx.' in plack-error.log 5- Apply patch 6- Restart all 7- Redo 2 and 3 8- No more warning. 9- diff both downloaded files, they must be the same. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Severity|trivial |enhancement --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org