[Bug 38776] New: Propose a list of value for restriction comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Bug ID: 38776 Summary: Propose a list of value for restriction comment Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It would be nice to let librarians use one of several pre-filled values in the restriction comment for a manual restrictions. The values could be provided by authorised value with category "R_COMMENTS". Values could be selected although another comment could be hand-typed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 175912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175912&action=edit Bug 38776: new "R_COMMENTS" authorized value category for manual restrictions comments Test plan : - on a patron page, add a manual restriction and fill in a comment, that needs to be typed-in - apply patch - create a new authorized value category named "R_COMMENTS" and create a couple of values with a description - return to patron page and when adding a manual restriction, on click on the input field you would be proposed the authorized values descriptions. - also you can inspect the code and see that there is a datalist element containing the list of options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Arthur, I like the idea, but there are some issues: 1) Category name I feel "R_COMMENTS" is too general. I think we don't need to save on characters here looking at some of the other categories. What about RESTRICTION_COMMENTS? 2) Replacing free text with authorised value list This removes the option to add free text entries which might be a needed feature for libraries. I see 2 possible solutions here: a) Only display if there are existing values for the AV category. b) Allow both: selecting from the list and free text (like the reasons pull down in suggestions) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Realize this is still NEW, so you are probably still working on it, but just in case: 3) Category needs to be added to sample data (just the category, even if no sample values) 4) Database update to add the category. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi Katrin, Indeed this is still a work in progress :) I'll take all your remarks and make a followup. Have a nice year 2025 (and following!) Arthur -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 176160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176160&action=edit Bug 38776: (QA follow-up) UI improvement + category renamed - The authorised value category was renamed from "R_COMMENTS" to a more explicit value : "RESTRICTION_COMMENTS" - It is now easier in the patron detail page to either select one of the defined value or to fill in a custom value (select "other" then type your comment). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Oups, I forgot to say it in the commit message but I've also made an atomicbug to create the authorised_value_category. I didn't fill in any default value though, because this could change from a library to another + it is not mandatory to have authorised_value for Koha to work (previous behavior preserved). This is for admin to save some librarian time by filling in some pre-defined restriction_comments frequently occurring values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |e.betemps@gmail.com --- Comment #7 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, I just tested this patch (on a sandbox) I created 2 authorised values and the drop-menu displays them it also displays an 'Others' reason That works ! But, once the manual restriction added, there is only 'Indefinite' displayed on the patron's account; the reason (authorised value) and its comment (free text) aren't displayed (neither on top of this screen neither in the Restriction tab) (indefinite is linked to the expiration date (and I didn't fill that field) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- I have to make a followup anyway but just demonstrating how it works. https://youtu.be/4PlaQASVeEs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 176493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176493&action=edit Bug 38776: (QA follow-up) hide the other_reason text field on page load -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hello Emmanuel, I cannot reproduce your issue :/ Can you retry after a page refresh? It is possible that the javascript is improperly loaded from your cache instead of latest version from source. Happy bug squashing with Victor + others :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175912|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 176496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176496&action=edit Bug 38776: new "R_COMMENTS" authorized value category for manual restrictions comments Test plan : - on a patron page, add a manual restriction and fill in a comment, that needs to be typed-in - apply patch - create a new authorized value category named "R_COMMENTS" and create a couple of values with a description - return to patron page and when adding a manual restriction, on click on the input field you would be proposed the authorized values descriptions. - also you can inspect the code and see that there is a datalist element containing the list of options. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176160|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 176497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176497&action=edit Bug 38776: (QA follow-up) UI improvement + category renamed - The authorised value category was renamed from "R_COMMENTS" to a more explicit value : "RESTRICTION_COMMENTS" - It is now easier in the patron detail page to either select one of the defined value or to fill in a custom value (select "other" then type your comment). Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176493|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 176498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176498&action=edit Bug 38776: (QA follow-up) hide the other_reason text field on page load Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The same sandbox and same URL, the form looks correct on my PC. And on Emmanuel's PC we installed Chromium and tried there and it was also broken. Nothing on the OS (also a not too old Linux) should change how Firefox and Chromium on latest version how display basic HTML forms. It's strait up paranormal! 👽 Anyway, it's not something about the patch. Thanks for retesting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176496|0 |1 is obsolete| | Attachment #176497|0 |1 is obsolete| | Attachment #176498|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177857&action=edit Bug 38776: new "R_COMMENTS" authorized value category for manual restrictions comments Test plan : - on a patron page, add a manual restriction and fill in a comment, that needs to be typed-in - apply patch - create a new authorized value category named "R_COMMENTS" and create a couple of values with a description - return to patron page and when adding a manual restriction, on click on the input field you would be proposed the authorized values descriptions. - also you can inspect the code and see that there is a datalist element containing the list of options. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177858&action=edit Bug 38776: (QA follow-up) UI improvement + category renamed - The authorised value category was renamed from "R_COMMENTS" to a more explicit value : "RESTRICTION_COMMENTS" - It is now easier in the patron detail page to either select one of the defined value or to fill in a custom value (select "other" then type your comment). Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177859&action=edit Bug 38776: (QA follow-up) hide the other_reason text field on page load Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Patches rebased using the auto-rebase script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL installer/data/mysql/atomicupdate/bug_38776.pl FAIL file permissions File must have the exec flag + $dbh->do(q{INSERT INTO authorised_value_categories VALUES ('RESTRICTION_COMMENTS',0,0);}); This is the dbrev for an upgrade. But I dont see a patch adding this for new installs in installer/data/mysql/somewhere.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177857|0 |1 is obsolete| | Attachment #177858|0 |1 is obsolete| | Attachment #177859|0 |1 is obsolete| | --- Comment #21 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 188497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188497&action=edit Bug 38776: new "R_COMMENTS" authorized value category for manual restrictions comments Test plan : - on a patron page, add a manual restriction and fill in a comment, that needs to be typed-in - apply patch - create a new authorized value category named "R_COMMENTS" and create a couple of values with a description - return to patron page and when adding a manual restriction, on click on the input field you would be proposed the authorized values descriptions. - also you can inspect the code and see that there is a datalist element containing the list of options. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #22 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 188498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188498&action=edit Bug 38776: (QA follow-up) UI improvement + category renamed - The authorised value category was renamed from "R_COMMENTS" to a more explicit value : "RESTRICTION_COMMENTS" - It is now easier in the patron detail page to either select one of the defined value or to fill in a custom value (select "other" then type your comment). Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #23 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 188499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188499&action=edit Bug 38776: (QA follow-up) hide the other_reason text field on page load Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #24 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 188500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188500&action=edit Bug 38776: (QA follow-up) fix permissions and add mandatory data for new installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #25 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Marcel de Rooy from comment #20)
FAIL installer/data/mysql/atomicupdate/bug_38776.pl FAIL file permissions File must have the exec flag
+ $dbh->do(q{INSERT INTO authorised_value_categories VALUES ('RESTRICTION_COMMENTS',0,0);}); This is the dbrev for an upgrade. But I dont see a patch adding this for new installs in installer/data/mysql/somewhere..
just rebased and fixed the QA comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |adds a new authorised value release notes| |category named | |"RESTRICTION_COMMENTS" for | |librarians to pre-fill | |comments on patrons | |restrictions. | |Those values can then be | |used in a selector on the | |patron's detail to quickly | |set the reason for the | |restriction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38776 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- In my test of this a comment is never added, whether I use the dropdown or the text field. And I think the text field is supposed to be hidden until "Other..." is chosen? For me it is always visible. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org